Bug 101977 - TRACK CHANGES: More uno commands for accepting/rejecting changes
Summary: TRACK CHANGES: More uno commands for accepting/rejecting changes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.0.0
Keywords:
: 83956 (view as bug list)
Depends on:
Blocks: Track-Changes UNO-Command-New
  Show dependency treegraph
 
Reported: 2016-09-07 20:09 UTC by Yousuf Philips (jay) (retired)
Modified: 2019-03-28 15:20 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-09-07 20:09:10 UTC
As we reverted the change of bug 83953 in bug 90597, we need uno commands for 'Accept Change and Next' and 'Reject Change and Next'. We also need uno commands for 'Accept All Changes' and 'Reject All Changes' as these commands are available in the track changes dialog but dont have uno commands.
Comment 1 Heiko Tietze 2016-11-30 08:45:54 UTC
Jay, please double check with bug 83956. Better we have only one ticket regarding uno commands.
Comment 2 Yousuf Philips (jay) (retired) 2016-11-30 22:52:41 UTC
*** Bug 83956 has been marked as a duplicate of this bug. ***
Comment 3 Commit Notification 2017-11-08 03:29:36 UTC
Henry Castro committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2db44bd017daac8f668393bca24911e95125857a

sw lok: add Accept/Reject All tracked changes, tdf#101977

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Yousuf Philips (jay) (retired) 2017-11-08 12:41:21 UTC
Thanks for the patch Henry, but please remove the new uno commands from the context menus.
Comment 5 Commit Notification 2017-11-08 15:24:19 UTC
Henry Castro committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=71c497d0eff0fc4179f31512c75029c48a1c9407

tdf#101977: remove accept/reject all from context menus

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Yousuf Philips (jay) (retired) 2017-11-08 20:31:54 UTC
Henry, the description also requested 'Accept Change and Next' and 'Reject Change and Next' uno commands.
Comment 7 Xisco Faulí 2017-12-10 17:07:35 UTC
(In reply to Yousuf Philips (jay) from comment #6)
> Henry, the description also requested 'Accept Change and Next' and 'Reject
> Change and Next' uno commands.

Hi Yousuf,
Should it be reported in a follow-up bug or are those the remaining pieces to close this issue?
Comment 8 Yousuf Philips (jay) (retired) 2017-12-10 22:34:26 UTC
(In reply to Xisco Faulí from comment #7)
> Should it be reported in a follow-up bug or are those the remaining pieces
> to close this issue?

Yes the addition of the two uno commands in comment 6 are what is remaining to close this bug.
Comment 9 Xisco Faulí 2018-03-12 10:36:10 UTC
Dear Henry Castro,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 10 Henry Castro 2018-03-12 11:27:00 UTC
Hi Xisco,

Sorry I forgot to reset it. I have assigned other priorities and lower this.
Thanks for reset to NEW