As we reverted the change of bug 83953 in bug 90597, we need uno commands for 'Accept Change and Next' and 'Reject Change and Next'. We also need uno commands for 'Accept All Changes' and 'Reject All Changes' as these commands are available in the track changes dialog but dont have uno commands.
Jay, please double check with bug 83956. Better we have only one ticket regarding uno commands.
*** Bug 83956 has been marked as a duplicate of this bug. ***
Henry Castro committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2db44bd017daac8f668393bca24911e95125857a sw lok: add Accept/Reject All tracked changes, tdf#101977 It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for the patch Henry, but please remove the new uno commands from the context menus.
Henry Castro committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=71c497d0eff0fc4179f31512c75029c48a1c9407 tdf#101977: remove accept/reject all from context menus It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry, the description also requested 'Accept Change and Next' and 'Reject Change and Next' uno commands.
(In reply to Yousuf Philips (jay) from comment #6) > Henry, the description also requested 'Accept Change and Next' and 'Reject > Change and Next' uno commands. Hi Yousuf, Should it be reported in a follow-up bug or are those the remaining pieces to close this issue?
(In reply to Xisco Faulí from comment #7) > Should it be reported in a follow-up bug or are those the remaining pieces > to close this issue? Yes the addition of the two uno commands in comment 6 are what is remaining to close this bug.
Dear Henry Castro, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this.
Hi Xisco, Sorry I forgot to reset it. I have assigned other priorities and lower this. Thanks for reset to NEW
Patch in gerrit: https://gerrit.libreoffice.org/#/c/76719/ There are also two more commands in Word that we don't offer: Accept/Reject all and stop tracking changes Do we want to have such from UX POV?
(In reply to Gabor Kelemen from comment #11) > There are also two more commands in Word that we don't offer: > Accept/Reject all and stop tracking changes We have Accept/Reject All and I don't see a reason for Stop. Or rather we have it with Record and Show.
(In reply to Heiko Tietze from comment #12) > (In reply to Gabor Kelemen from comment #11) > > There are also two more commands in Word that we don't offer: > > Accept/Reject all and stop tracking changes > > We have Accept/Reject All and I don't see a reason for Stop. Or rather we > have it with Record and Show. I'm not sure you understood my wording, sorry. Let me try again. Word has "Accept all changes and stop tracking" and "Reject all changes and stop tracking". I guess they provide it as one-stop "finish this change tracking nonsense quickly" commands. Now that we have "Accept all changes" and "Reject all changes" it would be simple to combine them with turning off "Record changes" - to get equivalent commands to what Word has. Is it okay to have such? Our users have not yet explicitly requested it (only accept / reject & move to next), but I'd wager they would start noticing the lack of "what they are used to".
(In reply to Gabor Kelemen from comment #13) > Is it okay to have such? Sounds like an overkill to me. MS bloats the UI just to avoid clicking two buttons. Wouldn't do that.
Shouldn't we better always jump to the next item? Why would anyone want to stay at the same item?
(In reply to Heiko Tietze from comment #15) > Shouldn't we better always jump to the next item? Why would anyone want to > stay at the same item? I must agree; this is also the default behavior of Word. So: how about changing the toolbar to hide the Accept/Reject buttons and show Accept and jump / Reject and jump (once my patch + some new icons is merged) instead? Targeting power users of 30 page & 200 change documents.
(In reply to Yousuf Philips (jay) (retired) from comment #0) > ... we need uno commands > for 'Accept Change and Next' and 'Reject Change and Next'. We also need uno > commands for 'Accept All Changes' and 'Reject All Changes' as these commands > are available in the track changes dialog but dont have uno commands. The missing commands requested from Jay should be implemented and they should be available somewhere in the UI in addition to the menu.
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/1496a1831d1be0a2d24be9fe3ecf627b2664e938%5E%21 tdf#101977 change tracking: add 'Accept/Reject and jump to next' commands It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Note: we need new icons for the extended Track Changes toolbar.
Created attachment 153998 [details] Accept This Change and Accept and Move to Next use Similar Icon
@Andreas Kainz, this might be added to the menubar (Edit > Track Changes ) as well as in Tabbed interface (Review)
(In reply to Rizal Muttaqin from comment #21) > @Andreas Kainz, this might be added to the menubar (Edit > Track Changes ) That makes no sense. See the first comment from Heiko in https://gerrit.libreoffice.org/#/c/76719/ These commands are for working quickly, and digging two levels into the main menu is not a good start for that.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d139529dff85282772d334edcebdccf23d2d9c97 tdf#101977 add new track changes uno commands to writer NB+ menubar It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
andreas kainz committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/e000187243b9b90f9c8c9110fcd9a82c01ba0fe7 tdf#101977 add new track changes uno commands to writer NB+ menubar It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.