Bug 102031 - Sidebar should open deck when pressing key after arriving with F6
Summary: Sidebar should open deck when pressing key after arriving with F6
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords: accessibility
Depends on:
Blocks: Sidebar-Accessibility
  Show dependency treegraph
 
Reported: 2016-09-09 21:53 UTC by Yousuf Philips (jay) (retired)
Modified: 2018-08-30 20:48 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-09-09 21:53:51 UTC
So if you open writer with a new profile, the sidebar is collapsed and only shows the tab bar and when you access the sidebar with F6, it gives focus to the title bar but wont mention that the sidebar deck is closed. So if a user arrives at the sidebar with the deck closed, it should mention that it is closed and should let the user open the deck by press spacebar or enter similar to a regular button.
Comment 1 Buovjaga 2016-10-03 17:18:12 UTC
Confirmed with Orca.

It said something like "Sidebar close button". Then I could press Enter and it opened a dropdown menu, where I could select the different panels etc.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha0+
Build ID: dc41255dc725dfa912326cc5d9e420bd66471c64
CPU Threads: 8; OS Version: Linux 4.7; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on October 1st 2016
Comment 2 Yousuf Philips (jay) (retired) 2016-10-03 18:30:12 UTC
Guess i forgot to mention the other option that the summary states, which is that it opens the sidebar deck when arriving with f6.

@Stuart: What is your take on how f6 should work when it comes to the sidebar? Should it act similar to the main menu and/or toolbar, where f6 lands on the sidebar tab bar, so a11y users can easily use the arrow keys to move between entries as well as know which deck is open (Orca says 'Properties select radio button' when it is open) and press spacebar or enter to activate the deck.
Comment 3 QA Administrators 2017-11-17 09:10:28 UTC Comment hidden (obsolete)
Comment 4 Alex ARNAUD 2017-12-01 13:31:12 UTC
(In reply to Yousuf Philips (jay) from comment #0)
> So if you open writer with a new profile, the sidebar is collapsed and only
> shows the tab bar and when you access the sidebar with F6, it gives focus to
> the title bar but wont mention that the sidebar deck is closed. So if a user
> arrives at the sidebar with the deck closed, it should mention that it is
> closed and should let the user open the deck by press spacebar or enter
> similar to a regular button.

Hello,

I can reproduce the issue on LibreOfficeDev 6.1 from 2017-11-26. IMO, it's shouldn't be possible to navigate through the sidebar when it is closed.

@yousuf @vstuart: what are your opinion about that ?

Best regards.
Comment 5 QA Administrators 2018-07-03 14:16:14 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2018-07-31 09:41:59 UTC Comment hidden (obsolete)
Comment 7 Alex ARNAUD 2018-08-02 16:33:30 UTC
Hello all,

I can reproduce it on LibreOffice 6.1.0.

Best regards,
Alex.
Comment 8 V Stuart Foote 2018-08-02 17:18:31 UTC
Ideally arriving by F6 onto the collapsed Sidebar deck should open the deck to whatever the user had set as active in their profile. E.g. if they'd left it closed to Styles when collapsed it should expand the Styles deck.

At a minimum, landing with F6 with a collapsed deck onto the Tab bar should expand the Properties deck.  As is there is no indication of navigating to the Sidebar because it is not given focus when the deck is collapsed--arrival has no active Tab button.

The F6 and F10 are fundamental (and legacy) keyboard navigation that continue support our Accisibility users. This needs to function in a consistent fashion.
Comment 9 Jim Raykowski 2018-08-07 22:42:27 UTC
A patch for review is here:
https://gerrit.libreoffice.org/#/c/58712/
Comment 10 Buovjaga 2018-08-08 10:12:00 UTC
(In reply to Jim Raykowski from comment #9)
> A patch for review is here:
> https://gerrit.libreoffice.org/#/c/58712/

I confirm with this patch the Sidebar is expanded after cycling with F6 key.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: 8a2c7ee13c2045911fb289a8b3976ef395b557f8
CPU threads: 8; OS: Linux 4.17; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on August 8th 2018
Comment 11 Jim Raykowski 2018-08-22 21:32:14 UTC
(In reply to Buovjaga from comment #10)
> (In reply to Jim Raykowski from comment #9)
> > A patch for review is here:
> > https://gerrit.libreoffice.org/#/c/58712/
> 
> I confirm with this patch the Sidebar is expanded after cycling with F6 key.
> 
> Arch Linux 64-bit
> Version: 6.2.0.0.alpha0+
> Build ID: 8a2c7ee13c2045911fb289a8b3976ef395b557f8
> CPU threads: 8; OS: Linux 4.17; UI render: default; VCL: gtk3; 
> Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
> Built on August 8th 2018

Buovjaga thank you for testing.
Comment 12 Commit Notification 2018-08-29 14:37:25 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=17d8f6b0d78c11ac40a335917b3576f13d1e1b9d

tdf#102031 Expand collapsed deck when sidebar docking window gets focus

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.