Bug 102776 - Notebookbar: Activating it in one window wont fully activate it in another
Summary: Notebookbar: Activating it in one window wont fully activate it in another
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks: Notebookbar
  Show dependency treegraph
 
Reported: 2016-09-28 22:39 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-11-08 11:30 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-09-28 22:39:53 UTC
Steps:
1) Open two documents in writer in default toolbar layout
2) In one of the windows, switch to notebookbar
3) Now switch to the other window and the notebookbar will appear and menubar will disappear (likely thanks to bug 102063, as before that fix this didnt happen), but the toolbars will still be present

Version: 5.3.0.0.alpha0+
Build ID: 3d9231dd4945dcd6c3d53ba11152049d382b975f
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-09-28_02:17:20
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Commit Notification 2016-09-29 20:56:24 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=be68bf55c303ce8aaaa79578178e6ff9a5e18d18

tdf#102776 : toolbar mode changing in multiple windows

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Yousuf Philips (jay) (retired) 2016-10-05 18:02:34 UTC
Tested it out and the menubar was still present in the second window.

Version: 5.3.0.0.alpha0+
Build ID: f309531cfe1d6a1b6ea1306d45ed3e121145bc5f
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-10-04_03:52:18
Locale: en-US (en_US.UTF-8); Calc: group

Also hiding/showing the menubar wasnt insync between the two windows and then deactivating notebookbar mode restores the menubar, toolbars and sidebar, but doesnt hide the notebookbar in all or some windows. Should i file these as separate bugs?
Comment 3 Commit Notification 2016-10-06 21:12:35 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2796291bd84eeb71115f3d9fb3b8aec67c4f4214

tdf#102776 : fixed Notebookbar hiding

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2016-10-07 17:49:25 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b786fb2db9b555fd9882487f1f0375bd93f6e32

tdf#102776 : switching the menubar in all windows

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2016-11-08 08:52:22 UTC
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Comment 6 Yousuf Philips (jay) (retired) 2016-11-08 11:30:24 UTC
Confirmed.

Version: 5.3.0.0.alpha1+
Build ID: 11cab8aba359c655a75791ddbc0f2ffeae8ce206
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; VCL: gtk2; Layout Engine: new; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-11-06_23:07:09
Locale: en-US (en_US.UTF-8); Calc: group