Bug 103582 - Various table border styles set through toolbar control arent retained on reopen
Summary: Various table border styles set through toolbar control arent retained on reopen
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.6.7.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Tables Toolbar-Border-Controls
  Show dependency treegraph
 
Reported: 2016-10-29 23:55 UTC by mkflan
Modified: 2018-11-07 17:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Requested Screenshot (72.07 KB, image/png)
2016-11-17 17:32 UTC, mkflan
Details
Screenshot of table border after file has been pasted into another folder (120.83 KB, image/jpeg)
2016-11-17 20:57 UTC, mkflan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mkflan 2016-10-29 23:55:12 UTC
Table border changes from solid line to a different border style after copy/paste to a new folder. To recreate: 
create document
create table
apply border style - specifically the SOLID LINE border style that is eighth from the top (not counting "None")
 - this border style is a solid line
save the document
copy / paste the document into a new folder
open this NEW document
the table style is now a two-line style

RELATED:
The border-styles should be numbered. It is very difficult to understand which style is which. The visual representation of the table styles (after you click the button) has duplicates as well. Very confusing even without this bug.
Comment 1 Buovjaga 2016-11-15 20:31:21 UTC
The 8th from the top for me is not a solid line, but a two-line style. Can you show a screenshot of how it looks like in the selector?

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.3.3
Build ID: 5.2.3-1
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Comment 2 mkflan 2016-11-17 17:32:09 UTC
Created attachment 128820 [details]
Requested Screenshot

Request: "The 8th from the top for me is not a solid line, but a two-line style. Can you
show a screenshot of how it looks like in the selector?"

See screenshot - 8th from the top - NOT counting "none".
Comment 3 Buovjaga 2016-11-17 19:29:09 UTC
Ok, so this is about the difference between the toolbar button display and the dialog display. I confirm the problem.

Jay: I can't find an existing report, but I have a vivid memory of there being one for this. Somehow I think you were involved.

Wasn't in the meta bug either https://bugs.documentfoundation.org/showdependencytree.cgi?id=103100&hide_resolved=1
Comment 4 mkflan 2016-11-17 20:56:18 UTC
No no, I'm afraid it's not at all about that (although I DO think that the menu selection for border styles should numbered, as it is very confusing to remember what style is what - but that is a secondary issue).

This bug is about this: When you make a table, and set the border style of that table to number 8 (see above), then save that file, then copy/paste the file into a new folder, then open that NEW (result-of-a-paste) file, the border style in this new document will be visually different. It will be a two line border.

See screenshot. 

Thanks.
Comment 5 mkflan 2016-11-17 20:57:08 UTC
Created attachment 128831 [details]
Screenshot of table border after file has been pasted into another folder
Comment 6 Buovjaga 2016-11-17 21:05:13 UTC
(In reply to mkflan from comment #4)
> No no, I'm afraid it's not at all about that (although I DO think that the
> menu selection for border styles should numbered, as it is very confusing to
> remember what style is what - but that is a secondary issue).
> 
> This bug is about this: When you make a table, and set the border style of
> that table to number 8 (see above), then save that file, then copy/paste the
> file into a new folder, then open that NEW (result-of-a-paste) file, the
> border style in this new document will be visually different. It will be a
> two line border.
> 
> See screenshot. 
> 
> Thanks.

No, no, no :P The bug is about this: when you do all that border jazz *with the toolbar button*, then save, then reload, the border changes to the two line style. There is no need to copy & paste the file anywhere.
When you use the table properties dialog, the 8th style is double already in the selector and what you see is what you get - no need to reload.

I have a distinct memory of testing this before and I tried a hundred different ways of searching through our reports, but unfortunately nothing turned up.

Hoping Jay has experience with this.
Comment 7 mkflan 2016-11-17 21:23:12 UTC
Ah yes! I see what you're saying now. I didn't know about that table properties dialog. I was just using the thing at the bottom.

I still think the borders should be numbered, though (my 2 cents) - there's a lot of them.

Thanks!
Comment 8 Yousuf Philips (jay) (retired) 2016-11-22 15:00:43 UTC
(In reply to Buovjaga from comment #3)
> Jay: I can't find an existing report, but I have a vivid memory of there
> being one for this. Somehow I think you were involved.

Buovjaga: Dont remember anything like this and unable to reproduce it with master. The only bug the comes to mind relates to calc (bug 79787).

(In reply to mkflan from comment #7)
> I still think the borders should be numbered, though (my 2 cents) - there's
> a lot of them.

They should be labelled similar to how draw line styles are labelled (bug 101886).
Comment 9 Yousuf Philips (jay) (retired) 2016-11-22 15:20:21 UTC
If the issue is about which entries are shown in the toolbar versus the ones shown in the dialog, there isnt a problem there, as the toolbar one has to show more as you cant adjust the line width in the toolbar, but if you set the 1pt solid line entry 8 in the toolbar and then open the dialog, the same list will appear in the dialog.
Comment 10 Buovjaga 2016-11-22 15:28:38 UTC
(In reply to Yousuf Philips (jay) from comment #9)
> If the issue is about which entries are shown in the toolbar versus the ones
> shown in the dialog, there isnt a problem there, as the toolbar one has to
> show more as you cant adjust the line width in the toolbar, but if you set
> the 1pt solid line entry 8 in the toolbar and then open the dialog, the same
> list will appear in the dialog.

No, it's about entry 8 selected from the toolbar appearing as a solid line and changing to a double line after save and reload.
Comment 11 Yousuf Philips (jay) (retired) 2016-11-22 15:44:28 UTC
(In reply to Buovjaga from comment #10)
> No, it's about entry 8 selected from the toolbar appearing as a solid line
> and changing to a double line after save and reload.

Can you give the steps to repo this, as i couldnt repo it, and the summary needs to expressly mention this issue as now it isnt clear.
Comment 12 Buovjaga 2016-11-22 16:26:10 UTC
(In reply to Yousuf Philips (jay) from comment #11)
> (In reply to Buovjaga from comment #10)
> > No, it's about entry 8 selected from the toolbar appearing as a solid line
> > and changing to a double line after save and reload.
> 
> Can you give the steps to repo this, as i couldnt repo it, and the summary
> needs to expressly mention this issue as now it isnt clear.

I'll quote the description modifying it a bit:

1. create document
2. create table and select all of it
3. apply border style using the toolbar button - specifically the SOLID LINE border style that is eighth from the top (not counting "None")
 - this border style is a solid line
4. save the document
5. reload it
the table style is now a two-line style
Comment 13 Yousuf Philips (jay) (retired) 2016-11-23 14:51:18 UTC
So this issue happens to the following toolbar control entries

1) entry 5: 1.00pt dialog style 9 which reopens as 1.55 pt dialog style 7
2) entry 7: 1.00pt dialog style 11 which reopens as 2.35 pt dialog style 7
3) entry 8: 1.00pt dialog style 12 which reopens as 1.50 pt dialog style 7
4) entry 10: 1.00pt dialog style 14 which reopens as 2.35 pt dialog style 7

LO 3.5 has a different set of styles in the border style toolbar control.
Comment 14 QA Administrators 2018-11-06 03:56:13 UTC Comment hidden (obsolete)
Comment 15 Dieter Praas 2018-11-07 17:40:41 UTC
I still can reproduce it with

Version: 6.2.0.0.alpha1+ (x64)
Build ID: 8274c4c62df5b937b3f0bec9e1eeca85f3b219d4
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-22_01:47:50
Locale: en-US (de_DE); Calc: CL