Bug 101886 - Border line style control not a11y accessible
Summary: Border line style control not a11y accessible
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:24.2.0
Keywords: accessibility
: 95247 116621 (view as bug list)
Depends on:
Blocks: a11y, Accessibility Borders-Tab
  Show dependency treegraph
 
Reported: 2016-09-04 02:31 UTC by Yousuf Philips (jay) (retired)
Modified: 2023-08-22 10:57 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-09-04 02:31:43 UTC
The border line style control (svtlo-LineListBox) found in the border tab in most dialogs isnt accessible with a screen reader and labels need to be added to each entry similar to line properties styles control (svxlo-LineLB).
Comment 1 Yousuf Philips (jay) (retired) 2016-09-28 19:15:31 UTC
@am_dxer, @stuart: Can either of you confirm this?
Comment 2 V Stuart Foote 2016-09-28 19:34:14 UTC
On Windows 8.1 Enterprise 64-bit en-US with NVDA 2016.3

The Line arrangment Default & User defined widgets sound but have no specific labeling--although tooltips are provided, they don't sound, ie "Set no borders", "Set all four borders", "Set left and right borders", "Set top and bottom borders", and "Set left border only" -- and what does sound does not correspond to the Borders tab.

The Line: Style only sound the initial entry "- none -, one of eleven ", the other ten only are sounded as "List item # of eleven, level one" with no tooltip or label describing the line style apparent.
Comment 3 V Stuart Foote 2016-09-28 19:52:12 UTC
That was in the Paragraph dialog -> Borders tab

on Version: 5.2.2.2 (x64)
Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad
CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; 
Locale: en-US (en_US); Calc: group

Version: 5.3.0.0.alpha0+
Build ID: 3d9231dd4945dcd6c3d53ba11152049d382b975f
CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-09-28_02:14:14
Locale: en-US (en_US); Calc: group

And on recent master have additional issue with the Line style drop list.
Still eleven items, but item one (- none -), and item two both sound as item three of eleven. No labels, no tooltips. 

And with the 5.2.2 builds as well as master--the whole area on the Borders tab-- Line Arrangement  (presets/user-defined) & Line (Style, Width, Color)--is very hard to follow with screen readers.
Comment 4 am_dxer 2016-09-28 22:53:53 UTC
I can also confirm the bug with Libreoffice Master and NVDA 2016.3 in Windows 7.
Comment 5 Quentin Christensen 2017-10-24 05:09:07 UTC
This issue for border line style is still present in LibreOffice 5.4.2.2 (x64) on Windows 10, tested with NVDA 2017.3.  Re comment 2 about the border arrangements "Set all four borders", "Set left and right borders" etc, these seem to read correctly for me.

Also looks the same as bug #95247 https://bugs.documentfoundation.org/show_bug.cgi?id=95247
Comment 6 Telesto 2018-03-25 15:04:10 UTC
*** Bug 116621 has been marked as a duplicate of this bug. ***
Comment 7 Telesto 2018-03-25 15:05:48 UTC
Quote: bug 116621 comment 1

Confirmed on Windows build
Version: 6.0.2.1 (x64)
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL

The listbox of border styles do not receive tool tip/descriptions.

https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/borderpage.ui#175
https://opengrok.libreoffice.org/xref/core/svx/source/dialog/dlgctrl.cxx#1083

With local help installed and extended tips checked enabled. The widgets (Calc & Writer) take Paragraph help articles:

https://opengrok.libreoffice.org/xref/help/source/text/shared/01/05030500.xhp#54
https://opengrok.libreoffice.org/xref/help/source/text/shared/01/05030500.xhp#34

But the LB in the Borders tab of the Paragraph dialog do not have any annotation describing the line (or its bitmap) exposed to the UI
Comment 8 V Stuart Foote 2018-03-25 16:09:59 UTC
*** Bug 95247 has been marked as a duplicate of this bug. ***
Comment 9 QA Administrators 2019-03-27 03:41:04 UTC Comment hidden (obsolete)
Comment 10 V Stuart Foote 2019-03-27 12:52:18 UTC
Can no longer repeat STR of comment 2 comment 3, the Paragrapn -> Borders: Line Arrangement widgets are accessible and sound outions.

However the Line style droplist on the same panel remains in accessible. It responds to screen scraping with mouse, but not with keyboard navigation, no accessible events are emitted for the droplist elements.

===
Testing Windows 10 Home 64-bit en-US with NVDA 2019.1 and
Version: 6.3.0.0.alpha0+ (x64)
Build ID: 4ca9db953d59d93ce8e3a54a36d23ed52b9c62a9
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-26_03:34:16
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 11 Prestonawrence 2020-04-14 07:58:53 UTC Comment hidden (spam)
Comment 12 Doreen Roy 2020-04-24 07:24:59 UTC Comment hidden (spam)
Comment 13 Olivia Francis 2020-10-05 15:31:04 UTC Comment hidden (spam)
Comment 14 Dawn Bailey 2021-03-30 13:18:44 UTC Comment hidden (spam)
Comment 15 Michael Weghorn 2021-10-14 06:31:57 UTC
Corresponding issue in NVDA issue tracker: https://github.com/nvaccess/nvda/issues/7701
Comment 16 Michael Weghorn 2023-08-22 08:40:33 UTC
(In reply to V Stuart Foote from comment #10)
> However the Line style droplist on the same panel remains in accessible. It
> responds to screen scraping with mouse, but not with keyboard navigation, no
> accessible events are emitted for the droplist elements.

This works for me now with the for tdf#141101 and tdf#156561 in place.

The remaining thing is to properly restore focus when closing the popup again. Pending Gerrit change:
https://gerrit.libreoffice.org/c/core/+/155891
Comment 17 Commit Notification 2023-08-22 10:49:05 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f075fa01cb4f74185f13eb0a8d7f84cf1f47af49

tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.