Bug 103607 - Don't ask user to "finish" document recovery when all document(s) have successfully been recovered
Summary: Don't ask user to "finish" document recovery when all document(s) have succes...
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
Hardware: All All
: low enhancement
Assignee: Not Assigned
: 153168 (view as bug list)
Depends on:
Blocks: Dialog-Msgbox Document-Recovery
  Show dependency treegraph
Reported: 2016-10-31 18:14 UTC by steve
Modified: 2023-08-09 10:51 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description steve 2016-10-31 18:14:15 UTC
The recovery dialog is a bit convoluted. Users should not have to "finish" (what does that even mean?) the recovery dialog in cases where only a single file is recovered. see other fields for details

Steps to Reproduce:
1. user is asked to Recover or Cancle
2. select "Recover"

Actual Results:  
disclaimer: this concerns only the case where a single file has been recovered.

user is presented with dialog shown in screenshot. dialog suggests that one file was successfully recovered.

user is super happy. but...

Expected Results:
... why does the user have to click on "finish" in order to actually proceed? what value is gained in that step?

I suggest the following more sane workflow:

1. if the file is successfully recovered → open the damn file (: done
2. if the file cannot be recovered, show a dialog and explain why and what happened.

Makes sense?

Reproducible: Always

User Profile Reset: No

Additional Info:

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:49.0) Gecko/20100101 Firefox/49.0
Comment 1 Buovjaga 2016-10-31 19:43:02 UTC
Seems like a good idea -> NEW
Comment 2 Eyal Rozenberg 2023-05-11 20:04:45 UTC
This looks like a relatively easy issue to work on for a newbie developer. Has no effect anywhere other than in the dialog, and one doesn't even have to introduce new functionality, just play with dialog logic. Adding needDevEval
Comment 3 Stéphane Guillou (stragu) 2023-05-28 23:19:30 UTC
*** Bug 153168 has been marked as a duplicate of this bug. ***
Comment 4 Stéphane Guillou (stragu) 2023-05-28 23:26:51 UTC
Duplicate bug 153168 argues for entire removal of that step.
The use of it is that it reports success or failure of recovery of document, but as the OP argues, a message could be shown _only_ to report on failures if they exist.

Adding Hossein for the NeedsDevEval keyword.
Comment 5 Stéphane Guillou (stragu) 2023-08-09 10:03:34 UTC
This issue should be fixed by Justin Luth for 24.2:

tdf#145606 autorecover: skip "Finish" button if all recovered OK.

Justin, I'll let you confirm that and mark as "resolved - fixed" :)