Bug 103693 - Ugly presentation of comments when exporting as PDF
Summary: Ugly presentation of comments when exporting as PDF
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.2.2.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2016-11-04 00:08 UTC by haim kilov
Modified: 2020-09-14 12:02 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
The original file with comments (9.15 KB, application/vnd.oasis.opendocument.text)
2016-11-04 00:10 UTC, haim kilov
Details
The ugly comments -- using "export as PDF" (31.33 KB, application/pdf)
2016-11-04 00:12 UTC, haim kilov
Details
The correctly presented comments -- using "print" as PDF (31.80 KB, application/pdf)
2016-11-04 00:14 UTC, haim kilov
Details
Result of PDF-export (20.36 KB, application/pdf)
2016-11-07 07:38 UTC, Dieter
Details
Document after opening the rectangles. (20.36 KB, application/pdf)
2016-11-07 07:40 UTC, Dieter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description haim kilov 2016-11-04 00:08:19 UTC
Description:
When a file with comments is exported as PDF the comments are correctly presented in margins BUT the places in the text commented upon are covered with small rectangles with lines inside. These ugly rectangles disappear when the same file is printed as PDF. 

Steps to Reproduce:
1. Create a file with three lines (see the file "comments.odt)
2. Create two comments, in the second and third line of the file.
3. Export the file as PDF. The result: "comments.pdf" -- the "ugly" file.
4. Print the same file using "save as PDF". The result: "correct comments.pdf".

Actual Results:  
See the attachment.

Expected Results:
The "comments.pdf" file must be the same as the "correct comments.pdf"


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:48.0) Gecko/20100101 Firefox/48.0
Comment 1 haim kilov 2016-11-04 00:10:35 UTC
Created attachment 128479 [details]
The original file with comments
Comment 2 haim kilov 2016-11-04 00:12:36 UTC
Created attachment 128481 [details]
The ugly comments -- using "export as PDF"
Comment 3 haim kilov 2016-11-04 00:14:03 UTC
Created attachment 128482 [details]
The correctly presented comments -- using "print" as PDF
Comment 4 Dieter 2016-11-07 07:38:51 UTC
Created attachment 128538 [details]
Result of PDF-export

I can confirm it with LO 5.2.3.3. Personally I think it's not a bug, because the rectangles represents the comments an you can open the comments in the margin by clicking on them (see attachemnts 1 and 2.) But I agree, that this ist not the result somebody expects, when he uses the PDF-Export. And it causes misunderstandings. So I suggest to rename this bug (for example "PDF Export: Allow printing comments in margin") and see it es an enhancement.
Comment 5 Dieter 2016-11-07 07:40:11 UTC
Created attachment 128539 [details]
Document after opening the rectangles.
Comment 6 haim kilov 2016-11-07 16:28:13 UTC
I beg to disagree with Dieter. While indeed "the rectangles represents the comments an you can open the comments in the margin by clicking on them", the comments are _already visible_ in margins when you set this in preferences. Therefore there is no need to show these rectangles. Note that "print as PDF" (unlike "export as PDF") works correctly.
Comment 7 Dieter 2016-11-08 16:40:05 UTC
The rectangles only appear if you enable "export comments" in the PDF-export-options. If you disable this option and enable "print comments in margin" in the preferences, you get a sufficient result. So I think the "export comments" option in the PDF-export causes some confusion and might be renamed.
Comment 8 haim kilov 2016-11-09 04:09:33 UTC
"So I think the "export comments" option in the PDF-export causes some confusion and might be renamed."

I completely agree. This is an example of feature interaction...

I think that enabled "print comments in margin" in preferences takes care of the need to correctly export comments in PDF; and that the rectangles in this case are not needed at all.

Thus, if "print comments in margin" is enabled in preferences there is no need even to look at the corresponding option in the PDF export options: it has already been properly set. Therefore I think that in this case such an option should not be available.
Comment 9 Buovjaga 2016-11-23 19:51:25 UTC
Design team: what do you think of all this?
Comment 10 Heiko Tietze 2016-11-27 12:22:31 UTC
(In reply to dieterp from comment #7)
> The rectangles only appear if you enable "export comments" in the
> PDF-export-options.

What is the use-case for these rectangles?

Why is the result of export and print different?
(Doesn't happen to me.)

(In reply to haim kilov from comment #8)
> "So I think the "export comments" option in the PDF-export causes some
> confusion and might be renamed."

The user expects an on/off option from "Export comments" and not any duplication to tools > options > writer > print. Solution 1 is to neither show comments nor the rectangle when this option is unchecked, and otherwise a result that corresponds to the print settings (margins, bottom...). That also means to disable the checkbox when None is chosen in tools > options.
Please always add tooltips that explain the features. In particular, when the checkbox is disabled it is crucial to inform the user why she never is able to export comments since we default to None. 

Alternatively we show all these options at the print dialog, for instance in a dropdown. And None would be the replacement for the current default of the unchecked "[ ] Export comments". The ordinary print dialog goes this way and doubles what has been entered at tools>options, which makes no sense to me, btw. I suggest to remove the options there.
Comment 11 Dieter 2020-06-06 15:24:47 UTC
(In reply to Heiko Tietze from comment #10)
> What is the use-case for these rectangles?

Double-click opens the comments. You can also edit them within PDF-document. Every solution should include this possibility.


Still them same in

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 41d8b41767032681a9897b7551f011d450e3725e
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
Comment 12 Timur 2020-09-14 12:02:05 UTC
I don't know why this bug was confirmed. 
attachment 128481 [details] The ugly comments -- using "export as PDF" is the same as  attachment 128482 [details] The correctly presented comments -- using "print" as PDF

Dieter's  attachment 128538 [details] Result of PDF-export is not the result of LO but of PDF viewer, all render comments differently.

I'll close. If you disagree, please explain objectively, test LO 7.1+ master and different PDF viewers. 

Note: to have exports options in PDF we have bug 77650.