Bug 103821 - hover annotations incorrectly redrawn
Summary: hover annotations incorrectly redrawn
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2016-11-10 06:59 UTC by Zerstreuter.Forum
Modified: 2019-05-15 09:31 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
bug example (247.25 KB, image/jpeg)
2016-11-10 06:59 UTC, Zerstreuter.Forum
Details
all sensitiv data can not removed because inside of tracking information (122.33 KB, application/vnd.oasis.opendocument.spreadsheet)
2016-11-14 09:24 UTC, Zerstreuter.Forum
Details
Leftover lines (107.54 KB, image/png)
2017-02-09 21:06 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zerstreuter.Forum 2016-11-10 06:59:12 UTC
Created attachment 128635 [details]
bug example

hi there ,

today i found a bug in LO 5.2.3.3.
Open a Calc File with change tracking annotations and hover over changed fields.
The changing are shown but table is not correctly redrawed by leaving the field.
Comment 1 Xisco Faulí 2016-11-10 11:19:27 UTC Comment hidden (obsolete)
Comment 2 Aron Budea 2016-11-13 06:01:05 UTC
Seems similar to bug 98040.
Comment 3 Zerstreuter.Forum 2016-11-14 09:24:45 UTC
Created attachment 128740 [details]
all sensitiv data can not removed because inside of tracking information

removing sensitiv data changes the redraw effect too .. 
i wanna send you the original file which is used by serveral versions of oo and lo but it contains sensitiv data.
Comment 4 Xisco Faulí 2016-11-14 10:38:57 UTC
Confirmed in

- Version: 5.3.0.0.alpha1+
Build ID: 8dc495c93239739629683bb29e4110f5c57c94f0
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

- Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

but not in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 6 raal 2016-11-20 10:05:43 UTC
This seems to have begun at the below commit.
Adding Cc: to Michael Meeks; Could you possibly take a look at this one?
Thanks

 dadd589cd0633db4e126f0a6ab2907ffeef34563 is the first bad commit
commit dadd589cd0633db4e126f0a6ab2907ffeef34563
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Fri Sep 18 10:13:10 2015 +0800

    source-hash-bb3f2900a867fdcb6df916fff58199b4ce94dd05
    
    Bibisect: This commit covers the following source commit(s) which failed to build
    34e79c19babc0e6cc281025b40635b91dca444f3
    542ad7f1c5ac7794c42248ac13e9b33f84888490
    a108f4b14e119736c6a24f00cbfe87acb71e1e4a
    f828e91d1b2f0491e3d1c724ddd12f1b9177f466
    97b583a7bfb5dc9000290c3bdc8df8751a97d65d
    355c30789e311aa13d7421ce653dc80a9030c2e2
    
    commit bb3f2900a867fdcb6df916fff58199b4ce94dd05
    Author:     Michael Meeks <michael.meeks@suse.com>
    AuthorDate: Mon Dec 17 19:55:32 2012 +0000
    Commit:     Michael Meeks <michael.meeks@suse.com>
    CommitDate: Mon Dec 17 19:57:54 2012 +0000
    
        fdo#58399 - revert attempts to untangle and accelerate this mess.
    
        Reverts commits:
            76350361f386b78e1bc9edb75af89e7ff3afe356
            67f899e1d2db0dccde4b9587a52b7157fe1fb0be
            1d77d4eada214e14938336070b248c18705939ff
            1d16f59023b1b19d01ca69b8c9735be6d3baf5d9
    
        The bug has a great series of linked bugs and stack-traces; the
        weakref / mixed tools & UNO lifecycle here is simply hideous.

bibisect-41max$ git bisect log
# bad: [e8a1c54dfe8a4bc03d2ce9cb9906bf06d9affa7d] source-hash-863d38fbfa4fb4861e476828c46410602100919e
# good: [8cb222c656c0444f66cfa5a35ed204169bb91e09] source-hash-efca6f15609322f62a35619619a6d5fe5c9bd5a4
git bisect start 'latest' 'oldest'
# bad: [789cb134f3000918fe031ffce19c57e505cab328] source-hash-8669ad398a2971706ce22b6e5fe316991977452a
git bisect bad 789cb134f3000918fe031ffce19c57e505cab328
# bad: [995de0a4aa5e3a57df5ed558426ad9359bdb63fa] source-hash-32e3ede97ec6bad1b3c19545709b54eff29eafc6
git bisect bad 995de0a4aa5e3a57df5ed558426ad9359bdb63fa
# bad: [17f1d971702a579a4e7f379b4c425a8cf71eed7b] source-hash-f79da8fa288fbbe4742ad416844aad53ee8d00f5
git bisect bad 17f1d971702a579a4e7f379b4c425a8cf71eed7b
# bad: [b7eac93fad1591bf03f90a13d65bc68230839db0] source-hash-8e5fe8dc9229043d18f581f2c56d58daff2bf87a
git bisect bad b7eac93fad1591bf03f90a13d65bc68230839db0
# good: [19911bd354f4aa66a47c4d3dc9122151f52cc931] source-hash-2ac26dc83f2ce9c2b41f9d9b33dd4c0cdd8d1272
git bisect good 19911bd354f4aa66a47c4d3dc9122151f52cc931
# good: [b89941a8a1b3568148f84e5f637ff44456516485] source-hash-32e7b29f51c4f6bce08a23e454ec47b83849c9df
git bisect good b89941a8a1b3568148f84e5f637ff44456516485
# good: [4071e88b0314c8455d6d76826825b5f53dcf2cab] source-hash-bba34cfa6df4f8b7ca181d517dca675c0dc23b81
git bisect good 4071e88b0314c8455d6d76826825b5f53dcf2cab
# bad: [62d8af7b8a7bed1757ff531516b878e935f348dd] source-hash-3d969a60852d505cfa02a6b3410d4461718138ba
git bisect bad 62d8af7b8a7bed1757ff531516b878e935f348dd
# good: [0881992be383e6468f7a5822c470446aa7d44031] source-hash-de1cbc17952a7e5838c0ded2ed3042171cb997c4
git bisect good 0881992be383e6468f7a5822c470446aa7d44031
# good: [97c8bf04079ca9e314981f1c66ab93d1ce78f383] source-hash-77d3777c8934171a9557a96872d020cf12443fb9
git bisect good 97c8bf04079ca9e314981f1c66ab93d1ce78f383
# bad: [dadd589cd0633db4e126f0a6ab2907ffeef34563] source-hash-bb3f2900a867fdcb6df916fff58199b4ce94dd05
git bisect bad dadd589cd0633db4e126f0a6ab2907ffeef34563
# good: [f339fee78271d578ee724d37580fa7d644194c65] source-hash-0d777f33a1d818a7fd27d755e54db64823f46636
git bisect good f339fee78271d578ee724d37580fa7d644194c65
# good: [c01bd3a151d2194f96ad68906456155012476523] source-hash-f55f86e016e8d1b509be1e7ba59919301dc17d67
git bisect good c01bd3a151d2194f96ad68906456155012476523
# first bad commit: [dadd589cd0633db4e126f0a6ab2907ffeef34563] source-hash-bb3f2900a867fdcb6df916fff58199b4ce94dd05
Comment 7 Michael Meeks 2016-11-21 09:29:28 UTC
Hmm - that is a revert of a commit that broke a lot of other things; it is curious that it made this work - but ... I'd want to continue bisecting manually to older revisions there before the commit that we revert was introduced ... Thanks =)
Comment 8 Zerstreuter.Forum 2017-02-09 13:33:11 UTC
Hi, I wanted to ask if you already have a solution approach?
Comment 9 Aron Budea 2017-02-09 21:06:59 UTC
Created attachment 131053 [details]
Leftover lines

Version field should be for the oldest version the bug was observed with, please don't change it to a new version.

Some analysis. Bibisect repo used was bibisect-41max.

First commit in repo is from 2012-12-06 09:09:38:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=efca6f15609322f62a35619619a6d5fe5c9bd5a4
Looks good at this point.

Michael's commit is from 2012-12-17 19:57:54:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=bb3f2900a867fdcb6df916fff58199b4ce94dd05
Starts showing the bug.
Reverted commits are from between 2012-10-23 12:49:55 and 2012-12-03 14:41:04, and not covered by repo bibisect-41max.

Note that this commit was also reverted, by David Tardon on 2012-12-19 07:03:35:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c3fed9f4ea354427c205bd407fcfa3d04093ba50
No change, bug is there before this commit and after this commit.

Note that in my case the bug is a single lingering line from the comment once you move on to the next cell (see attachment).
The first major version I could reproduce the bug with was 4.0.0.3. The commit was backported to 4.0.

It might be interesting to check with bibisect repo 43all if the bug ever occurred at some point before/between 2012-10-23 12:49:55 and 2012-12-03 14:41:04.
Comment 10 QA Administrators 2018-02-10 03:33:11 UTC Comment hidden (obsolete)
Comment 11 Xisco Faulí 2018-03-01 12:33:27 UTC
I can reproduce it in

Version: 6.0.0.0.alpha1+
Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

but no longer in

Version: 6.1.0.0.alpha0+
Build ID: e2cb154195fdc2ffccdb6f5e87cae8b29640b3eb
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

Closing as RESOLVED WORKSFORME