Bug 104027 - FILEOPEN: DOC: incorrect page break added to page 2
Summary: FILEOPEN: DOC: incorrect page break added to page 2
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, filter:doc, regression
: 104616 116427 (view as bug list)
Depends on:
Blocks: Writer-Page-Break DOC-Paragraph Regressions-705a8c22
  Show dependency treegraph
Reported: 2016-11-19 11:07 UTC by Xisco Faulí
Modified: 2020-04-18 09:04 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

sample (165.00 KB, application/msword)
2016-11-19 11:07 UTC, Xisco Faulí
sample2 (194.50 KB, application/msword)
2016-11-19 11:51 UTC, Xisco Faulí
sample3 (64.00 KB, application/msword)
2016-12-01 22:46 UTC, Xisco Faulí

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2016-11-19 11:07:56 UTC
Created attachment 128860 [details]

1. Open the attached file
2. Check second page 

Observed behaviour: content from second page is moved to the next page

Reproduced in 

Build ID: 757a60d01dd152aadab2ba3c8224252481ce8a88
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

but not in

Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e
Comment 1 Xisco Faulí 2016-11-19 11:10:59 UTC
Regression introduced by:

author	Caolán McNamara <caolanm@redhat.com>	2014-09-23 19:35:50 (GMT)
committer	Caolán McNamara <caolanm@redhat.com>	2014-09-24 09:04:48 (GMT)
commit	705a8c226aee3e68db492083b7cf8b704335328b (patch)
tree	c701b3a13f48f6d5a4c226bcf4f67e1e91a41049
parent	6332c643016ce4c4d254c8429a5eceae6664bf5c (diff)

WW8PLCFMan::AdjustEnds deeply flawed concept wrt change tracking
The whole idea of clipping the char attributes to before the cr that word uses
as the end of para marker is flawed from especially the perspective of
redlining which is a char property in word.

If the redline encompasses the newline in order to state that it is deleted,
then if the prop is clipped to before that newline then the end-of-para doesn't
get marked as deleted

For now just remove the character attributes clipping from here to be as
conservative as possible.

Hopefully the ordering of processing start pap before start chp and end chp
before end pap and the other million improvements in the parser that came about
after AdjustEnds was created avoids whatever problems were trying to be worked
around here.

Adding Cc: to Caolán McNamara
Comment 2 Xisco Faulí 2016-11-19 11:51:17 UTC
Created attachment 128866 [details]

Another document affected by the same commit
Comment 3 Xisco Faulí 2016-11-19 13:55:48 UTC
This document attachment 44627 [details] is slightly affected by the same commit too
Comment 4 Xisco Faulí 2016-12-01 22:46:20 UTC
Created attachment 129213 [details]

another document affected by the same commit
Comment 5 Xisco Faulí 2016-12-16 15:46:05 UTC
*** Bug 104616 has been marked as a duplicate of this bug. ***
Comment 6 Xisco Faulí 2017-09-05 22:33:18 UTC
*** Bug 111802 has been marked as a duplicate of this bug. ***
Comment 7 Xisco Faulí 2018-03-20 00:50:59 UTC
*** Bug 116427 has been marked as a duplicate of this bug. ***