Description: Writer hangs on opening file with images Steps to Reproduce: 1.Try to open attachment 123770 [details] Actual Results: File won't open Expected Results: File should be opening Reproducible: Always User Profile Reset: No Additional Info: Found in: Version: 5.4.0.0.alpha0+ Build ID: 4130c8def811d1dcc87eacaa8ae48ba02738a790 CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-11-29_01:03:18 Locale: nl-NL (nl_NL); Calc: CL but not with: Versie: 4.4.6.3 Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d Locale: nl_NL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Unconfirmed with v5.1.6.2 under ubuntu 16.04 x64. Confirmed with v5.2.3.3 under ubuntu 16.04 x64.
This seems to have begun at the below commit. Adding Cc: to Miklos Vajna ; Could you possibly take a look at this one? Thanks author Miklos Vajna <vmiklos@collabora.co.uk> 2016-08-30 07:14:47 (GMT) committer Miklos Vajna <vmiklos@collabora.co.uk> 2016-08-30 08:40:30 (GMT) commit 1d1748d143ab4270a2ca1b5117852b1b1bb4c526 (patch) tree ed1939265de131d1338d2d26657459a0aa2825e6 parent 11cc9bdc21be241f2feb3ab4822d9d365dba4f96 (diff) Related: tdf#44986 DOCX import: handle w:gridAfter by faking cells This is similar to the w:gridBefore handling code introduced in commit cf33af732ed0d3d553bb74636e3b14c55d44c153 (handle w:gridBefore by faking cells (fdo#38414), 2014-04-23), except that the fake cells here are inserted after the real ones, not before. git bisect log # bad: [b356e15c1f14e3d0f0bb73662c878d14fc8aa992] source ada8a2123ea655142be74a11c23e042a0109d5f8 # good: [33e60eae04c889baf52713a73dc9944015408914] source 5b168b3fa568e48e795234dc5fa454bf24c9805e git bisect start 'origin/master' 'oldest' # good: [78a4f08cf26d3f800710c509a99b1f4ad8a4e783] source db231633af4667e24281e0be69ab63ad3081fdc3 git bisect good 78a4f08cf26d3f800710c509a99b1f4ad8a4e783 # bad: [d9f68fca812338acc473efb5053add57fbdf6415] source 8fab6ab36589d0dcd75d45feab43a0b06b7f2a3e git bisect bad d9f68fca812338acc473efb5053add57fbdf6415 # bad: [cc14d57c7f7f123988eda3cbd4820d0013eed067] source b9a27d5856f60688456762bfcc29c38670009254 git bisect bad cc14d57c7f7f123988eda3cbd4820d0013eed067 # bad: [58c47191626fd44f4ac98958a0491977a35a2e30] source ac192a7ef116e6453fee7872b558ff957e377c50 git bisect bad 58c47191626fd44f4ac98958a0491977a35a2e30 # good: [502f7d755ae04e716c9a8865bef7597cc3a371c1] source 2c10714426cc813c36aa82e4870b7b51c5c03050 git bisect good 502f7d755ae04e716c9a8865bef7597cc3a371c1 # bad: [f9c5345bff70e39098182c14b52eb48a76d1cce0] source 2b8b8740f211a649a358fbe2406cae12e9621a77 git bisect bad f9c5345bff70e39098182c14b52eb48a76d1cce0 # good: [9d21f5bba803f7bbf5953897919d70b79fdd4d0f] source 11cc9bdc21be241f2feb3ab4822d9d365dba4f96 git bisect good 9d21f5bba803f7bbf5953897919d70b79fdd4d0f # bad: [c2373d2378af072d842d3a7e3f96159ad46a1fcb] source d488a646b5a703aef34396041c997902dcbbf98d git bisect bad c2373d2378af072d842d3a7e3f96159ad46a1fcb # bad: [df60cde7659c7a40fbfaa7bb45cbe912316b0cff] source 6f821ca4a1c07e79d8cdbfd84c08445ae4c5186a git bisect bad df60cde7659c7a40fbfaa7bb45cbe912316b0cff # bad: [23c8a6d7b1603dfd0bece15f76e179dd337e34e7] source fa15256e3d12aab1eaf5991c016fc10dea286675 git bisect bad 23c8a6d7b1603dfd0bece15f76e179dd337e34e7 # bad: [dc16d5ae9fb73c228373deae263bd60ecaca3712] source 5758f8a7f8e2e9819ef09f4e1fe38921b247dc65 git bisect bad dc16d5ae9fb73c228373deae263bd60ecaca3712 # bad: [cad46d56058194701502c83cd550c5d6ad9bbb20] source 9accbfa0a52433cf03fe186fc69334d387981eb9 git bisect bad cad46d56058194701502c83cd550c5d6ad9bbb20 # bad: [73c8b8ef61dc6bfb884ae43f013b509afeda9190] source 1d1748d143ab4270a2ca1b5117852b1b1bb4c526 git bisect bad 73c8b8ef61dc6bfb884ae43f013b509afeda9190 # first bad commit: [73c8b8ef61dc6bfb884ae43f013b509afeda9190] source 1d1748d143ab4270a2ca1b5117852b1b1bb4c526
Created attachment 129487 [details] a backtrace I confirmed on my debug dev build: Version: 5.4.0.0.alpha0+ Build ID: f35d29c8388744be1f95ec4acfca12eec706911a CPU Threads: 2; OS Version: Linux 4.9; UI Render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group
attachment 123770 [details] from bug 98823 is also affected by the same commit.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
still repro in Version: 6.2.0.0.alpha1+ Build ID: a20a2d7e0d28658f2d9089da076961a599833a28 CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-11-12_22:51:20 Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded
I've just checked in gdb what is backtrace of the hang, and this is a layout loop. So the above commit just uncovered an existing layout problem: you could construct an ODF file which creates the same document model and same hang even before my commit. Sure, this is a bug, and it's a good thing to fix it, but this is more an implementation error than a regression.
*** Bug 129274 has been marked as a duplicate of this bug. ***
@Julien, any chance we could have a perf chart here ?
(In reply to Xisco Faulí from comment #9) > @Julien, any chance we could have a perf chart here ? No pb! I'll do it when get back home
Created attachment 156439 [details] Flamegraph Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today.
(In reply to Julien Nabet from comment #11) > Created attachment 156439 [details] > Flamegraph > > Here's a Flamegraph retrieved on pc Debian x86-64 with master sources > updated today. @Noel, I thought you might be interested in this issue...
Still reproducible in Version: 7.0.0.0.alpha0+ Build ID: fd1cd5522283f279a01d6d673f676a1346e9358b CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
Still reproducible in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: cbcec4425e04e3614a2025b49fdc221216ac51d3 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
still repro in Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: b6266207b55a7633dc82b02142215757512adfb7 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded
Seems to open fine in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d993327eab0a2c9c8820c6528075b01de68b0ec6 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded bibisected in linux-7.4 to: https://git.libreoffice.org/core/+/9300c36361426e724b28c25a7729543b316b258b author László Németh <nemeth@numbertext.org> Fri Nov 18 14:11:30 2022 +0100 committer László Németh <nemeth@numbertext.org> Tue Nov 22 08:23:36 2022 +0100 tdf#152106 sw layout: fix freezing of multicol sections with flys Now opening the file does not freeze. But the layout is falling apart compared to the look at attachment 123774 [details] from bug 98823 Not marking as duplicate of a much newer bug. Thanks László for fixing this!
(In reply to Gabor Kelemen (allotropia) from comment #16) > Not marking as duplicate of a much newer bug. Thanks László for fixing this! @Gábor: thanks for the nice feedback!