In order to provide easier modifications of image color values, we should replace various spinboxes with preset drop down listboxes and then adjust panel contents to have a label's left column and a control's right column. So the new panel content will be :- Color Mode: image mode drop down Transparency: transparency drop down Correction: brightness and contrast drop down RGB Mode: red, green and blue drop down The gamma spinbox wouldnt be available in the sidebar, but would be available in the image dialog (bug 103272).
@Jay, * Agree that dropping the spinboxes from the Image content panel is correct. But, from where would we be picking up the "Correction" controls? And for those it seems a slider for "brightness" and for "contrast" would be the more typical control. And maybe then the "Gamma" control might also go onto a slider in the Image content panel.
(In reply to V Stuart Foote from comment #1) > But, from where would we be picking up the "Correction" controls? "Correction" is the label and the control would be a preset drop down list various brightness & contrast values like 'Default', '-10% Brightness', '-10% Contrast', '-10% Brightness & Contrast', '+10% Brightness', '+10% Contrast', '+10% Brightness & Contrast', ... > And maybe then the "Gamma" control might also go onto a slider in the Image content panel. If it is deemed important to keep this in the content panel, which i dont think it is based on possible usage, then a preset drop down would be useful to use rather than a slider because of space.
Sounds like an abuse of dropdowns that make sense for a fix set of options. The spin edits are controls for numerical values typically within a defined range. Similarly the slider is a nice control for this type of data. Dropdowns are slow, at least slower compared to spin edits and sliders, since you have to open the dropdown and select the right item. And in case of larger lists the dropdown has more drawbacks. Would be good to have a mockup to talk about your idea.
Created attachment 129464 [details] image content panel before and after (In reply to Heiko Tietze from comment #3) > Sounds like an abuse of dropdowns that make sense for a fix set of options. > The spin edits are controls for numerical values typically within a defined > range. Similarly the slider is a nice control for this type of data. > > Dropdowns are slow, at least slower compared to spin edits and sliders, > since you have to open the dropdown and select the right item. And in case > of larger lists the dropdown has more drawbacks. Spin edits arent simple controls and combining it with a slider doesnt make it any simpler to the basic user (Benjamin) who would like to set a value but doesnt know how much of a value is useful to being set, which is where presets come in (e.g. a drop down with presets to set the above paragraph spacing in the paragraph content panel). Also dropdown presets will always be faster than spin edits and sliders, especially when the drop down adjusts multiple spin edit values at the same time (e.g. the drop down with presets to set the wrap spacing in the wrap content panel. In general, spinboxes arent good for the sidebar (especially the size problem with gtk3 when having two columns) and the slider widget with a spinbox would need to take up their own row of the sidebar (e.g. transparency slider in area content panel), which takes up two rows of the sidebar when you have a label for it and this causes problems with the limited height space we have. > Would be good to have a mockup to talk about your idea. Enjoy Thinking about the issue more, we could also leave out the color balance (aka rgb) row, as i dont see many users changing the value similar to how they dont in the toolbar.
(In reply to Yousuf Philips (jay) from comment #2) > (In reply to V Stuart Foote from comment #1) > > But, from where would we be picking up the "Correction" controls? > > "Correction" is the label and the control would be a preset drop down list > various brightness & contrast values like 'Default', '-10% Brightness', > '-10% Contrast', '-10% Brightness & Contrast', '+10% Brightness', '+10% > Contrast', '+10% Brightness & Contrast', ... > > > And maybe then the "Gamma" control might also go onto a slider in the Image content panel. > > If it is deemed important to keep this in the content panel, which i dont > think it is based on possible usage, then a preset drop down would be useful > to use rather than a slider because of space. Jay, so how many presets for Brightness and Contrast one should be expecting? And can you highlight the presets for the color balance?
Created attachment 129535 [details] correction and balance presets (In reply to Susobhan Ghosh from comment #5) > Jay, so how many presets for Brightness and Contrast one should be > expecting? 'Default', '-10% Brightness', '-10% Contrast', '-10% Brightness & Contrast', '+10% Brightness', '+10% Contrast', '+10% Brightness & Contrast', '-20% Brightness', '-20% Contrast', '-20% Brightness & Contrast', '+20% Brightness', '+20% Contrast', '+20% Brightness & Contrast', '-40% Brightness', '-40% Contrast', '-40% Brightness & Contrast', '+40% Brightness', '+40% Contrast', '+40% Brightness & Contrast'. It would be nice if it is possible to sort the minus presets above 'Default' and the plus presets below 'Default'. > And can you highlight the presets for the color balance? 'Default', '+25% Red', '+50% Red', '+100% Red', '+25% Green', '+50% Green', '+100% Green', '+25% Blue', '+50% Blue', '+100% Blue', '+25% Yellow', '+50% Yellow', '+100% Yellow', '+25% Magenta', '+50% Magenta', '+100% Magenta', '+25% Cyan', '+50% Cyan', '+100% Cyan', '+25% White', '+50% White' Would be great if the preset values could be stored in the .ui file, so it would be easy for us to add, edit and reorganize the presets without requiring additional coding. @All: I've attached a document with all these presets in it so it is easy for everyone to visually see the preset list and comment on it.
Created attachment 129564 [details] Mockup of presets for brightness/contrast (In reply to Yousuf Philips (jay) from comment #6) > 'Default', '-10% Brightness', '-10% Contrast', '-10% Brightness & Contrast', > ... That's definitely a preset, and the appropriate control is not the dropdown. Even this set is better realized per slider as Benjamin would need to iterate through the options in order to understand the difference of 25% vs. 50%, for example. The step between 50 and 100% yellow is too large and between 20 and 20% B/C there is almost no difference. The point is that those steps are arbitrary values, which is not bad per se but not a replacement for the spinboxes. Attaching a mockup of what I mean, very rough draft only.
(In reply to Heiko Tietze from comment #7) > Attaching a mockup of what I mean, very rough draft only. To rough for me to understand anything and dont see why an image name drop down would ever appear in the sidebar's properties deck.
(In reply to Yousuf Philips (jay) from comment #8) > ...dont see why an image name drop > down would ever appear in the sidebar's properties deck. The dropdown provides access to the presets. 'Ocean' is a collection of properties with brightness, contrast etc. But anyway, we should discuss the topic in detail.