Download it now!
Bug 103272 - Add missing image color adjustment properties to image properties dialog
Summary: Add missing image color adjustment properties to image properties dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval, topicUI
Depends on:
Blocks: Image-Dialog
  Show dependency treegraph
 
Reported: 2016-10-17 06:57 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-12-08 19:45 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Image Tab with New Properties (60.64 KB, image/png)
2016-12-06 07:01 UTC, Muhammet Kara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-10-17 06:57:24 UTC
So we have a number of image properties that are available in the toolbar and sidebar, but are not accessible in the image properties dialog.

* Image/Color Mode (.uno:GrafMode)
* Transparency (.uno:GrafTransparence)
* Brightness
* Contrast
* Colorization [red, blue, green, gamma]

They should be added to the image tab.
Comment 1 Muhammet Kara 2016-12-06 07:01:45 UTC
Created attachment 129336 [details]
Image Tab with New Properties

Would it be enough to mimic the appearance of the sidebar?

How should it behave? Do we need to reflect the changes on the preview image?
Comment 2 Heiko Tietze 2016-12-06 14:17:02 UTC
(In reply to Muhammet Kara from comment #1)
> Would it be enough to mimic the appearance of the sidebar?
> How should it behave? Do we need to reflect the changes on the preview image?

The properties are okay but not really good arranged. Better you add a subtitle like Flip and Link and indent the controls.

Ideally the color mode should affect the RGB values but it looks like these values and gamma are handled differently. In this case I would add a new section title and while the icons are clear you better go with plain labels since those are accessible.

The image preview should reflect what is configured. And since X-mas is near I wish to have the same layout and interaction as on the new area style dialog (https://design.blog.documentfoundation.org/2015/12/22/area-fill-options-made-consistent/) with a number of presets at the left column, the actual settings in the middle and the preview right hand.

Furthermore, the user may want to revert changes so a reset button is needed (in some condition the modifications weren't revertible). Found it: Filter. To me the 'simple' modifications and the filter are similar tweaks. But combining them would affect the functionality and make repeated filter operations impossible.
Comment 3 Yousuf Philips (jay) (retired) 2016-12-08 18:12:53 UTC
(In reply to Muhammet Kara from comment #1)
> Would it be enough to mimic the appearance of the sidebar?

As the sidebar appearance isnt the most optimal one, i wouldnt end there. Here are some changes.

1) Change image labels to text labels.
2) Have sliders with each spinbox.
3) Controls need to be better organized to better suit dialog content.

> How should it behave? Do we need to reflect the changes on the preview image?

It should work similar to all other values where it changes the preview and only gets applied when the 'OK' button is pressed.

(In reply to Heiko Tietze from comment #2)
> The properties are okay but not really good arranged. Better you add a
> subtitle like Flip and Link and indent the controls.

Yes a section heading like 'Adjust' would be good.

> The image preview should reflect what is configured. And since X-mas is near
> I wish to have the same layout and interaction as on the new area style
> dialog
> (https://design.blog.documentfoundation.org/2015/12/22/area-fill-options-
> made-consistent/) with a number of presets at the left column, the actual
> settings in the middle and the preview right hand.

Dont think the 3 column layout is good for this situation and instead we should likely have preset drop down lists that modify various groups of entries, like one for brightness & contrast and a second for RGB, and these presets would then also go into the sidebar to replace all the spinboxes. (bug 104505)

> Furthermore, the user may want to revert changes so a reset button is needed
> (in some condition the modifications weren't revertible).

Yes a 'Reset Adjustments' or 'Reset Colors' button to reset all the color adjusting values to their defaults might be useful, like we have a 'Original Size' button in the Crop tab.