Bug 93090 - Image content panel does not contain the crop, flip and rotate properties
Summary: Image content panel does not contain the crop, flip and rotate properties
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.4 rc
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Properties-Image Sidebar-Properties-PositionAndSize
  Show dependency treegraph
 
Reported: 2015-08-03 05:13 UTC by narayanaras
Modified: 2019-02-09 17:01 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description narayanaras 2015-08-03 05:13:04 UTC
Select any image in Writer, and check out the "Properties" panel on the right.

You will notice that this panel does not display the crop, flip and rotate properties. 

As a result, the user still has to look for these controls through a separate toolbar. This defeats the very purpose of putting all properties in a single place, for easy access.

Note that the panel also must have a "Reset" button for each of the crop, flip and rotate properties; just like the "Original size" button resets any resizing.
Comment 1 Buovjaga 2015-08-03 11:58:19 UTC
Ok let's set to NEW.
Comment 2 Samuel Mehrbrodt (allotropia) 2015-11-24 10:56:01 UTC
Flip buttons have been added with http://cgit.freedesktop.org/libreoffice/core/commit/?id=11921d2269ec993167d81a5ed47ea6c14fc1a5f6 .

The others are still missing.
Comment 3 Yousuf Philips (jay) (retired) 2016-12-08 18:36:19 UTC
@Heiko, @Stuart, @Cor: What is your takes on where this? For shapes, we have flip and rotate options in 'Position and Size' content panel and we have image flip properties in 'Position and Size'. Not so sure that a crop action should be in the properties deck and users will likely go to the context menu for this option.
Comment 4 V Stuart Foote 2016-12-08 19:45:06 UTC
LOL, I was just entering a note on bug 103272 regards this...

...in a bit of a consistency issue between dialogs and Sidebar--the Flip control lives in the Image dialog's Image tab, but it sits in the Position and Size content panel (PosSizePropertyPanel.cxx) on the Side bar (and that is common for all graphics in all modules).

Do the flip and rotate controls belong in the Position & Size content panel for consistency across the modules, or in the Image content panel (GraphicPropertyPanel.cxx) for the Properties deck in Writer? 

Either way, the Image content panel needs a "more options" button (as in bug 104507) to link it to the Image dialog
Comment 5 V Stuart Foote 2016-12-08 20:05:42 UTC
And, regards the rotate actions. A graphic (Draw object) in the other modules (Draw, Impress, Calc) can be rotated using the Rotation widget--but in Writer only a raster image can be rotated in 90° increments (as Tomaž had implemented for bug 34423). 

Eventually we'll get angular rotation in Writer as well, but where to put the rotation buttons for the content panel and the Image dialog for Writer?
Comment 6 Heiko Tietze 2016-12-09 17:51:53 UTC
(In reply to Yousuf Philips (jay) from comment #3)
> @Heiko, @Stuart, @Cor: What is your takes on where this? 

I'm against putting all features into the sidebar. Single click only and frequently used would be my premise. That means Rotate yes and Flip marginal (the four work well together as one functionality) but Crop is out of scope.
Comment 7 Yousuf Philips (jay) (retired) 2016-12-10 10:10:19 UTC
So with only Writer not having the Position and Size dialog available to images, we should have the flip and rotate in the Position and Size content panel for consistency across modules.

As Heiko also agrees, we shouldnt include the crop function in the sidebar.
Comment 8 Cor Nouws 2019-02-09 17:01:02 UTC
(In reply to Yousuf Philips (jtay) (retired) from comment #7)
> So with only Writer not having the Position and Size dialog available to
> images, we should have the flip and rotate in the Position and Size content
> panel for consistency across modules.
> 
> As Heiko also agrees, we shouldnt include the crop function in the sidebar.
Agreeing.
Rotate and scaling are there. So close as WFM.
Thanks for bringing this up, narayanaras,