Description: Applying table properties without explicitly modifying border color loses previous border color Steps to Reproduce: 1.Change table border color to any different that black. 2.Apply. 3.Open table properties again, apply without changing nothing or changing other thing that the color. Actual Results: The color setting is lost and boder color is reverted to black. Expected Results: Border color isn't changed. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36
Confirmed with 5.3beta1, works fine with 5.2.0.4. => regression
commit f26fbbd08d0792fd5fc361faaa1cf183824bdd44 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Mon Nov 7 13:28:42 2016 -0800 source 64a708cba9b954afe3331f63c58218eb53b3d0ce source 64a708cba9b954afe3331f63c58218eb53b3d0ce # bad: [479ca41474b9720803421ab7717aa69fa6c60528] source f8c463b393885b660500bf4f7f73b4fb90ce2389 # good: [defb73f1c6e2a66dbd21ba89e684f57427e8bc4b] source 5b168b3fa568e48e795234dc5fa454bf24c9805e git bisect start '479ca41474b9720803421ab7717aa69fa6c60528' 'oldest' # good: [1c50425620ffbce30bb57f9ff19ef3c5d20d69f1] source b62f4c2cd9685618fff2270760ce0787880f1c8d git bisect good 1c50425620ffbce30bb57f9ff19ef3c5d20d69f1 # good: [70770f0ce4d3672d5cd2759605adb44d867e7208] source 0b7e11a2a7ade0b565c18d1deb58c19848f6ceef git bisect good 70770f0ce4d3672d5cd2759605adb44d867e7208 # good: [ce5c761b06e108ba3a25fccda8acb9d3c2aedaba] source ea6b378221efea0392c5085d621ff38a612ade3e git bisect good ce5c761b06e108ba3a25fccda8acb9d3c2aedaba # bad: [d385e273cdb47c051f2718c82758a9ad10364233] source 40f8c14be28aeb78fe758264b43a255d2bfd4938 git bisect bad d385e273cdb47c051f2718c82758a9ad10364233 # bad: [17243a590c1dbcd7003c8c42d86646f98cc7a13b] source 85102b0fe499dc0cdcedecb5fe6fdeaabee9bf0a git bisect bad 17243a590c1dbcd7003c8c42d86646f98cc7a13b # good: [5db688113252e2ee57ac84d1eafaf82dab344497] source 2536bd8b267156691f65c535f20b365857f13a96 git bisect good 5db688113252e2ee57ac84d1eafaf82dab344497 # good: [3e82a2c60ad606c0526330969f70d85c99824fad] source b9b03c7383035beaa6d5d89cd895436288403691 git bisect good 3e82a2c60ad606c0526330969f70d85c99824fad # bad: [cf4ab1cc5528180df12fb4afdd484608f535da88] source 4948daa16d98394e19d0f09ed46586599b2be140 git bisect bad cf4ab1cc5528180df12fb4afdd484608f535da88 # bad: [21f40e7a64284f71bce343e911deb9a5c9810e67] source 525a45f22f591d8046ca95af3073ed27fd283ef0 git bisect bad 21f40e7a64284f71bce343e911deb9a5c9810e67 # good: [f2dad397b6ff8dc4e2f065f030eec2eb60b6424c] source f9028f1945e3ad87cda1b3001611632b1b424467 git bisect good f2dad397b6ff8dc4e2f065f030eec2eb60b6424c # bad: [f26fbbd08d0792fd5fc361faaa1cf183824bdd44] source 64a708cba9b954afe3331f63c58218eb53b3d0ce git bisect bad f26fbbd08d0792fd5fc361faaa1cf183824bdd44 # good: [6811862de740849e89f737133d10f566bdf50d14] source f01c49c4a89ecad2376fd0023625186e5cac642e git bisect good 6811862de740849e89f737133d10f566bdf50d14 # first bad commit: [f26fbbd08d0792fd5fc361faaa1cf183824bdd44] source 64a708cba9b954afe3331f63c58218eb53b3d0ce
This seems to have started with the color picker change. Adding Cc: to Caolán McNamara, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=64a708cba9b954afe3331f63c58218eb53b3d0ce author Caolán McNamara <caolanm@redhat.com> 2016-11-05 20:28:27 (GMT) committer Caolán McNamara <caolanm@redhat.com> 2016-11-07 21:04:50 (GMT) "Revert "Reverts a commit series that cripple windows ci." with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601."
*** Bug 105360 has been marked as a duplicate of this bug. ***
*** Bug 104727 has been marked as a duplicate of this bug. ***
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2eaaa8a578fff5770a99e3f8ee2a7c95c460891 Resolves: tdf#104552 table properties dialog drops previous border color It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
backport for 5-3 are in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b8b744a4ea46a4e68383f9283e00f4de5fa8a1cf&h=libreoffice-5-3 Resolves: tdf#104552 table properties dialog drops previous border color It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.