Description: Currently finding kashida insertion positions and the width of each is done by Writer, but the actually kashida insertion is done by VCL. However, the positions and widths are not communicated explicitly between the two; instead Writer will modify the DX array at the kashida insertion position by the required width, then VCL will guess based on the character and script whether a given DX adjustment is a regular width change or a kashida insertion. This is clearly very brittle and is a source of all kinds of hard to fix random kashida insertion bugs. To fix this, Writer should explicitly pass the kashida insertion points and widths to VCL, separate from the DX adjustments. Actual Results: Expected Results: Reproducible: Always User Profile Reset: Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
*** Bug 114257 has been marked as a duplicate of this bug. ***
From bug 112849 comment 4: > Kashida in LibreOffice is fundamentally broken: > > // A note on how Kashida justification is implemented (because it took me 5 > // years to figure it out): > // The decision to insert Kashidas, where and how much is taken by Writer. > // This decision is communicated to us in a very indirect way; by increasing > // the width of the character after which Kashidas should be inserted by the > // desired amount. > // > // Writer eventually calls IsKashidaPosValid() to check whether it can > insert a > // Kashida between two characters or not. > // > // Here we do: > // - In LayoutText() set KashidaJustification flag based on text script. > // - In ApplyDXArray(): > // * Check the above flag to decide whether to insert Kashidas or not. > // * For any RTL glyph that has DX adjustment, insert enough Kashidas to > // fill in the added space. > > from > https://gerrit.libreoffice.org/gitweb?p=core.git;a=blob;f=vcl/source/gdi/ > CommonSalLayout.cxx;h=8e8565717932088558ee7a4b31fc0bfe405e98e3;hb=HEAD#l698 > > The insanity described above together with the the whole DX array madness > and the use of integers to hold glyph positions, makes is so that any > rounding errors would cause VCL to think that writer wants to insert a > kashida in this place. > > Fixing kashida once and for all requires 1) making the communication between > Writer and VCL explicit e.g. have a separate “kashida insertion points” > array 2) Kill DX array for good and enter the 21 century (it is an API > “inspired” by Windows 3.1 3) Fix rounding errors by preserving fractional > glyph positions in a way or another.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still an issue.
Dear Khaled Hosny (inactive), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3901e029bd39575f700e69a73818565d62226a23 tdf#104921: Cleanup Kashida insertion logic It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Wow, 8 bugs down in one strike... nicely done! Thanks, Khaaled.
Verified in duplicate report. Thanks Khaled!