Description: There is a delay when reopening the Edit style menu for a second time after launch, one which wasn't there before Steps to Reproduce: 1.Open a Writer document. 2. Right Click it and select "Edit Style" (will take a few sec). 3. Close it. 4. Open it again; There is a small delay (2 sec) in 5.3.0.2 Actual Results: There is a small delay for reopening the "Edit Style" menu, which wasn't there before Expected Results: Instantaneous opening Reproducible: Always User Profile Reset: No Additional Info: Found in: Version: 5.4.0.0.alpha0+ Build ID: 99eed82939999d9a9689788a4134dd05d5c20c5a CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-14_23:37:40 Locale: nl-NL (nl_NL); Calc: CL and in: Versie: 5.3.0.2 Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16 CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: standaard; Layout-Engine: nieuw; Locale: nl-NL (nl_NL); Calc: CL but not in Versie: 5.3.0.0.alpha1 Build ID: f4ca1573fcf445164c068c1046ab5d084e1b005f CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: standaard; Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Setting to NEW. Confirmed on IRC: [20:12] <bearon> Telesto: i agree, please do the same thing :)
59c84eb61bea3220d26c114ebc16d24233afbbb3 is the first bad commit commit 59c84eb61bea3220d26c114ebc16d24233afbbb3 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Thu Dec 22 07:19:12 2016 -0800 source 89488baf09d2e7580041462b409f587ce43af214 # bad: [166286094e583fb471c9500fdbddee4e83ef478c] source 70b3dd697cb248fb56830db691269fe9e78c57fb # good: [5e01bd2a91a717cdaccff18de7c44de37b270914] source 8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533 git bisect start '166286094e583fb471c9500fdbddee4e83ef478c' '5e01bd2a91a717cdaccff18de7c44de37b270914' # good: [31add47b80c8edda68eafbffc3f4d33d836a31e9] source 72ffa98e892ad1b64ff3a00b1e26a995cba3076f git bisect good 31add47b80c8edda68eafbffc3f4d33d836a31e9 # good: [36639c539998db9502ec6540329bdcc9f0687018] source de35a932f409893e11faed78ca9e486b7cb3c265 git bisect good 36639c539998db9502ec6540329bdcc9f0687018 # good: [8ccd4cece45d63beced420553fe1cf45f010e5b3] source 38bf0e92e0f78e72345474013f695a2e660ee732 git bisect good 8ccd4cece45d63beced420553fe1cf45f010e5b3 # good: [fa8c4cf3a5cbe2b0bae4c6e0f939a31ec4399cc3] source a538162b8b9c437ccd0f47bdb042317914118c6d git bisect good fa8c4cf3a5cbe2b0bae4c6e0f939a31ec4399cc3 # bad: [e0823c2101de1e5a225b500069fb75abd4f71203] source 44d04222c6e668795d5abd2c83d7e24153d55de1 git bisect bad e0823c2101de1e5a225b500069fb75abd4f71203 # good: [665098ab387cabffa6676fc244345988d6acde71] source 0cf5d53208e487f98f4351b4ca40110079914288 git bisect good 665098ab387cabffa6676fc244345988d6acde71 # good: [699b9b8beb42f07531f780b02b9f0726b57113d9] source 3bff2da31ed580817f6b5b653f48727e38078af5 git bisect good 699b9b8beb42f07531f780b02b9f0726b57113d9 # good: [3b2099d6cc727ea1974a3b436a842efed9676009] source e95e05795d192275fa3c44a87377ce8353ae32d8 git bisect good 3b2099d6cc727ea1974a3b436a842efed9676009 # good: [3f63fc18b9d12b4c769b895ef1fb9e9c04e5f628] source 588d917d0af740bb75c7cf5085f0db63e35f2df0 git bisect good 3f63fc18b9d12b4c769b895ef1fb9e9c04e5f628 # bad: [f0228b1e55d85a8dad4c37cd44e39753105e860f] source b1afb3e65ca6d3fa382f9aa948195413dcdaef11 git bisect bad f0228b1e55d85a8dad4c37cd44e39753105e860f # bad: [59c84eb61bea3220d26c114ebc16d24233afbbb3] source 89488baf09d2e7580041462b409f587ce43af214 git bisect bad 59c84eb61bea3220d26c114ebc16d24233afbbb3 # first bad commit: [59c84eb61bea3220d26c114ebc16d24233afbbb3] source 89488baf09d2e7580041462b409f587ce43af214
This slowness seems to have started with the addition of palettes, which as far as I can see are loaded again and again on each opening of the dialog. Not adding Heiko, as it can't be fixed on UX side. Maybe caching of palettes could be the fix here. https://cgit.freedesktop.org/libreoffice/core/commit/?id=89488baf09d2e7580041462b409f587ce43af214 author heiko tietze <tietze.heiko@gmail.com> 2016-12-17 10:48:02 (GMT) committer jan iversen <jani@documentfoundation.org> 2016-12-22 14:37:42 (GMT) "tdf#87538 New standard color palette, tdf#104052 Add LibreColour HLC palette" Btw, I first bibisected it with OpenGL enabled, and then I arrived to Khaled's commit for enabling the new layout engine: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533 Maybe more than one factors are at work here (at least with OpenGL rendering). It could probably use a bit of investigation...
*** Bug 105523 has been marked as a duplicate of this bug. ***
Might be the same cause, but the problem exists on the first opening of the style dialogue. Also, the time waiting is considerably more than 2 secs. On Win 10, LO 5.3.0.3 (64 bit) is consistently taking >45 seconds for the dialogue box to open, whether to modify or create a new style. It makes working with styles, if not impossible, exceedingly frustrating. Can the importance of this be raised? It's major for me.
I suggest this bug gets a higher priority, since it makes working with styles completely unusable…
(In reply to tomaskeb from comment #6) > I suggest this bug gets a higher priority, since it makes working with > styles completely unusable… It would have to cause a crash to get a higher priority..
Created attachment 131657 [details] WinDBG Backtrace With non-debug build Version: 5.4.0.0.alpha0+ Build ID: 472f92421b1b15dc765714a7c657704812859868 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-03-02_00:18:28 and with debug-build Version: 5.4.0.0.alpha0+ Build ID: a5c947579253a7f4e784004e18929af5ab22fa28 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@39, Branch:master, Time: 2017-03-02_01:57:01
I wonder if the palette could be read in advance and cashed.
This is essentially the same issue as bug 104312, just exacerbated by the larger palette. *** This bug has been marked as a duplicate of bug 104312 ***
Aron Budea committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9f511317fa5f1c655d189a8507f8a5492a3b08d tdf#104312, tdf#105428: use static vars in ReplaceStringHookProc It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Aron There is still remains a small but quite noticeable delay (+/- 2 sec) when opening the Edit Style menu (or Character/ Paragraph) on MacOS. Similar to what I reported here for Windows Version: 5.4.0.0.alpha1+ Build ID: 9d320ec4d818f86e58a15fd46248026502b1cc94 CPU threads: 4; OS: Mac OS X 10.12.5; UI render: GL; TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2017-05-09_00:05:27 Locale: nl-NL (nl_NL.UTF-8); Calc: group
Aron Budea committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=aafb6a75c7461362aceddeadfbf0db0848af866c&h=libreoffice-5-3 tdf#104312, tdf#105428: use static vars in ReplaceStringHookProc It will be available in 5.3.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.