Created attachment 130668 [details] Backtrace If the hardware doesn't have enough OpenGL capability for LibreOffice, it hangs, and sometimes crashes upon first start. Reproduced with 5.3.0.1 and 5.3.0.2 / Windows 7. Not reproduced with 5.2.4.2. => regression I couldn't send a crash report, but the backtrace is attached. Looks like an infinite recursion attempt.
a61252b54866ed6c190422dbce86aae8f4ef8e99 is the first bad commit commit a61252b54866ed6c190422dbce86aae8f4ef8e99 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Fri Dec 16 04:35:03 2016 -0800 source 11e6f819122bc51b5ed58d2dbace754c00faa7c8 # bad: [166286094e583fb471c9500fdbddee4e83ef478c] source 70b3dd697cb248fb56830db691269fe9e78c57fb # good: [e19e7a72a0d578994803b59bd03386911b92bbad] source e6c004dd9f24c32f5e7468182a5e8d42293ec7b6 git bisect start '166286' 'e19e7a7' # good: [0852a242880bf9e35dbebf098bf5fd866f5ab214] source ebe46f14a266f7e538bc8b8fa6b9f7d78c5e308d git bisect good 0852a242880bf9e35dbebf098bf5fd866f5ab214 # good: [000a4fc35af4d0c25c3730e4531597aeba340052] source 06916c839b16866b47235306d2db50850df0ad7c git bisect good 000a4fc35af4d0c25c3730e4531597aeba340052 # good: [adddc631ed5a8b1c56da5a3c75681d51b9381429] source 6bad5027dadaa3f99a33eb752d8477d7abe92137 git bisect good adddc631ed5a8b1c56da5a3c75681d51b9381429 # good: [5e27824df5966ce3f1fcf12e192bed94af9aa02c] source 3ef6d731a1e97ab0843469011fead834376ea223 git bisect good 5e27824df5966ce3f1fcf12e192bed94af9aa02c # good: [49795a696d28e10d82c0b8eb9195e113a3645fb2] source f2f495ea0fb69031cd1b394176e0a91191b594d8 git bisect good 49795a696d28e10d82c0b8eb9195e113a3645fb2 # bad: [1c484bb7aaeb0992f7973b133f241c6a6d6a9dd0] source b4e1d0240ed55f05d435bb848d8f256cc81e3ba3 git bisect bad 1c484bb7aaeb0992f7973b133f241c6a6d6a9dd0 # good: [cc4358eb749d66d6a48a30ea679c3a0a39f87ad2] source a1f6159db30e2463b118c1571bb01a09356b7c49 git bisect good cc4358eb749d66d6a48a30ea679c3a0a39f87ad2 # good: [626369369677df78749af63bbd005a8e1f25b615] source 6238f71ddbdc766e733b1c808a4fa7d66f7bde87 git bisect good 626369369677df78749af63bbd005a8e1f25b615 # bad: [3cedf6c4bdd90f4d9f1646d960da3bfbaac1a2c1] source 76c70390cb51ed292e3e0bf39694bab6063e7779 git bisect bad 3cedf6c4bdd90f4d9f1646d960da3bfbaac1a2c1 # good: [180506aadaab1359b767847ecfefe40ffaddcf55] source 638f40d16c9e0b01e3cb0f53d9d5703a361b2100 git bisect good 180506aadaab1359b767847ecfefe40ffaddcf55 # good: [58850deab3defdb40eb4f7ad5ab5d5e860dcfb37] source 6cf3040fe180ae684a60655685a493843c2b162a git bisect good 58850deab3defdb40eb4f7ad5ab5d5e860dcfb37 # bad: [a61252b54866ed6c190422dbce86aae8f4ef8e99] source 11e6f819122bc51b5ed58d2dbace754c00faa7c8 git bisect bad a61252b54866ed6c190422dbce86aae8f4ef8e99 # good: [c27799693cf71f838c442fb80eefb73fe87fec7e] source 92d6ca6dc81854b4a9272266907c08f320eef3eb git bisect good c27799693cf71f838c442fb80eefb73fe87fec7e # first bad commit: [a61252b54866ed6c190422dbce86aae8f4ef8e99] source 11e6f819122bc51b5ed58d2dbace754c00faa7c8
Bibisection points to the commit referenced below, adding Cc: to Caolán McNamara, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=11e6f819122bc51b5ed58d2dbace754c00faa7c8 (5.3) https://cgit.freedesktop.org/libreoffice/core/commit/?id=d96686e482d2f2649dbd87d7ed9db2775e5d22f5 (master) author Caolán McNamara <caolanm@redhat.com> 2016-12-08 14:16:41 (GMT) committer Caolán McNamara <caolanm@redhat.com> 2016-12-09 13:07:26 (GMT) "move the windows restart because of bad-opengl requirements to a better place" Self-confirming, as I encountered this bug in two separate systems (it crashed in one and hung in the other).
Aron, but isn't this what we expect? Maybe a bit less stable now, but still intentional... 1. OpenGL enabled by default on Windows 2. OS/GPU/driver combo not blacklisted 3. a substandard OpenGL support -> crash recover OpenGL disabled 4. run with OpenGL disabled
The backtrace is convincing. Looked through the crashreport server, unfortunately not seeing reports for this area of OpenGL--I even opened a couple dozen of the generic mergedlo signature agains 5.3.0.1/5.3.0.2--didn't see any against this. So either its not going to be common, or the hang isn't triggering the minidump and report.
(In reply to V Stuart Foote from comment #4) > So either its not going to be common, or the hang isn't triggering the > minidump and report. Yes, in one system it hung during load (nothing appeared, only soffice.bin+exe in task manager), and nothing happened. In the other system it hung, and then crashed with a Windows crash dialog. Trying to submit a crash report when offered afterwards gave an "Error" text in the dialog instead of the link. It might be worth checking with Markus if the crash dump really is unusable in this case, or that is a bug with error reporting. Regarding the regular crash/recover behavior during OpenGL probing, that normally happens quickly, and without any visible indication of an error (in 5.2.4.2 for example).
(In reply to V Stuart Foote from comment #4) > So either its not going to be common, or the hang isn't triggering the > minidump and report. Bug 105524 contains the explanation why.
https://gerrit.libreoffice.org/#/c/33580/ might solve this
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a61fdbf0b64dac30a2fe098388cd20471cca7bb Related: tdf#105514 recursive fallback GetOpenGLContext It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I can't test this myself, so I'd like to find out if this actually solves the problem, if it does I'll backport it
I'll test it once a daily build containing the commit is available for Windows.
I can confirm there is no crash in the daily build from 2017-01-29, LibreOffice starts with default rendering in the affected systems. Version: 5.4.0.0.alpha0+ Build ID: e073bb9c3ea2f7d03a7cf0759efc70edf84fc033 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-29_05:25:38 Locale: hu-HU (hu_HU); Calc: CL
so, that's fixed in master then, backport now in gerrit for 5-3
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bafb52624869a5078636a462a06fd65b9efaf04b&h=libreoffice-5-3 Related: tdf#105514 recursive fallback GetOpenGLContext It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.