Bug 105663 (Sidebar-Spellcheck) - Sidebar deck for reviewing spelling and grammar mistakes
Summary: Sidebar deck for reviewing spelling and grammar mistakes
Status: NEW
Alias: Sidebar-Spellcheck
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Spell-Checking Sidebar-New-Decks
  Show dependency treegraph
 
Reported: 2017-02-01 12:07 UTC by Olivier R.
Modified: 2017-06-01 00:00 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
dialog vs sidebar mockup (58.39 KB, image/png)
2017-05-15 23:05 UTC, Yousuf Philips (jay) (retired)
Details
Spellchecking in Sidebar (34.42 KB, image/png)
2017-05-31 09:09 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier R. 2017-02-01 12:07:59 UTC
Description:
Somme users complain it’s difficult, when proofreading a text, to follow all mistakes, especially when some of them concern one-letter words or typographical rules. So having a way to list all mistakes in the sidebar would be a huge improvement.

The goal is to provide a better tool for proofreaders to list/tag/follow mistakes.


Related issues:
1. Add the ability to bookmark or comment spelling/grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073

2. UNO: Jump to next spelling/grammar error
https://bugs.documentfoundation.org/show_bug.cgi?id=98441

Steps to Reproduce:
Feature request.

Actual Results:  
Nothing.

Expected Results:
Feature requested.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Comment 1 Heiko Tietze 2017-02-01 12:25:53 UTC
Good idea, should be part of revamping the Navigator.
Comment 2 V Stuart Foote 2017-02-01 16:11:09 UTC
@Hieko, *

Why would Spelling and Grammar modules be interfaced to Navigator deck?

Would be a cleaner UI to have both Spelling and Grammar checking control their own Content panel--if not a complete Deck to replace/supplement the Spelling and Grammar dialog.

Issue currently is that the Spelling and Grammar dialog renders the review one sentence at a time with the word in context.  Issue is the need for an additional list based UI to advance through corrections.

It could be added to the dialog--or reasonably we could move the dialog onto the Sidebar as a deck, including a new list based UI along with the by sentence review in context.

Again--do not see this in anyway related to work needed with the Navigator deck.
Comment 3 Olivier R. 2017-02-01 16:53:01 UTC
+1. It should be a different panel than the navigator.
Comment 4 Heiko Tietze 2017-02-01 21:40:50 UTC
(In reply to V Stuart Foote from comment #2)
> Why would Spelling and Grammar modules be interfaced to Navigator deck?

I would look for document related places at the Navigator. That includes comments, bookmarks, changes etc., in general everything that is related to a certain page. If we put the various functions in extra decks it will quickly clutter the sidebar tabs.
Comment 5 Olivier R. 2017-02-01 23:01:01 UTC
(In reply to Heiko Tietze from comment #4)
> I would look for document related places at the Navigator. That includes
> comments, bookmarks, changes etc., in general everything that is related to
> a certain page. If we put the various functions in extra decks it will
> quickly clutter the sidebar tabs.

Grammar/spelling/typographic errors are like changes, they also need a specific tab for specific interactions. They can be hundreds mistakes, or even thousands, like changes.

The Navigator is better fit to list objects that are part of a document.
Comment 6 Yousuf Philips (jay) (retired) 2017-02-02 11:11:04 UTC
+1 for another deck.

(In reply to Heiko Tietze from comment #4)
> I would look for document related places at the Navigator. That includes
> comments, bookmarks, changes etc., in general everything that is related to
> a certain page.

I would disagree with jamming everything into the navigator, specially when the intent is to adapt various existing modal dialogs (spelling, track changes, etc) functionality into the sidebar. Navigator should focus on jumping to various elements within the document, but jumping to every spelling mistake and every track change would be crazy.

https://design.blog.documentfoundation.org/wp-content/uploads/sites/2/2016/07/20160730_Writer.png

> If we put the various functions in extra decks it will
> quickly clutter the sidebar tabs.

Would assume cluttering horizontal tabs of the navigator would be even worse, especially when we have so much empty space in the sidebar's tab bar.
Comment 7 Yousuf Philips (jay) (retired) 2017-05-15 23:05:57 UTC
Created attachment 133344 [details]
dialog vs sidebar mockup

So here is a mockup showing both the dialog and sidebar versions next to each other. Instead of the large 'Not in dictionary' multiline text field found in the dialog, a simple read-only text field will display the currently mispelt word and the same word would be highlighted within the document.

6 of the 9 buttons in the sidebar already have uno commands and 2 others are awaiting uno commands to be created for them (bug 98441).
Comment 8 Heiko Tietze 2017-05-31 09:09:50 UTC
Created attachment 133740 [details]
Spellchecking in Sidebar

Less is more, and I wouldn't replicate all commands in the sidebar. Rather list the tasks and allow a simple walk-trough. Selection expands the alternatives along with apply in my rough mockup, that's all.
Comment 9 Yousuf Philips (jay) (retired) 2017-05-31 14:48:08 UTC
(In reply to Heiko Tietze from comment #8)
> Created attachment 133740 [details]
> Spellchecking in Sidebar

Some thoughts that came to mind after seeing the mockup.

So the intend is to list all spelling mistakes in the sidebar as expandable entries and corrected mistakes will remain in the sidebar even after being corrected?

If all spelling mistakes are to appear in the sidebar, I would expect to see a scrollbar.

Will the user be able to modify the word within the sidebar?

Having the previous and next buttons at the bottom wouldnt be good, as users would have to navigate alot by mouse.

As you dont want to replicate all commands in the sidebar, i would atleast expect 'Correct All' and 'Add to Dictionary' should be there.
Comment 10 Heiko Tietze 2017-05-31 14:57:16 UTC
(In reply to Yousuf Philips (jay) from comment #9)
> So the intend is to list all spelling mistakes in the sidebar as expandable
> entries and corrected mistakes will remain in the sidebar even after being
> corrected?

Better remove the corrected passages.
 
> Will the user be able to modify the word within the sidebar?

This would better be done in the dialog.
 
> Having the previous and next buttons at the bottom wouldnt be good, as users
> would have to navigate alot by mouse.

How about shortcuts like cursor up/down? And of course you can just click an item without using the next button.

> As you dont want to replicate all commands in the sidebar, i would atleast
> expect 'Correct All' and 'Add to Dictionary' should be there.

If you do a single apply all action why should that go into the sidebar? Afraid of using dialogs? :-)
Comment 11 Olivier R. 2017-05-31 15:11:17 UTC
(In reply to Yousuf Philips (jay) from comment #9)

> So the intend is to list all spelling mistakes in the sidebar as expandable
> entries and corrected mistakes will remain in the sidebar even after being
> corrected?

No. What is corrected should be removed.


> If all spelling mistakes are to appear in the sidebar, I would expect to see
> a scrollbar.

Of course.


> Will the user be able to modify the word within the sidebar?

Not useful if the text jumps to the position where the error is.


> As you dont want to replicate all commands in the sidebar, i would atleast
> expect 'Correct All' and 'Add to Dictionary' should be there.

+1
I never use the dialog box. It’s badly shaped and useless.
Comment 12 Yousuf Philips (jay) (retired) 2017-05-31 17:14:37 UTC
(In reply to Heiko Tietze from comment #10)
> Better remove the corrected passages.

great.

> This would better be done in the dialog.

okay.

> How about shortcuts like cursor up/down? And of course you can just click an
> item without using the next button.

Well you'll have to define how keyboard users will work with the sidebar, but yes mouse users could easily click whichever item they want to work on. So in that case, the buttons should be removed.

> If you do a single apply all action why should that go into the sidebar?
> Afraid of using dialogs? :-)

Didnt understand this. If i have multiple instances of 'didnt' listed in the sidebar, of course with other mispelt workds, and wanted to be corrected them all as 'didn't' rather than doing them manually 1 by 1, why wouldnt i want this option.

The sidebar implementation should be a replacement for the dialog, so users can choose either, and designers can choose which one to show to users (e.g. tabbed notebookbar would open the sidebar implementation rather than the dialog).
Comment 13 Heiko Tietze 2017-05-31 17:59:53 UTC
(In reply to Yousuf Philips (jay) from comment #12)
> The sidebar implementation should be a replacement for the dialog, so users
> can choose either, and designers can choose which one to show to users (e.g.
> tabbed notebookbar would open the sidebar implementation rather than the
> dialog).

We wrote in the HIG "...sidebar, which is a graphical presentation of context-sensitive properties optimized for fast access." The sidebar is supplemental to dialogs allowing direct access to some but not all properties.
Comment 14 Yousuf Philips (jay) (retired) 2017-06-01 00:00:13 UTC
(In reply to Heiko Tietze from comment #13)
> We wrote in the HIG "...sidebar, which is a graphical presentation of
> context-sensitive properties optimized for fast access." The sidebar is
> supplemental to dialogs allowing direct access to some but not all
> properties.

That only relates to the properties deck/tab.