Bug 93073 - Add the ability to bookmark or comment spelling/grammar mistakes in text from spellcheck dialog
Summary: Add the ability to bookmark or comment spelling/grammar mistakes in text from...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Spell-Checking Writer-Enhancements Bookmarks
  Show dependency treegraph
 
Reported: 2015-08-02 09:04 UTC by shelagh.manton
Modified: 2018-10-19 18:51 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Mockup for grammar/spellcheck bookmarks (61.56 KB, image/png)
2017-01-18 16:32 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description shelagh.manton 2015-08-02 09:04:01 UTC
It would be helpful when proof reading a complete document using the spelling/grammar checker to be able to bookmark or insert a comment at the point (usually a grammar point) so that you can inspect the problem later to see if there is a problem. I often ignore grammar points because I am not sure if the changes are appropriate, but would like to go back and inspect manually. This is difficult unless you write down the context and search for it later. 
It would be nice to just be able to insert a bookmark at the spot instead. This is something I have wished for in many editors I have used. Proprietary as well as free software.
Comment 1 Cor Nouws 2016-12-17 08:05:52 UTC
Hi Shelagh,

Thanks for the suggestion. I think your idea is clear and possible to implement if someone puts his hands on it.

ciao - Cor
Comment 2 shelagh.manton 2016-12-17 21:52:38 UTC
I hope someone does take it up as it would be a helpful change to those who proofread a lot.
Comment 3 Heiko Tietze 2017-01-18 16:32:59 UTC
Created attachment 130533 [details]
Mockup for grammar/spellcheck bookmarks

I like the idea. But rather than comments I suggest to occupy bookmarks. The mockup shows the additional button in the spellcheck dialog (ignoring all the other issues of this dialog). When clicked it adds a bookmark named Grammar or Spelling with the recommendation text to the document and continues. The right-hand document shows those bookmarks in the navigator, dealing with the idea of the enhanced navigator [1]. But of course the bookmarks could be handled as today.

[1] https://design.blog.documentfoundation.org/2016/07/31/how-the-navigator-may-support-object-handling-in-libreoffice-draw/
Comment 4 Heiko Tietze 2017-01-18 16:34:41 UTC
Removing needsUX, and the ticket may be better located at component Writer.
Comment 5 shelagh.manton 2017-01-18 20:00:27 UTC
Would it be hard to add a comment at a particular point through the spellcheck dialog? I think that would be a useful thing as well. You don't always know how people will use tools for their own benefit. 
But the bookmark button looks good in the mockup picture.
I read through the article on navigator but am not sure how it relates to using navigator for spellcheck bookmarks. 
Are you suggesting that the bookmarks can somehow be made into collections related to whether they are general, spelling or grammar bookmarks and so make it easier to find them? 

Cheers
Shelagh
Comment 6 shelagh.manton 2017-01-18 20:02:24 UTC Comment hidden (obsolete)
Comment 7 Cor Nouws 2017-01-18 22:48:01 UTC
(In reply to Heiko Tietze from comment #4)
> Removing needsUX, and the ticket may be better located at component Writer.

Then what about spell check in Calc/Impress>
Comment 8 shelagh.manton 2017-01-19 07:03:56 UTC
Comments for spelling for grammar points seem to me to be most useful in a long document where might not be able to see the context of the fragment and lose its place in the document. Would you have a spreadsheet where you would lose the context and I wonder if a presentation is long enough to lose your context for spelling it is probably too long for a presentation.
Comment 9 Heiko Tietze 2017-01-19 09:10:56 UTC
(In reply to shelagh.manton from comment #6)
> Would it be hard to add a comment at a particular point through the
> spellcheck dialog? 

Of course not. You may have a blank document in mind where I think about a document full with comments from various authors.

> I read through the article on navigator but am not sure how it relates to
> using navigator for spellcheck bookmarks. 

Comments have author/time + text while bookmarks have name + text - sounds more reasonable to me. The disadvantage of bookmarks as implemented today is that you do not have a list like for track changes or an inline indication as for comments. An option to solve this would be an extra section in the navigator.

(In reply to Cor Nouws from comment #7)
> Then what about spell check in Calc/Impress>

Cor's point is that the spellchecker is one dialog for all modules. There is no special Writer solution. Option 1: Cut it from Calc/Draw/Impress. Option 2: back into retreat and find a better solution. ;-)

(+ needsUX)
Comment 10 Cor Nouws 2017-01-20 18:28:51 UTC
(In reply to Heiko Tietze from comment #9)

> Cor's point is that the spellchecker is one dialog for all modules. There is
> no special Writer solution. Option 1: Cut it from Calc/Draw/Impress. Option
> 2: back into retreat and find a better solution. ;-)
Hiding a control in Impress/Calc should not be a problem, I guess.
Comment 11 shelagh.manton 2017-01-20 22:21:12 UTC
I have read through again what you have said about bookmarks and comments. I am not a person who generally uses bookmarks and didn't realise that you can name and add text to a bookmark. If this is so, even if only to name a bookmark, I agree that comments would probably be overkill.
Comment 12 Heiko Tietze 2017-01-21 09:18:54 UTC
We talked about the issue in the design session and there was another opinion that commenting is possible today, as the dialog is modal, and this feature is not needed. So we have a tie, waiting for more thoughts.
Comment 13 Olivier R. 2017-01-21 09:56:51 UTC
I have users who complain it’s difficult, when proofreading a text, to follow all mistakes, especially when some of them concern one-letter words or typographical rules. So having a way to list all mistakes in the sidebar would be a huge improvement.

I’m aware it’s not what Shelagh was asking, but both features seem related, imo. The goal is to provide a better tool for proofreaders to list/tag/follow mistakes.
Comment 14 Cor Nouws 2017-02-01 11:24:57 UTC
(In reply to Heiko Tietze from comment #12)
> ... another
> opinion that commenting is possible today, as the dialog is modal, and this
> feature is not needed.

Indeed, well noted.
For users it's much easier to click a single button to place a 'tag' (in whatever form)
Comment 15 Cor Nouws 2017-02-01 11:25:41 UTC
(In reply to Olivier R. from comment #13)
> I have users who complain it’s difficult, when proofreading a text, to
> follow all mistakes, especially when some of them concern one-letter words
> or typographical rules. So having a way to list all mistakes in the sidebar
> would be a huge improvement.

Interesting idea. Can you please make a new issue for this and link to this one?
Comment 16 Olivier R. 2017-02-01 12:08:42 UTC
(In reply to Cor Nouws from comment #15)
> Interesting idea. Can you please make a new issue for this and link to this
> one?

https://bugs.documentfoundation.org/show_bug.cgi?id=105663
Comment 17 shelagh.manton 2017-02-03 23:17:28 UTC
(In reply to Olivier R. from comment #13)
> I have users who complain it’s difficult, when proofreading a text, to
> follow all mistakes, especially when some of them concern one-letter words
> or typographical rules. So having a way to list all mistakes in the sidebar
> would be a huge improvement.
> 
> I’m aware it’s not what Shelagh was asking, but both features seem related,
> imo. The goal is to provide a better tool for proofreaders to
> list/tag/follow mistakes.

I'm not really worried about the mechanism for marking the spelling or grammar error. As long as it is easy to do and quick any solution would please me.