Description: On calc, Toolbar Layaut - Notebookbar - Contextual groups. Column dropdown doesn't work. Version: 5.3.0.2 (x64) Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16 CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; Locale: es-ES (es_ES); Calc: group Steps to Reproduce: 1.Calc 2.Toolbar Layaut - Notebookbar - Contextual groups 3.Column dropdown Actual Results: Doesn't drop down. Expected Results: Drop down like does the Row button. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Also in: Version: 5.4.0.0.alpha0+ Build ID: 2670ca3fc597decae78499d1397539668eb84e5e CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-31_05:32:46 Locale: es-ES (es_ES); Calc: CL
On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.
I created a quick patch but when testing it, no function works. I gave a try to row part, no function works too! Did I miss something?
Created attachment 130820 [details] Screnshoot row button I'm not sure if I understand what you write about Row. But row button works for me.
(In reply to m.a.riosv from comment #4) > Created attachment 130820 [details] > Screnshoot row button > > I'm not sure if I understand what you write about Row. But row button works > for me. Yes, items of row menu appear but they don't work for me. I mean "insert rows", doesn't insert row here.
You are right, for row shows the selection but does nothing. May mistake by no test.
Looks that also the Style button does nothing after selection. While others like color selection for backgroun or letter color, and border works properly.
Also with calc, fails: - format as currency - conditional format On write, on a basic test, doesn't work: - Style (like with calc) - ~References dropdown.
Who's responsible for this new layout? We should put him/her in cc and increase importance. Indeed there are quite a bunch of things in LO which have been started and never finished (eg: macro recording). It doesn't give a good impression.
*** Bug 105842 has been marked as a duplicate of this bug. ***
The problem is that the Notebookbar uses some plain buttons (represented as GtkButton in .ui files) instead of a real toolbar buttons (via sfxlo-SidebarToolBox/sfxlo-NotebookbarToolBox), so the dropdown functionality is missing. Instead there are some menus defined directly in the .ui files, but they are not backed by any code. I have a patch that makes those .ui dropdown menus work, but I wonder whether those GtkButton really meant to be used for the long-term, or maybe there are plans to eventually convert them to sfxlo-SidebarToolBox/sfxlo-NotebookbarToolBox/sfxlo-BigToolBox/whatever else (in which case I shouldn't waste my time on fixing them)? Heiko/Jay: Hi, can you clarify the situation please?
(In reply to Maxim Monastirsky from comment #11) > The problem is that the Notebookbar uses some plain buttons (represented as > GtkButton in .ui files) instead of a real toolbar buttons (via > sfxlo-SidebarToolBox/sfxlo-NotebookbarToolBox), so the dropdown > functionality is missing. Instead there are some menus defined directly in > the .ui files, but they are not backed by any code. > > I have a patch that makes those .ui dropdown menus work, but I wonder > whether those GtkButton really meant to be used for the long-term, or maybe > there are plans to eventually convert them to > sfxlo-SidebarToolBox/sfxlo-NotebookbarToolBox/sfxlo-BigToolBox/whatever else > (in which case I shouldn't waste my time on fixing them)? > > Heiko/Jay: Hi, can you clarify the situation please? Yes where a number of problems with the heikobar that i wasnt able to overcome, and no devs offered any assistance like 1. Group button with a label - check insert table 2. Button without a label - check increase font size (used a ' ' label as a workaround) 3. Uno commands in newly created group dropdown buttons - check the style drop down So please do make any changes that will make it work and look better.
(In reply to Yousuf Philips (jay) from comment #12) > 1. Group button with a label - check insert table Do you mean respecting the toolbar_style=both-horiz property found already in the .ui file? This can be easily done. > 2. Button without a label - check increase font size (used a ' ' label as a > workaround) Will using sfxlo-NotebookbarToolBox instead of GtkButton a valid solution in this case, or we need to make it work with GtkButton too? > 3. Uno commands in newly created group dropdown buttons - check the style > drop down Yeah, I have it working already. > So please do make any changes that will make it work and look better. Thanks Jay, I'm taking the bug.
I wouldn't put too much effort in this configuration since the Notebookbar is likely to undergo heavy changes. It's an experimental feature and the contextual group thing is a proof of concept for me, obviously lacking on many functions. While you may be able to improve the gtkbuttons there are also commands that are not implemented yet such as styles for images. However your patches are always welcome.
(In reply to Maxim Monastirsky from comment #13) > Do you mean respecting the toolbar_style=both-horiz property found already > in the .ui file? This can be easily done. Yes the various toolbar styles attributes werent being respected, so please do fix this. > Will using sfxlo-NotebookbarToolBox instead of GtkButton a valid solution in > this case, or we need to make it work with GtkButton too? If that would solve the issue, i'm fine with it as long as it looks the same. I believe one of the problems that GtkButton solved was that i could set the width and height of a button. > Yeah, I have it working already. Sweet (In reply to m.a.riosv from comment #0) > Steps to Reproduce: > 1.Calc > 2.Toolbar Layaut - Notebookbar - Contextual groups > 3.Column dropdown I didnt fill the column drop down with entries, as the row drop down entries werent functional. :D Once Maxim fixes the issue, it will be simple to fill the column dropdown.
Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=54d5b1828ec73d0475e0ddb6e31394a7e1904a1b tdf#105672 framework managed menu button It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This commit fixes only a few buttons in Calc (row, column, cond. formatting, styles). Other buttons can be easily fixed in .ui files. The new svtlo-ManagedMenuButton has two modes: 1) Has a menu associated inside the .ui file -> if menu items have proper .uno commands they should work. 2) No associated menu but the button itself has .uno command -> it will use the menu that registered for this command in officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu (under the PopupMenu section). In the meantime I will look into improving the toolbar-based buttons. If everything goes well, I'll try to replace all GtkButtons with toolbars, and see how well it works/looks.
With calc seems all work now, in writer without a deep analysis only 'References' doesn't work. Version: 5.4.0.0.alpha0+ Build ID: 1d810b69a584fc33f4178c7012f68f551ba2e03b CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-02-12_23:34:02 Locale: es-ES (es_ES); Calc: CL
Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cdf4b2bba8d694299c784f46fe3ecef2ce41171e Related: tdf#105672 Load toolbar properties from .ui It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 106298 has been marked as a duplicate of this bug. ***
Hello, Is this bug fixed? If so, could you please close it as RESOLVED FIXED?
(In reply to Maxim Monastirsky from comment #18) > This commit fixes only a few buttons in Calc (row, column, cond. formatting, > styles). Other buttons can be easily fixed in .ui files. Thanks for the fix Maxim. I've done the same with Writer. https://gerrit.libreoffice.org/36518
Maxim Monastirsky thanks a lot. awesome work
Can the drop down arrow be changed to the same size than the other icons has. E.g. paste, open, ...
Created attachment 132613 [details] different arrow style Open, Save, Undo, Redo is a GtkMenuToolButton in an sfxlo-NotebookbarToolBox File, Edit, is the new svtlo-ManagedMenuButton and the arrow size shouldn't be different (I prefere the arrow size of sfxlo-NotebookbarToolBox) should I make a ne bug report? Thanks
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f5baab8498ce1303dded8aa7e16adbf80341c39 tdf#105672 Heikobar: Fix style and links group buttons It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.