For at least a couple of LibreOffice versions checking for updates shows no updates even though it should. Consider this:
curl -A "LibreOffice 18.104.22.168 (7074905676c47b82bbcfbea1aeefc84afe1c50e1; MacOSX; X86_64; )" "http://update.libreoffice.org/check.php?pkgfmt=dmg"
HTTP OK / 200
<p>No update for your LibreOffice version.</p>
curl -A "LibreOffice 22.214.171.124 (7074905676c47b82bbcfbea1aeefc84afe1c50e1; MacOSX; X86_64; CPU Threads: 4; OS Version: Mac OS X 10.12.3; UI Render: default; Layout Engine: new; )" "http://update.libreoffice.org/check.php?pkgfmt=dmg"
HTTP OK / 200
<p><b>Error:</b> Only LibreOffice can access the update service.</p>
This leads to some installations not showing any updates.
The root cause seems to be that an unknown response is considered equal to "no update". This should rather generate an error such that a user can check on the website manually.
I haven't found the code repository for update.libreoffice.org so I'm not able to write a patch myself. If someone points me there, I'd be happy to have a look.
Steps to Reproduce:
1. Go to the settings.
2. Go to "LibreOffice" -> "Online Update"
3. Check "Send OS version and basic hardware information"
4. Click on the "Check Now" button.
"No Updates available" is shown, even if there should be some.
If you capture the traffic, you'll see that an error "Only LibreOffice can access the update service." is shown.
"Update available" or "Problem contacting the server" should be shown.
User Profile Reset: Yes
It would be nice if http://update.libreoffice.org/check.php would respond with a 403 forbidden code upon navigating there with a browser.
Why not use JSON instead of parsing a HTML page?
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0
*** This bug has been marked as a duplicate of bug 80110 ***
I'd argue that this is a separate issue rather than a duplicate. I think I may have explained that poorly.
The core issue is, that if "Send OS version and basic hardware information" is checked, the PHP script does not recognize LibreOffice and responds with a error message instead of responding with whether an update is available or not.
I'm all for reasoned argument :-) Confirming and setting as new.
Adding cloph to CC, as I think this is his area, and more likely to be able to point you in the right direction - if I'm wrong, sorry in advance.
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword
Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
This is still present
The checkbox to send extra information is not the default, but it is a pretty serious bug if people are kept on old versions because the update check fails. With that in mind I'm increasing the severity
The server script has not been changed so the bug still exists (check.php).
If someone could point me to the source code of http://update.libreoffice.org/check.php I could try to fix it.
(In reply to Georg Schölly from comment #8)
> The server script has not been changed so the bug still exists (check.php).
> If someone could point me to the source code of
> http://update.libreoffice.org/check.php I could try to fix it.
Looks like it's here: https://cgit.freedesktop.org/libreoffice/website/tree/check.php?h=update
Summary with repo address: https://cgit.freedesktop.org/libreoffice/website/?h=update
Weird that it is not found in the gerrit project list.
So I guess if you have a patch suggestion, you can just attach it to this report and cloph can review it.
Created attachment 151763 [details]
band aid fix for update php
I could reproduce this on Debian.
I don't know what's "BundledLanguages" so I proposed a quick and naive band-aid:
- Test of the original pattern
if ok: keep on the treatment
if ko: test another simpler pattern without BundledLanguages part
if ok: keep on the treatment
if ko: return empty array => error message.
(I bzip2 the file because I don't know if it's ok to attach a php file)
Setting OS to all as per previous comment with the fix