Bug 105783 - FILEOPEN XLS Boolean values not recognized as boolean
Summary: FILEOPEN XLS Boolean values not recognized as boolean
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 03:48 UTC by SheetJS
Modified: 2017-10-22 09:13 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
XLS file with BoolErr record that LO is incorrectly handling (209 bytes, application/vnd.ms-excel)
2017-02-06 03:49 UTC, SheetJS 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description SheetJS 2017-02-06 03:48:11 UTC 
Description:
Booleans in XLS files (BoolErr records) are treated as numbers rather than Boolean values

Steps to Reproduce:
Open a file with a BoolErr record and no format.

Actual Results:  
Boolean values are drawn as 0 and 1

Expected Results:
They should be drawn as FALSE and TRUE


Reproducible: Always

User Profile Reset: Yes (n/a)

Additional Info:
Sample offending file attached


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36
Comment 1 SheetJS 2017-02-06 03:49:15 UTC 
Created attachment 130929 [details]
XLS file with BoolErr record that LO is incorrectly handling
Comment 2 MM 2017-02-06 21:35:29 UTC 
Looks like bug 86456, bug 81350 and/or bug 83779.
Comment 3 SheetJS 2017-02-07 01:05:47 UTC 
(In reply to MM from comment #2)
> Looks like bug 86456, bug 81350 and/or bug 83779.

The first two bugs pertain specifically to XLSX, but https://bugs.documentfoundation.org/show_bug.cgi?id=83779#c1 suggests the real problem is in calc core:

> Calc does not have a distinct boolean type, whereas Excel does and expects it and does not convert numeric type to boolean type.

Should we make a new issue?
Comment 4 Xisco Faulí 2017-02-07 09:16:54 UTC 
This is not an issue.
Select all of the cells, then Format | Cells. Numbers tab | Category = Boolean Value and OK and you will see the boolean values.
Closing as RESOLVED NOTABUG
Comment 5 MM 2017-02-07 18:46:07 UTC 
(In reply to Xisco Faulí from comment #4)
> This is not an issue.
> Select all of the cells, then Format | Cells. Numbers tab | Category =
> Boolean Value and OK and you will see the boolean values.

Well, if you then save as xls (or xslx) and reload, the boolean values are changed again.