Bug 105962 - Assertion failed when Impress is started with Notebookbar enabled
Summary: Assertion failed when Impress is started with Notebookbar enabled
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+
Hardware: All All
: medium major
Assignee: Not Assigned
URL:
Whiteboard: target:5.4.0
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks: Notebookbar Crash-Assert
  Show dependency treegraph
 
Reported: 2017-02-12 16:49 UTC by Aron Budea
Modified: 2017-03-01 17:35 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
bt with debug symbols (22.44 KB, text/plain)
2017-02-12 21:56 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2017-02-12 16:49:39 UTC
Happens right upon startup. Requires debug build.
This is the relevant part of the assertion failed message:

include/vcl/builder.hxx:405: T* VclBuilder::get(VclPtr<T1>&, const rtl::OString&) [with T = FixedText]: Assertion `w' failed.

Version: 5.4.0.0.alpha0+
Build ID: 6d450aad0a8f82ee0320ffc3e76eefb43c16addb
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Julien Nabet 2017-02-12 21:56:49 UTC
Created attachment 131157 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today (+enable-dbgutil + gtk3), I could reproduce this.
Comment 2 Julien Nabet 2017-02-12 22:00:59 UTC
Delay elements are lacking in customanimationspanelhorizontal.ui
Comment 3 Julien Nabet 2017-02-12 22:05:59 UTC
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=76acb8ab5f302d1dc3a33ac8c13e5e8fd7b6c7a5

Akshay: thought you might be interested in this one.

(Notebarbook can be used when enabling experimental options in LO)
Comment 4 Akshay Deep 2017-02-12 22:18:00 UTC
(In reply to Julien Nabet from comment #3)
> Regression from
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=76acb8ab5f302d1dc3a33ac8c13e5e8fd7b6c7a5
> 
> Akshay: thought you might be interested in this one.
> 
> (Notebarbook can be used when enabling experimental options in LO)

Ohh.. notebookbar designers can give me an UI Idea to add this control. For the time being, I'll create a patch to remove this error as soon as possible.
Comment 5 Aron Budea 2017-02-13 01:19:33 UTC
(In reply to Akshay Deep from comment #4)
> Ohh.. notebookbar designers can give me an UI Idea to add this control. For
> the time being, I'll create a patch to remove this error as soon as possible.

Akshay, Julien, thanks to both of you for the quick action.

Let's add jay here: please give input on where to add the same feature what bug 98034 was about to Notebookbar.
Comment 6 Commit Notification 2017-02-14 21:16:37 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b192a8714935294b8e68b71954837404b57fa60d

tdf#105962: added missing controls to avoid crash in impress

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.