Created attachment 131437 [details] Screenshot of the document in LO 5.2.3 and Excel 2013 side by side Attached documents have some custom styles with centered and right alignment, and child styles that are supposed to inherit these alignment settings. If the document is saved to odt (also in doc and rtf) this works: the child styles have the paragraph alignment settings of their parents. If the document is saved to docx and opened in LO then this does not work in LO 5.2.3: the child styles have the default Left alignment. Interestingly the problem does not occur in Word 2013: the alignment settings are inherited and displayed correctly.
Created attachment 131438 [details] Test document with alignment settings inherited from parent style
Created attachment 131439 [details] The document exported to docx format
Created attachment 131440 [details] The same document saved in doc
Created attachment 131441 [details] The document exported to rtf format Even this works :)
Regression introduced in range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=d7867b28623e4220f62b8ed9259bed5d8878a3b3..d00e0bcd60304835f5c10a71b22b6a4f483dd6ec
f2e68c240c286653a944401b117756b3f8e89a71 is the first bad commit commit f2e68c240c286653a944401b117756b3f8e89a71 Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Sep 5 23:01:58 2015 +0800 source-hash-84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837 commit 84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837 Author: Faisal M. Al-Otaibi <fmalotaibi@kacst.edu.sa> AuthorDate: Fri Nov 15 18:09:21 2013 +0300 Commit: Faisal M. Al-Otaibi <fmalotaibi@kacst.edu.sa> CommitDate: Fri Nov 15 18:16:36 2013 +0300 DOCX:fdo#71646 fix wrong direction when save the file. Change-Id: I6f3dcf1007e91551e1f3335f4c40424add1c45c3 # bad: [6ae1bee52feeb4b006fb472cd3a073902d3d2c1a] source-hash-d00e0bcd60304835f5c10a71b22b6a4f483dd6ec # good: [47243472f676e7bd3c4bc3732a57be69d5371447] source-hash-d7867b28623e4220f62b8ed9259bed5d8878a3b3 git bisect start '6ae1bee52feeb4b006fb472cd3a073902d3d2c1a' '47243472f676e7bd3c4bc3732a57be69d5371447' # bad: [e1240a17572838c4aa9b53b92c51d3f65705ca65] source-hash-b8a4abdda4e6a95535992c26a906226ede7f050a git bisect bad e1240a17572838c4aa9b53b92c51d3f65705ca65 # bad: [c4c07bb40b76318048298abc8f826dbe837d5a2d] source-hash-3ea4d26865c645fa76ea77bb94f084b2a435e20a git bisect bad c4c07bb40b76318048298abc8f826dbe837d5a2d # good: [b9fadd8d3b9371c753e1fd7be02e6d72aa8315f0] source-hash-6abfb890a2fad1931a79d53018f932205a668264 git bisect good b9fadd8d3b9371c753e1fd7be02e6d72aa8315f0 # bad: [01c62e8bda11becc51550f17d339c368a8f95f2f] source-hash-8b853bde21ca26a44207f791d9ef8f07f1202f6a git bisect bad 01c62e8bda11becc51550f17d339c368a8f95f2f # good: [1f932d7e1981ec10922465e0c4f7ed83855d03fa] source-hash-2dec3d1d4f3e91ce005bb3b5362b826e7c7590c8 git bisect good 1f932d7e1981ec10922465e0c4f7ed83855d03fa # good: [5c734aba6b3554be6e9760d143de5801aab6732f] source-hash-13d36ad94937fa278690a5cc5287e8997aecb10f git bisect good 5c734aba6b3554be6e9760d143de5801aab6732f # good: [29f53505ee34f1dad8456e2dcf1666ae2a8fcd59] source-hash-9389cf78e304a5a99bcf1745b9388e14ac36281a git bisect good 29f53505ee34f1dad8456e2dcf1666ae2a8fcd59 # bad: [f2e68c240c286653a944401b117756b3f8e89a71] source-hash-84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837 git bisect bad f2e68c240c286653a944401b117756b3f8e89a71 # first bad commit: [f2e68c240c286653a944401b117756b3f8e89a71] source-hash-84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837
This bug started with the comment referenced below. I assume there's no point in CC-ing anyone from KACST. https://cgit.freedesktop.org/libreoffice/core/commit/?id=84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837 author Faisal M. Al-Otaibi <fmalotaibi@kacst.edu.sa> 2013-11-15 15:09:21 (GMT) committer Faisal M. Al-Otaibi <fmalotaibi@kacst.edu.sa> 2013-11-15 15:16:36 (GMT) "DOCX:fdo#71646 fix wrong direction when save the file."
In the exported files the difference is in styles.xml. The one that is imported incorrectly has this attribute for center/right aligned paragraph styles (two of each): <w:bidi w:val="0"/>
Piece of code from import: rContext->Insert(PROP_WRITING_MODE, uno::makeAny( text::WritingMode2::LR_TB )); rContext->Insert(PROP_PARA_ADJUST, uno::makeAny( style::ParagraphAdjust_LEFT ), /*bOverwrite=*/false); http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/DomainMapper.cxx#1453 I wonder if this piece of code is what is causing the bug, or later where the value of PROP_PARA_ADJUST is considered instead of what is inherited from the style. Then the other question is whether bidi attribute should actually be written in the OOXML in this case, even if it's set to 0 (false).
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Created attachment 143142 [details] Screenshot in current 6.2 master and Word 2010 Still no inheritance of alignment.
code pointer: writerfilter/source/dmapper/DomainMapper.cxx case NS_ooxml::LN_CT_PPrBase_bidi:
Proposed fix: https://gerrit.libreoffice.org/57195 related tdf#106174 writerfilter: replace broken FindParentStyleSheet https://gerrit.libreoffice.org/57196 tdf#106174 writerfilter: bidi - only if different from style
Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bc67bda7363df48f1983513a8e969b61738139f5 related tdf#106174 writerfilter: replace broken FindParentStyleSheet It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d3ecf6070b439e902343a2a83bc9384382e41fee&h=libreoffice-6-1 related tdf#106174 writerfilter: replace broken FindParentStyleSheet It will be available in 6.1.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9fc9510ae3f46e5c1fd65303bac9f01ddc79cb5c tdf#106174 writerfilter: bidi - prev adjust? prev bidi? It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Not backporting - too many other connected dependencies for a complex and error-prone area.
Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=85818da3307a28b2d9c6fa5c1c97ca7833dfe24c tdf#106174 ww8import: bidi - prev adjust? prev bidi? It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/931cb1caf26a09d7152360407e1f163fc3fab1c2%5E%21 Revert "tdf#106174 ww8import: bidi - prev adjust? prev bidi?" It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Leaving this bug marked as fixed, but .doc is now fixed only in master (6.3) because it caused a bad regression in bug 121110. Because I am really struggling to create a clean fix for the regression, I don't want to backport any future fix for bug 121110 to 6.2. So, I'm just eliminating the problem from 6.2 and delaying it until 6.3.
Nice to see this post here. PerYourHealth is online bill pay portal which allows users to pay their hospital bills while sitting at home. peryourhealth is a secure way to pay medical bills online. https://peryourhealth.ninja
Kroger nice individuals or individuals square measure nice is associate worker login portal for all the associates of the Kroger. greatpeople.me is the official website by Kroger for its employee. Employees can use Greatpeople.me login to check their Schedule & Feed. https://krogerfeedback.ninja/greatpeople-me/