If you have a large index or ToC and update it, the view jumps to the beginning
of the index.
This is annoying if you have a large index and you want to monitor a change after update - you can't see the update process and what changed live because the view changes.
Expected result: Retain the view position after updating an index.
Tested with LibO 184.108.40.206
Build ID: 1:5.3.0~rc3-0ubuntu1~trusty1.1
CPU Threads: 2; OS Version: Linux 3.13; UI Render: default; VCL: gtk2; Layout Engine: new;
Locale: de-AT (de_DE.UTF-8); Calc: group
Also tested with LibO 220.127.116.11 on Windows 8.
It's an old bug that also existed in OpenOffice.org.
Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive information before attaching it.
See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.)
Created attachment 131753 [details]
File with long ToC to test the jump issue
Steps to reproduce:
1. Open the attached Writer document.
2. Scroll down to the end of ToC at the first page.
3. Right-click at ToC and choose "Update Index" in the context menu.
The document canvas view jumps up to the beginning of the ToC. You can't see what changed at the bottom part of the ToC during update. (Real world use case: My detailed ToC in a master document fills 4 A4 pages.)
The document canvas view shouldn't change when updating a ToC. It's not clear to as user like me why that happens.
Adding 'needsUXEval' to see whether it's the expected behaviour or not...
The issue is similar to bug 41063 (and maybe to bug 95797 where kendy solved a regression).
I don't see any reason to change the cursor position on save. At least from the user POV it must stick to the current place. Stuart added some more situations, i.e. auto save and restore edit view as well as reopen that has to be considered.
PS: Haven't tested the issue myself, so keep UNCONFIRMED.
Let's move it to NEW then, as the behaviour should be consistent throughout the application.
Just FYI I collected some jump issues in the wiki: https://wiki.documentfoundation.org/User:Lendo/Usability#Annoying_Jump_Issues
(In reply to Thomas Lendo from comment #6)
> Just FYI I collected some jump issues in the wiki:
Great overview. Put that into a meta ticket so all Bugzilla fellows can add issues in case you missed some. It also helps to interlink tickets.
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword
Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
Still reproducible in Version: 18.104.22.168.alpha0+ (x64)
Build ID: 8e0eb015e74775b9bf02326ffd7b67e83ad6c60d
CPU threads: 8; OS: Windows 10.0; UI render: GL;
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-03_03:53:38
Locale: de-AT (de_AT); Calc: CL
This one is easy to change, just
> case FN_UPDATE_CUR_TOX:
> const SwTOXBase* pBase = m_pWrtShell->GetCurTOX();
>+ const bool bWasLocked = m_pWrtShell->IsViewLocked();
> if(TOX_INDEX == pBase->GetType())
> m_pWrtShell->UpdateTableOf( *pBase );
>+ if (!bWasLocked)
to void SwView::Execute(SfxRequest &rReq) in C:\lo\core\sw\source\uibase\uiview\view2.cxx. Note though, that the update not only jumps the view; it also moves the cursor position to the position just before the index field (which is natural: the cursor is placed inside the field, e.g. by right-clicking; the content of the field is regenerated - i.e., it is destroyed and recreated again; so the position is lost in the process; and the content of the field might be very different after the update). So is the change consistent from UX PoV?
(In reply to Mike Kaganski from comment #10)
> So is the change consistent from UX PoV?
Sounds acceptable. With all your tips it's definitely an easy hack, or will you submit the patch yourself?
(In reply to Heiko Tietze from comment #11)
> With all your tips it's definitely an easy hack, or will
> you submit the patch yourself?
Sigh... I didn't think about that; to be easy-hack, I shouldn't have posted the patch itself. Sorry :) - will post the patch myself then.
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":
tdf#106374: lock view when updating index
It will be available in 6.2.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Mike, thank you for your patch!
Verified on Version: 22.214.171.124.alpha0+ (x64)
Build ID: e46f8a9a4e3c5b0542c0813b476b449f3af8d607
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win;
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-07_23:36:50
Locale: de-AT (de_AT); Calc: CL