Bug 106698 - Certain buttons only appear/are enabled in active window's sidebar
Summary: Certain buttons only appear/are enabled in active window's sidebar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) release
Hardware: All All
: low trivial
Assignee: Not Assigned
Keywords: bibisected, bisected, regression
: 117251 (view as bug list)
Depends on:
Blocks: Sidebar-Properties Multi-Window
  Show dependency treegraph
Reported: 2017-03-22 13:32 UTC by Aron Budea
Modified: 2023-04-24 03:24 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Screenshot (42.30 KB, image/png)
2017-03-22 13:32 UTC, Aron Budea

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2017-03-22 13:32:39 UTC
Created attachment 132072 [details]

Open two Writer windows, have Properties sidebar enabled and put them side-by-side.
Note how Highlight Color selector is missing and Set Character Spacing is not enabled in the inactive window, and reappers when it's active.

Reproduced in and / Windows 7.
Not reproduced in => regression
Comment 1 Maxim Monastirsky 2017-03-22 21:56:52 UTC
Some more observation:

- In Writer, if the cursor is in a text box or a table, there will be changes in the paragraph sidebar panel. (This one can be reproduced with too.)

- In Calc, if the cursor is in a text box, the Style sidebar panel will appear.

- In Writer with notebookbar enabled, if the cursor is in a table, the notebookbar will turn blank.

All this stops after commenting the ContextChangeBroadcaster::Deactivate method [1]. Obviously the various sidebar/notebookbar panels were not prepared to handle this vcl::EnumContext::Context::Default notification. IMHO the usefulness of considering a "window lose focus" event as an application context change is questionable, as well as the vcl::EnumContext::Context::Default purpose in a whole.

[1] http://opengrok.libreoffice.org/xref/core/sfx2/source/sidebar/ContextChangeBroadcaster.cxx#54
Comment 2 Aron Budea 2017-04-19 03:44:27 UTC
Bibisected the first issue down to the following commit using repo bibisect-43max.

commit d9b101f0670ac0cd1ec41c51ad4d6a5d71dd0271
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Thu May 28 18:46:30 2015 +0800

    commit bc46764f12947cbe8d46e03450f181d449c020f4
    Author:     Maxim Monastirsky <momonasmon@gmail.com>
    AuthorDate: Mon Jan 27 13:58:41 2014 +0200
    Commit:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Thu Jan 30 11:56:01 2014 +0000
        Sidebar Text panel cleanup
        Change-Id: I6cbf5a9e5ad9d61df2abbcc835ba60d45768deeb
        Reviewed-on: https://gerrit.libreoffice.org/7687
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
Comment 3 QA Administrators 2018-04-20 02:33:53 UTC Comment hidden (obsolete)
Comment 4 Xisco Faulí 2018-06-05 19:31:05 UTC
Adding Cc: to Maxim Monastirsky
Comment 5 Xisco Faulí 2018-10-18 11:24:27 UTC
*** Bug 117251 has been marked as a duplicate of this bug. ***
Comment 6 QA Administrators 2019-10-19 02:42:35 UTC Comment hidden (obsolete)
Comment 7 Aron Budea 2020-07-29 12:30:08 UTC
Still in LO (abea0d6647c7f1f7e76c73c26cb80e6a67dc5111).
Comment 8 QA Administrators 2023-04-24 03:24:31 UTC
Dear Aron Budea,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team