Bug 106698 - Certain buttons only appear/are enabled in active window's sidebar
Summary: Certain buttons only appear/are enabled in active window's sidebar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.3.0.4 release
Hardware: All All
: low trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 117251 (view as bug list)
Depends on:
Blocks: Sidebar-Properties Multi-Window
  Show dependency tree / graph
 
Reported: 2017-03-22 13:32 UTC by Aron Budea
Modified: 2025-04-25 04:13 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot (42.30 KB, image/png)
2017-03-22 13:32 UTC, Aron Budea 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2017-03-22 13:32:39 UTC 
Created attachment 132072 [details]
Screenshot

Open two Writer windows, have Properties sidebar enabled and put them side-by-side.
Note how Highlight Color selector is missing and Set Character Spacing is not enabled in the inactive window, and reappers when it's active.

Reproduced in 5.3.1.2 and 4.3.0.4 / Windows 7.
Not reproduced in 4.2.0.4. => regression
Comment 1 Maxim Monastirsky 2017-03-22 21:56:52 UTC 
Some more observation:

- In Writer, if the cursor is in a text box or a table, there will be changes in the paragraph sidebar panel. (This one can be reproduced with 4.2.0.4 too.)

- In Calc, if the cursor is in a text box, the Style sidebar panel will appear.

- In Writer with notebookbar enabled, if the cursor is in a table, the notebookbar will turn blank.

All this stops after commenting the ContextChangeBroadcaster::Deactivate method [1]. Obviously the various sidebar/notebookbar panels were not prepared to handle this vcl::EnumContext::Context::Default notification. IMHO the usefulness of considering a "window lose focus" event as an application context change is questionable, as well as the vcl::EnumContext::Context::Default purpose in a whole.

[1] http://opengrok.libreoffice.org/xref/core/sfx2/source/sidebar/ContextChangeBroadcaster.cxx#54
Comment 2 Aron Budea 2017-04-19 03:44:27 UTC 
Bibisected the first issue down to the following commit using repo bibisect-43max.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=bc46764f12947cbe8d46e03450f181d449c020f4
commit d9b101f0670ac0cd1ec41c51ad4d6a5d71dd0271
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Thu May 28 18:46:30 2015 +0800

    source-hash-bc46764f12947cbe8d46e03450f181d449c020f4
    
    commit bc46764f12947cbe8d46e03450f181d449c020f4
    Author:     Maxim Monastirsky <momonasmon@gmail.com>
    AuthorDate: Mon Jan 27 13:58:41 2014 +0200
    Commit:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Thu Jan 30 11:56:01 2014 +0000
    
        Sidebar Text panel cleanup
    
        Change-Id: I6cbf5a9e5ad9d61df2abbcc835ba60d45768deeb
        Reviewed-on: https://gerrit.libreoffice.org/7687
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
Comment 3 QA Administrators 2018-04-20 02:33:53 UTC Comment hidden (obsolete)
Comment 4 Xisco Faulí 2018-06-05 19:31:05 UTC 
Adding Cc: to Maxim Monastirsky
Comment 5 Xisco Faulí 2018-10-18 11:24:27 UTC 
*** Bug 117251 has been marked as a duplicate of this bug. ***
Comment 6 QA Administrators 2019-10-19 02:42:35 UTC Comment hidden (obsolete)
Comment 7 Aron Budea 2020-07-29 12:30:08 UTC 
Still in LO 7.1.0.0.alpha0+ (abea0d6647c7f1f7e76c73c26cb80e6a67dc5111).
Comment 8 QA Administrators 2023-04-24 03:24:31 UTC Comment hidden (obsolete)
Comment 9 QA Administrators 2025-04-24 03:13:00 UTC Comment hidden (obsolete)
Comment 10 Aron Budea 2025-04-25 04:13:13 UTC 
Still in LO 25.8.0.0.alpha0+ (736998ccef0bacdd2bbf038c98dacfbe654f1a4d) / Windows.