msiexec /i %1 /quiet /norestart /log "%LOG%" ^
UI_LANGS=en_US,ru REGISTER_ALL_MSO_TYPES=1 ISCHECKFORPRODUCTUPDATES=0 RebootYesNo=No QUICKSTART=0 ADDLOCAL=ALL ^
This script works perfect with LibO 5.2
But ALL languages are installed with 5.3 branch
Tested with 188.8.131.52, 184.108.40.206, 220.127.116.11
See this: https://lists.freedesktop.org/archives/libreoffice/2017-April/077536.html
*** Bug 108646 has been marked as a duplicate of this bug. ***
UI_LANGS used to work in 5.2.
That is, it installed the UI languages and spelling dictionaries only for the given languages.
It is possible to list all dictionaries to remove but that's just an inconvenient workaround that does not affect UI languages.
Ok, I pinged Jürgen F. on -dev, but he was unable to comment. Let's set to NEW and see what happens.
The parameter "UI_LANGS" can i not find in the LO-msi (5.2.8) and not in the msi-spec (https://msdn.microsoft.com/en-us/library/windows/desktop/aa370905(v=vs.85).aspx)
and look to: https://lists.freedesktop.org/archives/libreoffice/2017-April/077529.html
But i think what should work is ADDLOCAL=gm_Langpack_r_it,g_Langpack_r_ru,.. or REMOVE=... (but not tested)
In this relationship exist a patch in 5.3 0a76a41ae7a2ebd53f80f01ea9e2bcff3026d155, this need the ADDLOCAL=.. switch to overroll the CustomAction "SelectLanguage" tdf#100929.
(In reply to Juergen Funk (CIB) from comment #5)
> The parameter "UI_LANGS" can i not find in the LO-msi (5.2.8)
It is handled here:
There were some changes to that code since 5.2, that might / probably had this unfortunate side effect:
I don't have a Windows-based build system, so I can't help narrowing this further down.
Hi Gabor Kelemen,
after the written of my comments, to come to mind i have forget search in the code. And that is the problem in LO 5.3.
In the patch (look to my above comment) disable this CostumAction (SelectLaguage) off when ADDLOCAL is set, and that is the problem.
But i have a solution for that, and made a patch for that.
But my time is very small for do that, the most time is the testing, i would made the patch without testing, then i can made the patch quickly, or asap.
Here is the patch https://gerrit.libreoffice.org/39379, without testing
I have upload the
Here the Build-Parameter:
--with-lang=de fr es it pt
Can anyone test this, when okay can remove the -1 from https://gerrit.libreoffice.org/39379
hope it is okay
Created attachment 134807 [details]
Screenshot of the test installer
Thanks for the patch, I gave it a try.
Looks like it works mostly, of the three languages set, de and it are selected. But not en-US.
it looks good, for the english the right acronym is "en" you can see here https://opengrok.libreoffice.org/xref/core/setup_native/source/win32/customactions/sellang/sellang.cxx#78
I think my patch work my fix call only the CostumAction "SelectLaguage" and that works now, but the code of the SelectLaguage I have not touch.
Okay, my patch can be review, thank you for you testing.
(In reply to Juergen Funk (CIB) from comment #11)
> Hi Gabor,
> it looks good, for the english the right acronym is "en" you can see here
In this case it was my bad - en_US works in the example file you provided.
(where did I got en-US? :()
I think it's okay to commit this.
Created attachment 134929 [details]
Screenshot of the test installer and the script used to launch it.
This looks to be fine now!
Juergen Funk committed a patch related to this issue.
It has been pushed to "master":
tdf#106931 - LibreOffice 5.3 installer doesn't honor UI_LANGS property
It will be available in 6.0.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
A polite ping to Juergen Funk: is this bug fixed? if so, please close it as RESOLVED FIXED
It is resoved