For OO Calc has Show Comment on/off text button that works on a single comment at the current cell. What's missing is an icon for that and that should be added. That would more come in handy for touch screen but would be useful anyway. This command is not to be confused with separate Show Comment and Hide Comment buttons that were added in LO.
(In reply to Timur from comment #0) > For OO Calc has Show Comment on/off text button that works on a single > comment at the current cell. Not so sure if the toggle behaviour show command button (.uno:NoteVisible) requires an icon be created for it, especially when its not visible by default anywhere.
in writer there is .uno:ShowAnnotations this icon I need (I link to one) an icon. is it the same than the one in calc? if it's the same, please add the functionality and I'll make the breeze icon (because I'll need it in the notebook toolbar).
Created attachment 143500 [details] customized toolbar preview in 6.2+ "Show Comments" on/off button has an icon. I can't say when it was added, but it used to be different and it looks the same now as Insert Comment. They should be different. I propose a double comment rectangle to indicate multiple comments. That's why I reopen this one. I attach a customized toolbar preview in 6.2+. Note: other commands added here to default toolbar set for test are: Show Comments (on/off, with icon) Show All Comments Hide All Comments Show (single) Comment Hide (single) Comment Show Comment (on/off) We should rename those commands with on/off behavior: "Show Comments" -> "Show/Hide Comments" "Show Comment" -> "Show/Hide Comment"
This was marked Fixed without explanation. But it's not fixed, as I explain further. I also expand this bug scope. "Show Comment" on/off button is still a text only, need an icon. "Show Comments" on/off button (which is different) has an icon. I can't say when it was added, but it used to be different and it looks the same now as Insert Comment. They should be different. I propose a double comment rectangle to indicate multiple comments. We should rename those commands with on/off behavior to make a distinction to similar one-way commands: "Show Comments" -> "Show/Hide Comments" "Show Comment" -> "Show/Hide Comment" I attach a customized toolbar preview in 6.2+ as attachment 143500 [details]. Note: other commands added here to default toolbar set for test are: Show Comments (on/off, with icon) Show All Comments Hide All Comments Show (single) Comment Hide (single) Comment Show Comment (on/off)
when I play around with notebookbar the different commands with the naming also confuse me. I would add the bug to the weekly design meeting and than we can improve it.
We discussed this issue in the design meeting. And besides proper icon design, we should indeed support the difference between "Show comment" (of the actual cell) vs. "Show All Comments", as Timur suggests. @Andreas, do you want, additionally to the icon design, to also update the string or should I do that?
Let's bump this one in case it went aside.
I will update the icons and heiko please update the string.
Show/Hide (Single) Comment and Show/Hide All Comments is in the code #define STR_UNDO_SHOWNOTE NC_("STR_UNDO_SHOWNOTE", "Show Comment") #define STR_UNDO_HIDENOTE NC_("STR_UNDO_HIDENOTE", "Hide Comment") #define STR_UNDO_SHOWALLNOTES NC_("STR_UNDO_SHOWALLNOTES", "Show All Comments") #define STR_UNDO_HIDEALLNOTES NC_("STR_UNDO_HIDEALLNOTES", "Hide All Comments") https://opengrok.libreoffice.org/xref/core/sc/inc/globstr.hrc#103 IIUR introduced by Gulsah in https://gerrit.libreoffice.org/#/c/35020/ You can customize all those commands into the toolbar but icons are missing.
(In reply to andreas_k from comment #8) > I will update the icons and heiko please update the string. Can you do it, please?
Thanks for the topic and for the answers. Very interesting. More info here https://reviewingwriting.com/.
(In reply to Timur from comment #4) > "Show Comments" on/off button .. looks the same now as Insert Comment. I don't like Insert Comment in Colibri because it's white. I'm used to yellow Insert Comment both in Calc and Writer. I'd like it to be changes here in this bug.
https://reviewingwriting.com/
I'd like to fix this bug, but in general I don't know what was needed for which uno command. So please add the list of uno commands here and I will see how to fix the icon issue.
(In reply to andreas_k from comment #14) > So please add the list of uno commands here... .uno:ShowAllNotes, .uno:HideAllNotes additional to .uno:ShowNote and .uno:HideNote
(In reply to Timur from comment #12) > (In reply to Timur from comment #4) > > "Show Comments" on/off button .. looks the same now as Insert Comment. > I don't like Insert Comment in Colibri because it's white. > I'm used to yellow Insert Comment both in Calc and Writer. > I'd like it to be changes here in this bug. I make the colibre notes icons yellow. All icons area available in breeze, sifr, colibre.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b91a8dc8358153f6fa25a394732c946a9e1bd359%5E%21 tdf#107144 make notes icons yellow in colibre It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
should be done can someone verify.
Created attachment 151202 [details] Test ODS in LO 6.3+
Created attachment 151203 [details] customized toolbar preview in LO 6.3+ and compare to LO 6.2 There was an improvement, but I'd like 3 more changes per screenshot attached. PS Thank you for adding yellow border to "Insert Comment".
Created attachment 151204 [details] customized toolbar preview in LO 6.3+ and compare to LO 6.2
Andreas, can you please correct this for LO 6.4?
Andreas, can you please correct this for LO 6.3? If not too late.
rizmut committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/df878758fc8abb13dd9e97f2619f400a28d99d66%5E%21 Colibre: Fix for tdf#107144 & clean SVG files It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/26521429263b413169e14c9868269d36581184c1%5E%21 Colibre: Fix for tdf#107144 & clean SVG files It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 152277 [details] Updated Colibre's comment icon This is how it would like to be based on my change
rizmut committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/11a1bdc5fa0312111ddf9c1b7779a114b97e361c%5E%21 Colibre, elementary, KJ: Fix for tdf#107144 It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/38f79ddf341c35d654e6156a241ddacc5927b444%5E%21 Colibre, elementary, KJ: Fix for tdf#107144 It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/068f5f085cea4a8c87bfb6e15d3f2f74e0b0f219%5E%21 Breeze: Fix for tdf#107144 It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/7e47c20a1faf27c184454a3b07b14f27954cd245%5E%21 Breeze: Fix for tdf#107144, tdf#125879 It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Not as I suggested in attachment 151204 [details]. I have to analyze.
Created attachment 152538 [details] customized toolbar preview in LO 6.2, 6.3+ and 6.4+ There were further improvements, but it still needs some corrections.
Text icon "Show Comment" needs an icon (combination of Show Comment and Hide Comment, maybe with vertical split). Should be renamed to “Show/Hide Comment”. Icon “Comments” should have unique icon (combination of double Show Comments and Hide Comments, maybe with vertical split). Should be renamed to “Show/Hide Comments”.
rizmut committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/623ad884051ad4ea17ba7baa77076c49000e49fa%5E%21 Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233 It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rizmut committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/000305699b62a09c8d3d580b0fc8d320d9ea34f8%5E%21 Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233 It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/25b54bd58a4adacafb1e084d6fb367860a5b5350%5E%21 Revert "Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233" It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Timur, could you please confirm whether all themes are now supporting your icon request
Looking at attachment 152538 [details], there are still 2 last icons incomplete per comment 33: Icon "Show Comment" (uno:NoteVisible) should be renamed to “Show/Hide Comment” and should have unique icon (maybe with vertical split, similar but different to .uno:HideNote). Icon “Comments” (.uno:ShowAnnotations) should be renamed to “Show/Hide Comments” and have that same unique icon (with vertical split) just doubled (as is doubled now, but icon is not unique).
That is seen in LO 7.0+ from 14.02.2020., unless there were changes.
Created attachment 158104 [details] Latest Master 7.0 Custom Comment Toolbar in Colibre I think your attachment now obsolete, now every .uno:command has an icon in daily master build 7.0 Version: 7.0.0.0.alpha0+ Build ID: a545e25314d464c190d9d504d78ec6cb67ead4fd CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-02-20_15:31:00 Locale: id-ID (id_ID.UTF-8); UI-Language: en-US Calc: threaded
Yes, I know the last icon was added, but two are wrong, I don't understand why I have to repeat the same.
(In reply to Timur from comment #41) > Yes, I know the last icon was added, but two are wrong, I don't understand > why I have to repeat the same. For renaming the icon, I'm not sure I could help it.
Set to Fixed as all buttons now have icons. For renaming request, need another new bug report
I cannot test, but if it remained wrong, it shouldn't be closed. And surely no need to open new bug just to complete what's explained here.
(In reply to Timur from comment #44) > I cannot test, but if it remained wrong, it shouldn't be closed. And surely > no need to open new bug just to complete what's explained here. I tend to disagree, drawing an icon and renaming a button are two different tasks which require different of skill sets and cover different areas.
OK for separate renaming but two icons were not correct because they should be unique, not the same for different function. I explained in comment 38. Sorry I cannot retest now.
Icons are OK, thanks. Not all icons seem unique, but they are unique enough, just 2 Show/hide look the same as Show but that's acceptable. For example, I just use those Show/hide. I'll open separately for rename.