In Calc we have multiple comment icons. To be clear and distinguish show/hide from show or hide icons, two need to be renamed. Icon "Show Comment" (uno:NoteVisible) should be renamed to “Show/Hide Comment”. Icon “Comments” (.uno:ShowAnnotations) should be renamed to “Show/Hide Comments”.
How about “Show/Hide All Comments”?
The are two icons and I propose "Show/Hide Comment” and " Show/Hide Comments”. For later " Show/Hide All Comments” is acceptable, but I think All is redundant.
Had this topic in the design meeting and the more clear distinction between singular and plural is welcome. But let's have a closer look. Searching for "comment" in Calc's customization dialog returns: officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu .uno:CommentChange | Comment .uno:ShowAllNotes | Show All Comments .uno:NoteVisible | Show Comment .uno:ShowNote | Show Comment officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu .uno:InsertAnnotation | Comment (defined in CalcCommands.xcu too but with no tooltip nor accelerator key- cleaning-up sounds reasonable here) .uno:ShowAnnotations | Show Comment .uno:NoteVisible is not used in any xml/ui file, .uno:ShowNote is the command in Calc's menubar.xml, cell.xml, and pagebreak.xml. .uno:ShowAnnotations is on Calc's menubar.xml and notebookbar_groupedbar*.ui, not in the context menus. So, if at all, we have to change .uno:ShowNote. I guess your concerns is the "Show" which is actually a toggle in Calc. Using a slash is an example for bad usability, the better solution would be "Toggle Comment Visibility"- sounds somewhat bulky to me. Better we do the same as on the main menu and have a checkbox on the context menu that makes the functionality more clear. To do so we need to merge .uno:HideNote and .uno:ShowNote into one command, which is unfortunately not an easyhack anymore.
I don't know how and why it became so complicated, even I requested a simple change. "Toggle Comment" and "Toggle Comments" would do. Searching for "comment" in Calc has I think 11 entries and one must experiment to find those toggles that are most useful. When we have toggles that woek I don't understand why idea to merge separate show and hide,which I didn't ask and see no purpose.
Okay, here a shorter version of my comment * uno:NoteVisible is defined for but not used in Calc * uno:ShowNote is accomplished by uno:HideNote- both commands are visible depending on the actual comment state, visible or not * uno:ShowAnnotations affects all comments, uno:ShowNote only the current one * Using a "/" in a label is bad usability- and wrong since. * The better solution is with a checkbox (like uno:ShowAnnotations works)
Having a checkbox in the context menu won't solve the issue with the customize dialog having two "Show comment" entries (for .uno:ShowNote and .uno:NoteVisible). Only renaming (or hiding) one of the commands might solve this part (with or without a checkbox). And the label used in the customize dialog doesn't necessarily have to be the same used in the context menu. And FYI, .uno:NoteVisible already works as a checkbox, and the only reason it isn't used in the UI is that it works only with a single cell, not with a cell range (unlike .uno:ShowNote). So maybe we should just change .uno:NoteVisible, and use it instead?
(In reply to Maxim Monastirsky from comment #6) > Having a checkbox in the context menu won't solve the issue with the > customize dialog having two "Show comment" entries... Of course, we would have to merge Show and Hide into one command- likewise it's done for .uno:ShowAnnotations. > .uno:ShowNote... So maybe we should just change .uno:NoteVisible, and use it instead? Timur, what do you think about this idea?
(In reply to Heiko Tietze from comment #7) > Of course, we would have to merge Show and Hide into one command- likewise > it's done for .uno:ShowAnnotations. Sorry, but you seem to not understand the problem reported by Timur. Merging commands will *not* solve this issue at all. And .uno:ShowAnnotations can't be an example of a solution, because it actually has the same problem - as there are also non-toggle .uno:ShowAllNotes and .uno:HideAllNotes commands for show/hide all comments.
So I took a look at this request and indeed the command uno:NoteVisible (as well as its slot FID_NOTE_VISIBLE) is not really used anywhere in Calc (besides implementing itself). I was wondering if we should even have this command... maybe remove it entirely? This might be a solution, since its functionality is already covered by other commands. And I could not find anything in the code that relies on this command. The only use case for this command is maybe for macros/scripts. If we decide to keep the uno:NoteVisible command, we could simply rename it to something else as "Show Comment in Cell". I know its a bit long, but its not used in the UI by default anyways, so no one will complain.