Bug 161972 - Inserting new comment in Calc disables the "show all comments" setting
Summary: Inserting new comment in Calc disables the "show all comments" setting
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2024-07-09 15:01 UTC by Gabor Kelemen (allotropia)
Modified: 2024-09-06 07:55 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Simple example file from Calc (8.11 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-07-09 15:01 UTC, Gabor Kelemen (allotropia)
Details
View - Comments is enabled before inserting a new one (64.52 KB, image/png)
2024-07-09 15:02 UTC, Gabor Kelemen (allotropia)
Details
View - Comments is disabled after inserting a new comment which is also hidden (58.22 KB, image/png)
2024-07-09 15:03 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-07-09 15:01:48 UTC
Created attachment 195188 [details]
Simple example file from Calc

If the View - Comments setting is enabled and all comments are shown, inserting a new comment disables this setting and is hidden, while the other comments are still visible.

1. Open attached file
2. Enable View - Comments. 2 comments become visible and this menu item is seen toggled in the View menu
3. Insert a new comment 
-> this one becomes hidden and the View - Comments item becomes default state.

It would be more consistent to change the behavior so that new comments are visible just like old ones when the View - Comments is enabled and inserting a comment does not disable it.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2afdc61dd3138b383fb73dae2242ba1a9c8de901
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Behavior is like this since 5.4 when View - Comments was added.
Comment 1 Gabor Kelemen (allotropia) 2024-07-09 15:02:50 UTC
Created attachment 195189 [details]
View - Comments is enabled before inserting a new one
Comment 2 Gabor Kelemen (allotropia) 2024-07-09 15:03:39 UTC
Created attachment 195190 [details]
View - Comments is disabled after inserting a new comment which is also hidden
Comment 3 ady 2024-07-09 15:42:30 UTC
(In reply to Gabor Kelemen (allotropia) from comment #0)

> It would be more consistent to change the behavior so that new comments are
> visible just like old ones when the View - Comments is enabled and inserting
> a comment does not disable it.

The View > Comments menu entry is working as an applied action, not so much as a toggle status for every comment, (and I'm fine with it).

Only when all the comments are unhidden, the menu entry is shown as ON, but that "status" can also be achieved by selecting the range of cells with comments and choosing to show comments by means of the cell's context menu.

IIUC, the property to show/hide a comment is saved on each comment/cell, not as a whole on the document – I could be wrong.

For instance, you can have many comments set to Show already, and you might want to add several new comments but you want them to remain hidden. Unhiding all the new comments is easy with the current workflow, but having to hide each new comment is an extra unneeded work, even when selecting multiple cells.

For each case, there are pros and cons.

FWIW, I am not convinced that changing the current behavior is for the better.
Comment 4 Heiko Tietze 2024-08-26 13:37:58 UTC
The command is disabled while editing a comment. Meaning it becomes available once you finished to add a new comment.

What remains is the fact that View > Comments is not a toggle. I can follow Ady's comment 3 in this regard. You too, Gabor?
Comment 5 Heiko Tietze 2024-09-06 07:55:10 UTC
The topic was on the agenda of the design meeting but received no further comments. Resolving NAB following comment 3.