Bug Hunting Session
Bug 107381 - Default cell style colors shouldnt be included as document colors
Summary: Default cell style colors shouldnt be included as document colors
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
Depends on:
Blocks: Calc-Styles Document-Colors-Palette
  Show dependency treegraph
 
Reported: 2017-04-24 09:56 UTC by Yousuf Philips (jay) (retired)
Modified: 2019-05-15 21:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-04-24 09:56:19 UTC
Colors from the new default cell styles (bug 90937) are being used in the color picker's 'document colors' palette.

Steps:
1) Open Calc
2) Open the font color color picker widget in the toolbar
3) Switch to document colors palette

Version: 5.4.0.0.alpha0+
Build ID: f0340e3dca1091accdb71e0c566b96cdf9e0f791
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-21_13:34:48
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Thomas Lendo 2017-04-25 09:42:21 UTC
Right, colors shouldn't be shown until the use has assigned a style with color to a cell.

In Writer it's the same. I think that was desired or forgotten when programmed because default style has no color until now. You can test it: Change the color of a default Writer style and don't apply it to a text - the color will be shown in the 'document colors' palette. That's a false behavior.

I plead for the same behavior in all LibO components in this case. Changing component to "LibreOffice" instead of "Calc"?
Comment 2 Yousuf Philips (jay) (retired) 2017-06-09 09:12:27 UTC
(In reply to Thomas Lendo from comment #1)
> In Writer it's the same. I think that was desired or forgotten when
> programmed because default style has no color until now. You can test it:
> Change the color of a default Writer style and don't apply it to a text -
> the color will be shown in the 'document colors' palette. That's a false
> behavior.

If you change the color of the default paragraph style, then it should be in the 'document colors'. This is the correct behaviour. In Writer we have colors on character styles like 'internet link', 'visited internet link', and 'placeholder', but those dont show up in 'document colors' when you create a new document.
Comment 3 Thomas Lendo 2017-06-09 10:10:49 UTC
(In reply to Yousuf Philips (jay) from comment #2)
> If you change the color of the default paragraph style, then it should be in
> the 'document colors'. This is the correct behaviour.
Document color palette should only show the colors of applied styles, not of not-yet-used style colors. Also Writer paragraph style colors shouldn't be shown until that style is applied to content - same behavior as with character styles.
Comment 4 QA Administrators 2018-08-28 02:42:59 UTC Comment hidden (obsolete)
Comment 5 Cor Nouws 2019-05-11 12:46:52 UTC
Problem does not exist in 6.3 master.
Comment 6 Thomas Lendo 2019-05-15 21:19:40 UTC
Cor, this is not true. The issue still exists.
If I open a new spreadsheet document and go to the background or font color split button in the toolbar, then switching to "Document colors" shows all colors that are available in the cell styles (although these cell styles are not assigned to any cell of the document).

Version: 6.3.0.0.alpha0+
Build ID: 98630a0bd49bd80652145a21e4e0d0ded792b36b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-04_04:44:35
Locale: de-DE (de_DE.UTF-8); UI-Language: en-US
Calc: threaded