Created attachment 115188 [details] excel 2013 cell styles Calc presently has a default set of 5 cell styles most of which are not very useful. Default - Liberation Sans 10pt; Borders: 1pt Content Spacing; Format: General Heading - 16pt, Bold, Italics, Horizontal Center Heading 1 - Text Orientation: 90 degrees Result - Bold, Italics, Underline Result 2 - Format: Currency with Red Highlight During a survey that was run about improving Calc months ago ( http://user-prompt.com/how-do-you-want-libreoffice-calcs-toolbar-configured/ ), one of the most asked feature improvements requested was for better usage of styles, but this cant be achieved without a good set of default styles. This issue was briefly discussed on redmine ( https://redmine.documentfoundation.org/boards/1/topics/493 ) so i've opened this bug report to have a record in bugzilla and also link to a google docs spreadsheet which i've begun working on regarding this issue with others. https://docs.google.com/spreadsheets/d/1Bt2Gr0JslOLL86xb-bCl76mji5AhHT_8VI-5Wp5Qyq0/edit?usp=sharing This file and additional ones related to this topic can be found in this google docs folder. https://drive.google.com/folderview?id=0B6qJrVIa0SAlfjVOLUhUV2pNcnI0MWpxYUNwX3VKajhsY0VGYjdkaGVpbE1fWDBrWGdxdGc&usp=sharing Once we have a good set, it would be useful to show the 'Apply Style' drop down menu in the formatting toolbar once it functions properly, as cell backgrounds and borders arent currently rendered and there are some other bugs (e.g. bug 90931, bug 90934)
Setting NEW as ux-advise enhancement.
Kendy stated that the current cell styles are hardcoded into the following function ScStyleSheetPool::CreateStandardStyles() http://cgit.freedesktop.org/libreoffice/core/tree/sc/source/core/data/stlpool.cxx#n275
Created attachment 116607 [details] Calc default styles proposal
So the design team just agreed that the "Calc default styles proposal" is what we would like to see as the default styles in Calc. I feel pretty good about the outcome, I think it looks nice and functional. * it uses colors from the default palette * showcases the use of styles * works in grayscale print (except for the "Warning" style) * previously present styles "Result" and "Result 1" would be removed (I think only engineers use such styles and underline button works just fine for us)
Created attachment 116608 [details] A cleaned version of style definitions XML
CCing markus on this bug, as he said he would implement this once the design team had finalized a styles xml file, we we have just completed.
*** Bug 92968 has been marked as a duplicate of this bug. ***
This is a status update: At the beginning of the month, moggi asked me to provide a list of all possible cell formatting features that maybe used, as he would need to implement them in orcus ( https://gitlab.com/orcus/orcus/blob/master/README.md ), as all he had presently implemented was for the current set of styles we've provided ( font properties, background fill, borders ). This was the list i provided to him. 1) Font: name, size, color, bold, italics, underline 2) number format 3) border line arrangement and style 4) background color Moggi has stated to me today that unfortunately he doesnt have enough time to implement this in 5.1, so he's postponed this for 5.2.
*** Bug 96352 has been marked as a duplicate of this bug. ***
This is a status update: Moggi said to me a few months ago that he doesnt have time to implement this feature within Orcus, which would then make the feature available within Calc, so he had setup a GSoC idea for the work which he would mentor if a student took up the task. https://wiki.documentfoundation.org/Development/GSoC/Ideas#Support_ODF_styles_in_orcus
Status Update: A GSoC student took on the project and it was completed. Moggi stated that he has to fix some test failures and then we can begin integrating the cell styles in.
Jaskaran Singh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=06f319937187f76ee402d53b3baa78c391c2af19 tdf#90937 Add a set of cell styles to calc It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I suppose this can be considered closed. Please improve the text in the 5.3 release notes about the feature.
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e459881f0c29398052b9ce28354f2668163626af tdf#90937 Correct cell style names that are missing a space It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I suggest that the border of style "Note" be changed to 0.75 pt. Currently it's 0.06pt as I can see in the source code of the commit message. Borders below 0.75pt are showing dashed when save as xlsx, because of the bug as discussed in bug 79787.
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c18e169ce817f940bede186166540913cb564b4c tdf#90937 Adjust Note cell style border width and color It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=39d5a4136f8de0a9033a96cdbf23e04d2184e9b7 tdf#90937 Add hyperlink cell style It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Notes border thickness was changed and hyperlink cell style was added. Set to VERIFIED FIXED. Thanks for the patches! Version: 6.0.0.0.alpha1+ (x64) Build ID: 13c5dd1d98a480cb01ca8f24242c80e326e4ade8 CPU threads: 8; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2017-10-31_01:03:30
(In reply to mahfiaz from comment #4) > * previously present styles "Result" and "Result 1" would be removed (I > think only engineers use such styles and underline button works just fine > for us) This assumption is wrong. These styles were used programmatically and removing them broke the Subtotal tool functionality, see bug 133812.
I'm not familar with this bug, but you can hide styles. So for exaple styles that are needed for LibO internal stuff, you can hide them, so they will be available for LibO functionality, but not visible for the user.