In the S_l_ide menu (where _x_ = underline):
New Slid_e_ and
D_e_lete Slide and
Slide Master D_e_sign and
*all* use 'e' for the keyboard shortcut.
_N_ew Slide and
_D_elete Slide and
since neither 'n' nor 'd' nor 'm' are used elsewhere in the Slide menu.
Thanks for pointing this out. Your suggestion looks good.
@Stuart: You gonna take this one?
(In reply to Yousuf Philips (jay) from comment #1)
> @Stuart: You gonna take this one?
No, not set up to build at the moment. All yours...
Done - https://gerrit.libreoffice.org/#/c/37034/
Thank you! I look forward to when it's released.
(In reply to pcunger from comment #0)
> since neither 'n' nor 'd' nor 'm' are used elsewhere in the Slide menu.
This isnt accurate, n is used in "_New Master", d is used in "_Delete Master" and m is used in "Su_mmary Slide", so what should we do about this now as my patch doesnt solve the multiple entries having the same accelerator issue.
Doh! Sorry... They're greyed out, so I didn't pay them any attention. My mistake!
What to do? Just a suggestion, but how about:
As far as I can see 'u' isn't used elsewhere (even in greyed out menu items), so that's a safe change. 'W' /is/ used elsewhere (Sho_w_ Slide), but it is greyed out, and I'm not sure in what context it would be active... 'D' is also used elsewhere, but to my mind 'Slide' functions would be used more often then 'Master' ones, so change 'Delete _M_aster' to free up 'd' (this /does/ double up 'm' with Su_m_mary Slide, but that might be OK since the latter is relatively unused in comparison to Delete Master (which probably isn't used much either?))
One thing I noticed is that even though there are a number of items that use 'e', when the Slide menu is open pressing 'e' toggles between New Slide and Delete Slide--it doesn't go to Master Slide Design or Master Elements (LO 184.108.40.206, Win7). Anyone know why?
(In reply to pcunger from comment #6)
> One thing I noticed is that even though there are a number of items that use
> 'e', when the Slide menu is open pressing 'e' toggles between New Slide and
> Delete Slide--it doesn't go to Master Slide Design or Master Elements (LO
> 220.127.116.11, Win7). Anyone know why?
It just toggles between two.
- when there is no shortcut, it is automatically assigned
- if two have the same and the first is a submenu, it won't toggle to the second
So, possibly a pretty safe and sustainable approach is to assign smart thought short cuts to important menu items, and let the software do the rest.
(I've paid much time to figuring out short cuts and assigning them in the past. Then things were extended, changed. So try to stay safe & be smart, is what I mean ;) )
Yep its better that similar normal and master slide commands have the same accelerator rather than all of them using _e_.
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":
tdf#107455 Fix accelerators in the Slide menu
It will be available in 5.4.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.