Bug 107476 - FILEOPEN: DOC: DOCX: TAB_OVER_MARGIN paragraphs should never wrap
Summary: FILEOPEN: DOC: DOCX: TAB_OVER_MARGIN paragraphs should never wrap
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:doc, filter:docx
: 40787 99735 (view as bug list)
Depends on:
Blocks: DOCX-Anchor-and-Text-Wrap DOC-Anchor-and-Text-Wrap
  Show dependency treegraph
 
Reported: 2017-04-27 10:56 UTC by Xisco Faulí
Modified: 2020-06-17 12:17 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (127.96 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2017-04-27 10:59 UTC, Xisco Faulí
Details
sample 2 (143.00 KB, application/msword)
2017-04-27 11:04 UTC, Xisco Faulí
Details
sample3 (111.01 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2017-04-27 11:27 UTC, Xisco Faulí
Details
tdf35021_tabOverMarginDemo2.doc: Left tab_over_margin paragraph shouldn't wrap (11.00 KB, application/msword)
2017-05-06 06:54 UTC, Justin L
Details
tdf35021_tabOverMarginDemo2.pdf: from MS Word (3.81 KB, application/pdf)
2017-05-06 07:00 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2017-04-27 10:56:05 UTC
Steps to reproduce:
1. Open attached file
2. Check left textbox on first page

Observed behaviour: it overlaps the horizontal line

Reproduced in

Version: 5.4.0.0.alpha0+
Build ID: 7c11fe076005ed4e28f04f14990b7011a03a4517
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 Xisco Faulí 2017-04-27 10:59:04 UTC
Textbox's position was fixed in commit

author	Justin Luth <justin_luth@sil.org>	2016-12-31 14:45:50 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2017-01-18 09:05:28 (GMT)
commit	441d7e046df36900bbf14b37277b15d615f67641 (patch)
tree	05df1fb77bab72e79abbf4674198be59b80a8c23
parent	b7388a7483da5cffdc4eef6c0474b98c9e5f5af0 (diff)
tdf#35021 TabOverMargin: support LEFT tabs also

however, the wrong position was introduced again by:

author	Justin Luth <justin_luth@sil.org>	2017-03-30 09:48:18 (GMT)
committer	Justin Luth <justin_luth@sil.org>	2017-03-31 06:01:18 (GMT)
commit	5251e7988a3bb1cfccff54eccf7fdd7621c4627c (patch)
tree	510f6e717921f96c89c1e4debc9397258ee0bef8
parent	4a58754714c4e570f68b31a1926c7de6feb48cc2 (diff)
tdf#106701 tabOverMargin: only affect specified tabstops, not autotab

Bisected with bibisect-linux-64-5.4

Adding Cc: to Justin Luth
Comment 2 Xisco Faulí 2017-04-27 10:59:43 UTC
Created attachment 132889 [details]
sample file
Comment 3 Xisco Faulí 2017-04-27 11:04:40 UTC
Created attachment 132890 [details]
sample 2

another file affected by the same commit
Comment 4 Xisco Faulí 2017-04-27 11:27:22 UTC
Created attachment 132895 [details]
sample3
Comment 5 Justin L 2017-04-27 18:54:38 UTC
Comment 2: 2nd_quarter-2010(1).docx: Although the horizontal line (a border line connected to heading 4 style) appears to be better placed, the address itself is worse (not centered because it is now wrapping around the picture because it is one line too close now. I'd probably blame most of this text height problem on the use of MS Trebuchant font. [Current master is the better rendering if you compare tab positions. I don't think the textbox position itself ever changes - only the text above it.]

Comment 3: Virkamatka_anomus(1).doc: The header contains lots of spurious tabs with paragraph style puv-Date defining the tabstop at 6.3in. Using Word2013 to saveas .docx (to remove the password protection) results in a two-page document with a large header - similar to how it appears in LibreOffice. [hard to fully evaluate a locked document]

Comment 4: Zurb Mozilla SOW #6.docx: Payment title inside the table - in MSWord some extra words are hidden because a 2.5in tabstop pushes them beyond the end of the cell (hiding "Due Date" and another "Payment"). [very badly designed document still doesn't look the same in master, hard to say what is more correct.]

In all of these documents, some aspect just happens to look better with the first patch as a side effect.  None of these intentionally use a left-tab-over-margin.
Comment 6 Justin L 2017-05-06 06:54:45 UTC
Created attachment 133100 [details]
tdf35021_tabOverMarginDemo2.doc: Left tab_over_margin paragraph shouldn't wrap
Comment 7 Justin L 2017-05-06 07:00:46 UTC
Created attachment 133101 [details]
tdf35021_tabOverMarginDemo2.pdf: from MS Word

All of these documents exhibit poor design and display the caveat mentioned in https://cgit.freedesktop.org/libreoffice/core/commit/?id=a9367c1b39600d5a5e2d0067113f06ad59cc37a1

"CAVEAT: Basically all of this stuff tricks the layout engine, so the amount of text allowed on a single line is still "controlled" by the right margin. So, even though the extended line could theoretically be very long, the amount of text still must fit within the limits set by the right margin. Thus large margins [or lots of text after the tab] may cause wrapping in LibreOffice, instead of disappearing off of the end of the paper as it does in MSWord, and editing the text might get confusing - which matches the experience in MSWord."

In simpler terms, MS Word never wraps tab_over_margin paragraphs - they just disappear off the end of the page (or cell) on a single line.
Comment 8 QA Administrators 2019-10-11 02:36:17 UTC Comment hidden (obsolete, spam)
Comment 9 Justin L 2020-04-18 17:22:34 UTC
*** Bug 40787 has been marked as a duplicate of this bug. ***
Comment 10 Justin L 2020-04-18 17:27:22 UTC
*** Bug 99735 has been marked as a duplicate of this bug. ***
Comment 11 Cor Nouws 2020-06-17 12:17:16 UTC
from bug 40787#c13

attachment 90834 [details]
test document from 2013 situation... with various examples where tabs are shown at end of line/character in Writer and not in Word

Only when there is a tab setting at the right margin and the alignment of that tab is left, the superfluous tab characters are not shown