Description: We have a customer document (xlsx file) that exhibits a slow import. Upon further examination at least a part of the poor performance stems from pivot cache population esp. in ScDPCache::InitFromDoc(...) where we are not properly parsing the column values using the multi_type_vector's position iterators. We should be able to improve the performance of this code, and I'm currently looking into this. Actual Results: Expected Results: Reproducible: Always User Profile Reset: Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Taking it.
Unfortunately we can't share the customer document due to its confidentiality, but we'll try to come up with a similar document to exhibit the slow performance (if we can).
Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4cd8677889ec3807c194ef5b462f8e031807e5b tdf#107945: properly iterate over mtv during pivot cache loading. It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
FYI that's just a step one. I'm not finished with it yet.
Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ecb3f4625188d02e85a3daef76ccf7f26b33a61 tdf#107945: store rtl_uString pointers instead of heap OUString objects. It will be available in 5.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a078328e91ab9cbd78a92608c1abdc2c57ff9ac5 tdf#107945: prepare for future multi-threading of pivot cache... It will be available in 5.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Kohei, is this bug fixed? Please change status to FIXED if it's so
Let's mark this fixed for now. I was planning on doing a bit more, but I may not have the chance to follow through my initial plan any more.