Bug 108399 - FILESAVE: DOCX - Dont export run property tags with false values when not needed
Summary: FILESAVE: DOCX - Dont export run property tags with false values when not needed
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:docx
Depends on:
Blocks: Hyperlink OOXML-Export-Cleanup DOCX-Comments DOCX-Hyperlink
  Show dependency treegraph
 
Reported: 2017-06-07 21:01 UTC by Yousuf Philips (jay) (retired)
Modified: 2021-05-31 14:57 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-06-07 21:01:51 UTC
Steps
1. Open attachment 133896 [details]
2. Save it to DOCX
3. Unzip it and open /word/comments.xml
4. Notice the unnecessary run property tags with a 'false' value

Version: 5.5.0.0.alpha0+
Build ID: ddf8539d97ce044b7df8d51d6ec72ec864b40fb8
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-06-04_22:10:59
Locale: en-US (en_US.UTF-8); Calc: group

How it looks in LO

 <w:rPr>
   <w:rFonts w:ascii="Liberation Serif" ... />
   <w:b />
   <w:bCs w:val="false" />
   <w:i />
   <w:iCs w:val="false" />
   <w:caps w:val="false" />
   <w:smallCaps w:val="false" />
   <w:strike w:val="false" />
   <w:dstrike w:val="false" />
   <w:outline w:val="false" />
   <w:shadow w:val="false" />
   <w:emboss w:val="false" />
   <w:imprint w:val="false" />
   <w:color w:val="1C99E0" />
   <w:spacing w:val="0" />
   <w:w w:val="100" />
   <w:kern w:val="2" />
   <w:position w:val="0" />
   <w:sz w:val="26" />
   <w:szCs w:val="24" />
   <w:u w:val="single" />
   <w:vertAlign w:val="baseline" />
   <w:em w:val="none" />
   <w:lang w:val="nl-NL" w:eastAsia="zh-CN" w:bidi="hi-IN" />
 </w:rPr>

How it looks from Word

 <w:rPr>
   <w:b />
   <w:i />
   <w:color w:val="1C99E0" />
   <w:sz w:val="26" />
   <w:u w:val="single" />
 </w:rPr>
Comment 1 Buovjaga 2017-06-11 10:27:22 UTC
Confirmed.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.5.0.0.alpha0+
Build ID: 2802dca10eef67554a81cb2347d5f648fa6fcd63
CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on June 10th 2017
Comment 2 QA Administrators 2018-06-12 02:33:29 UTC Comment hidden (obsolete, spam)
Comment 3 Justin L 2018-08-24 17:40:30 UTC
It can be dangerous to remove "default" values. First you have to make sure that they are not over-riding inherited values from styles etc.
Comment 4 QA Administrators 2021-05-31 04:11:44 UTC Comment hidden (obsolete)
Comment 5 Michael Warner 2021-05-31 14:57:21 UTC
I agree with Comment 3. I think this should be resolved as NOTABUG.