Download it now!
Bug 108401 - Tabs of tabbed Notebookbar wrap across multiple rows when window is small
Summary: Tabs of tabbed Notebookbar wrap across multiple rows when window is small
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.4.0.0.beta2
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
: 123601 124407 (view as bug list)
Depends on:
Blocks: Notebookbar-Theming
  Show dependency treegraph
 
Reported: 2017-06-07 21:28 UTC by Martin Srebotnjak
Modified: 2019-03-29 10:40 UTC (History)
13 users (show)

See Also:
Crash report or crash signature:


Attachments
Tabbed Notebookbar at 1440 px width (27.90 KB, image/png)
2017-06-07 21:30 UTC, Martin Srebotnjak
Details
Tabbed Notebookbar at less than 1440 px width (29.14 KB, image/png)
2017-06-07 21:31 UTC, Martin Srebotnjak
Details
Tabs in notebook view look ugly on Mac OS (85.69 KB, image/png)
2017-08-21 16:10 UTC, Neff
Details
omnibar is rendered incorrectly when the window is too narrow (31.75 KB, image/png)
2017-08-31 14:05 UTC, Rastersoft
Details
LibreOffice 6.1 Beta1 on mac (30.26 KB, image/png)
2018-06-14 09:25 UTC, Xisco Faulí
Details
Screenshot (26.04 KB, image/jpeg)
2018-12-19 09:52 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Srebotnjak 2017-06-07 21:28:07 UTC
Description:
Using LO54b2 on MacOS (on MacBook Air, with 1440x900 display) using LibreOfficeBar in the tabbed mode the icons "Open", "Save", "Undo", "Redo" and the drop-down icon are squeezed even if there is enough room for all.
Thus the icons "Redo" and drop-down get overlaid. This happens on full screen.
If the LO window is resized for width under 1440, even weirder things happen, the tabs names get displayed in two rows and overstreched even if there is enough room in the tab bar.
Will attach screenshots.

Steps to Reproduce:
1. Open a document in LO54b2 Writer in NotebookBar mode with tabs
2. Resize LO window (i.e. squeeze to width 1080 px)
3.

Actual Results:  
The notebookbar icons and tabs are not optimized in placement/positioning.

Expected Results:
No icon overlays in tabbed bar.
No overstretched tabs.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0
Comment 1 Martin Srebotnjak 2017-06-07 21:30:49 UTC
Created attachment 133905 [details]
Tabbed Notebookbar at 1440 px width
Comment 2 Martin Srebotnjak 2017-06-07 21:31:15 UTC
Created attachment 133906 [details]
Tabbed Notebookbar at less than 1440 px width
Comment 3 Buovjaga 2017-06-11 15:19:24 UTC
I repro the "weirder things" upon small width, on macOS 5.4b2, but also on Linux.
I can't test the main problem on macOS because the display is max 1024px. Linux does not have the problem.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.5.0.0.alpha0+
Build ID: 2802dca10eef67554a81cb2347d5f648fa6fcd63
CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on June 10th 2017

macOS 10.12.5
LibO 5.4 beta2
Comment 4 Xisco Faulí 2017-06-15 13:55:41 UTC
Regression introduced in range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=4d43f9e9dda5edeeb6e4b99487b5b6a1fae4bd56..42b40ede8c496aad1021e68a72523af4f57e89f6 where 055ae711eff085ff6b9db8f47c3193016d0db81e looks quite suspicious (I don't have the change to revert it locally now )

Adding Cc: to Szymon Kłos
Comment 5 fcastillousfq 2017-08-02 00:46:01 UTC
I can say that the problem happens on my Ubuntu 16.04 machine. I'm running Libreoffice Build ID: 1:5.4.0~rc3-0ubuntu0.16.04.1~lo1

I have a 1920x1080 screen and when the window is maximized everything looks great. I used wmctrl to resize the window from command line to an exact value and find out the width at which the problems happens.
In my case, any value less than 1283px will show two rows. Any value higher or equal to 1283px shows the windows without any problems.
Comment 6 Neff 2017-08-21 16:10:02 UTC
Created attachment 135705 [details]
Tabs in notebook view look ugly on Mac OS

Notebook view in Mac OSX 10.11.6 (El Capitan), libreoffice 5.3.0.3, 2880 x 1800 resolution
Comment 7 Neff 2017-08-21 16:12:53 UTC
The first tab is interpreted by LO as the last one.
Widgets look absolutely not native in Mac OS!
Comment 8 Rastersoft 2017-08-31 14:03:19 UTC
Same here with LO 5.4.0.3 in Debian SID. If I put two windows side-by-side, the notebookbar can't put the menu in a single line and paints everything wrong. I attach a capture.
Comment 9 Rastersoft 2017-08-31 14:05:07 UTC
Created attachment 135903 [details]
omnibar is rendered incorrectly when the window is too narrow

This is LibreOffice 5.4.0.3 from Debian SID (linux), in a 1920x1080 screen but in side-by-side mode (two windows, each one using one half of the screen).
Comment 10 Vedran Miletić 2017-10-29 11:02:32 UTC
(In reply to Rastersoft from comment #9)
> Created attachment 135903 [details]
> omnibar is rendered incorrectly when the window is too narrow
> 
> This is LibreOffice 5.4.0.3 from Debian SID (linux), in a 1920x1080 screen
> but in side-by-side mode (two windows, each one using one half of the
> screen).

I can confirm this on Fedora, but I'm not sure that it is the same issue as the original report. Anyhow, it would be nice if it was fixed.
Comment 11 Szymon Kłos 2018-06-14 06:50:22 UTC
I pushed a patch for this in the past, can someone verify using Mac OS?
Comment 12 Martin Srebotnjak 2018-06-14 07:15:39 UTC
Is your patch included in LO61b1?
Comment 13 Szymon Kłos 2018-06-14 07:20:36 UTC
yes
Comment 14 Xisco Faulí 2018-06-14 09:25:28 UTC
Created attachment 142725 [details]
LibreOffice 6.1 Beta1 on mac

This is how it looks on mac with 6.1 beta1.
At some point, the tabs overlap the icons on the left and the right
Comment 15 andreas_k 2018-10-24 14:01:05 UTC
On windows and Linux (kde) tabbed toolbar didn't have vissual issues in 6.2 alpha 1.

look like OS-X need some work
Comment 16 Heiko Tietze 2018-12-19 09:50:52 UTC
Cannot confirm the wrapping issue with latest master but c14 is still the current state. Meaning: the tabs are underneath the left icons. Not a big deal since the usual window size should be larger than 1k px. The NB variants are not for all scenarios suited.

Another not so nice issue is the titlebar height. The icons left and the menu right-most are larger. Up to NB designer/QA to close as WFM/WF/NAB/INV.
Comment 17 Heiko Tietze 2018-12-19 09:52:27 UTC
Created attachment 147664 [details]
Screenshot
Comment 18 Alex Thurgood 2019-02-26 09:47:16 UTC
Still present in 6.2.0.3 release on macOS, see bug 123601
Comment 19 Alex Thurgood 2019-02-26 09:47:32 UTC
*** Bug 123601 has been marked as a duplicate of this bug. ***
Comment 20 Maarten Brouwers 2019-03-29 10:40:32 UTC
*** Bug 124407 has been marked as a duplicate of this bug. ***