Description: Shrink/ gow animation effect of Impress only grows, no matter which value. @Buovjaga Steps to Reproduce: 1. Add an Object 2. Choose shrink/grow animation effect 3. Choose a value Actual Results: Shrinks everytime even if the value is below 100%. Expected Results: Shrinking if the value is below 100%. Reproducible: Always User Profile Reset: YES Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
@Buovjaga see issue.
Confirmed. Arch Linux 64-bit, KDE Plasma 5 Version: 5.5.0.0.alpha0+ Build ID: 2802dca10eef67554a81cb2347d5f648fa6fcd63 CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on June 10th 2017
I do not know any version, where shrinking has worked.
I only see Emphasis > Basic > Grow and Shrink in 5.5 master, so not sure how this is inherited from OOo.
(In reply to Yousuf Philips (jay) from comment #4) > I only see Emphasis > Basic > Grow and Shrink in 5.5 master, so not sure how > this is inherited from OOo. Because only the UI is new. According to bug 48918, the effect itself has existed since at least 2006.
The reason seems to be in the UI. The feature itself works. Currently LibreOffice writes the attribute smil:by. The values given there are added to the existing value of the animated attribute, here "scale". An unscaled shape has a scale value of 1. With the UI in LO 3.5.4.2 a setting of "vertical tiny" is written as smil:by="0,0.25". The result is, that the new scale becomes 1.0+0.0=1.0 in x-direction and 1.0+0.25=1.25 in y-direction. The value of the scale-attribute is a factor, so the resulting shape is 125% of the original shape in vertical direction. The UI in current master, after fix for bug 48918, is worse. It writes smil:by="0,0" for that. The correct value for getting a shape which is shrunken to 25% of the original size in vertical direction would be smil:by="0,-0.75". The current UI is bad and therefore I had warned in bug 48918 to simple reactivate it. The UI needs to give the ability to set grow/shrink with (nearly) arbitrary values and independent for x- and y-direction. Instead of writing the smil:by attribute it would be possible to use the smil:to attribute as well. That would result in smil:to="1,0.25" for the above example. I will attach two examples, which show, that LibreOffice can interpret the smil:by attribute with negative values and the smil:to attribute as well. Only the UI is inadequate.
Created attachment 133956 [details] Shrink using smil:to attribute Do not use the animation dialog, but simple play the animation to see the effect.
Created attachment 133957 [details] shrink using smil:by attribute Do not use the animation dialog, but simple play the animation to see the effect.
Ok, let's ping Caolán.
I presume I was cc'ed cause of bug 48918 and https://cgit.freedesktop.org/libreoffice/core/commit/?id=7d70516bb1aef8c234788c1cc515d78ac2df7a0c but that's in because of https://gerrit.libreoffice.org/#/c/36524/ and bublies "I'm going to merge this as there is a student who wants to work on the related bug" so presumably bubli can map this to the student who has some thoughts on the issue ?
Rohan is working on this: https://gerrit.libreoffice.org/#/c/38231/
Unfortunately I don't see the new extended UI for tweaking growth and shrink dimensions to be production-ready any time soon, so I've fixed at least the part where shrinking the object (tiny & small) actually works. However, this makes me wonder: > An unscaled shape has a scale value of 1. > > With the UI in LO 3.5.4.2 a setting of "vertical tiny" is written as > smil:by="0,0.25". The result is, that the new scale becomes 1.0+0.0=1.0 in > x-direction and 1.0+0.25=1.25 in y-direction. The value of the > scale-attribute is a factor, so the resulting shape is 125% of the original > shape in vertical direction. > The correct value for getting a shape which is shrunken to 25% of the > original size in vertical direction would be smil:by="0,-0.75". How would a case when the shape would grow to 150% of its original size be written? Currently it is saved as smil:by="1.5, 1.5" but using the above formula, this results in 1 + 1.5 = 2.5 i.e 250% growth, which feels wrong ... would smil:by="0.5, 0.5" be the correct value?
(In reply to Katarina Behrens (CIB) from comment #12) > How would a case when the shape would grow to 150% of its original size be > written? > > Currently it is saved as smil:by="1.5, 1.5" > but using the above formula, this results in 1 + 1.5 = 2.5 i.e 250% growth, > which feels wrong ... would smil:by="0.5, 0.5" be the correct value? You can use either smil:by="0.5,0.5" or smil:to="1.5,1.5". You can test it easily. Change the file manually and run the presentation.
But smil:to is absolute, and smil:by is relative to the previous state. So smil:to="1.5,1.5" is only equal to smil:by="0.5,0.5", if you start with a scale of 1.
Katarina Behrens committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=666dc76e0426927c5f8e70fcfa5bce25171a0722 tdf#108450: The shrink part of grow/shrink animation finally works It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A polite ping to Katarina Behrens: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks
(In reply to Xisco Faulí from comment #16) > A polite ping to Katarina Behrens: is this bug fixed? if so, could you > please close it as RESOLVED FIXED ? Thanks @Regina Henschel, could you please check whether this issue is fixed?
Partially fixed, for complete fix https://gerrit.libreoffice.org/#/c/38231/ is needed ... but I said so already
Given animations are correctly played. UI is still missing.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
UI is still missing. The file has different shrink settings for width and height. Such does not exist in the UI.
Dear Rohan Kumar, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this.
Edward Lynch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1da19c31d3b8f8e0eba1ffcffe7b89f90c4171d4 tdf#108450 and tdf#134665 Fix Impress Grow/Shrink Animation Scaling It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dear Iceflower S, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug