When I select some text on a terminal window and then middle click inside a LibreOffice window, the selected text is not pasted into the document. This used to work in previous versions of LibreOffice. Tools->Options->View->Middle mouse button is set to "Paste clipboard". Tested under OpenSUSE Tumbleweed, using both the OpenSUSE and the official builds.
Confirmed with LO 5.4.0.3 / Ubuntu 17.04. Works with 5.3.1.2. => regression
4f992444363630b31d0dfc1befdb8b6d64b3d344 is the first bad commit commit 4f992444363630b31d0dfc1befdb8b6d64b3d344 Author: Jenkins Build User <tdf@pollux.tdf> Date: Thu Feb 16 13:24:26 2017 +0100 source 65b7b6322b662785bf032e66c76abc36c9a2bb0e # bad: [948fb3543b2fbce9ae77421af7582f163a811deb] source 5bcd18461b8cb63b477dbb74025374b4c963161a # good: [f04172d4ac1553877deea87d267307ad3eb1c99b] source 4136757b4e51c4e6f7cb4132c95538a7f831ef2c git bisect start '948fb3543b2fbce9ae77421af7582f163a811deb' 'oldest' # bad: [d5e2d620f31fe478ac6553d0f7adfe642886685c] source d4036d3a89b65a4912f62e3930eb1a31cd90a16b git bisect bad d5e2d620f31fe478ac6553d0f7adfe642886685c # good: [86efb286e22b76725d0943a8dd6c65e28367065c] source 22e1fc5402c17c8459873e621f7630674d2b98f1 git bisect good 86efb286e22b76725d0943a8dd6c65e28367065c # good: [ba6ee37a46cab12b0adb8eeef014631229ab0ff1] source 9a29cd7d26ccdd97b728a4c837c58624770122eb git bisect good ba6ee37a46cab12b0adb8eeef014631229ab0ff1 # good: [e99d1d007558c0a6a9e9f5e01152df905c4e504d] source f72b866c9cf4f07fce6744fbf482c4c6488106e2 git bisect good e99d1d007558c0a6a9e9f5e01152df905c4e504d # good: [f8391e0a384b98c94abbd99b7b2d2b599619643d] source ccedfa046aad9eb411a1298c2572496768a039aa git bisect good f8391e0a384b98c94abbd99b7b2d2b599619643d # good: [457abbef55202bc3cc560b06537a7e2430b62224] source b6f9eeb9b5c0e29ca655185dc299ebd4a2c092d7 git bisect good 457abbef55202bc3cc560b06537a7e2430b62224 # bad: [b27886afdfac71b59aaa3dbb8d55cbb9bb3f720c] source 76cf4c365643e18436c691e284527fccfe273c9a git bisect bad b27886afdfac71b59aaa3dbb8d55cbb9bb3f720c # bad: [2a12c1be120082a4cd63b612ad38e059edbbc0d7] source b668b90dee629cae114ef4d0e89a466b5ef906ac git bisect bad 2a12c1be120082a4cd63b612ad38e059edbbc0d7 # bad: [6757aff049fe4236e76744e4ca60c7722019c243] source 33c6ccecf40d7207b35ed81af01d1536da68a441 git bisect bad 6757aff049fe4236e76744e4ca60c7722019c243 # bad: [c797434d13090f19dfc5cae472dfdf8ef585a77b] source 9aaabf3e03ac0a3cc3dfd2870be48ba8913ad68b git bisect bad c797434d13090f19dfc5cae472dfdf8ef585a77b # bad: [4f992444363630b31d0dfc1befdb8b6d64b3d344] source 65b7b6322b662785bf032e66c76abc36c9a2bb0e git bisect bad 4f992444363630b31d0dfc1befdb8b6d64b3d344 # good: [84aa87895fced4d8679b8e3871701a4369598321] source 20915bcbf45b4b0b4bc8c68c7df9eb6b13abbe06 git bisect good 84aa87895fced4d8679b8e3871701a4369598321 # first bad commit: [4f992444363630b31d0dfc1befdb8b6d64b3d344] source 65b7b6322b662785bf032e66c76abc36c9a2bb0e
This seems to be a fallout from the commit referenced below. Noel, could you please take a look? https://cgit.freedesktop.org/libreoffice/core/commit/?id=65b7b6322b662785bf032e66c76abc36c9a2bb0e author Noel Grandin <noel.grandin@collabora.co.uk> 2017-02-08 08:40:28 (GMT) committer Noel Grandin <noel.grandin@collabora.co.uk> 2017-02-08 12:42:52 (GMT) "loplugin:unusedenumconstants read-only constants in vcl"
*** Bug 111339 has been marked as a duplicate of this bug. ***
Noel, would selectively reverting 65b7b6322b662785bf032e66c76abc36c9a2bb0e be the fix here? Evidently PasteSelection in MouseMiddleButtonAction was used. Possibly the middle-mouse-button-related setting somewhere here could be changed to actually refer the enum value: https://opengrok.libreoffice.org/xref/core/cui/source/options/optgdlg.cxx#827
Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5b3b0a91edc4c468c7c9c132cd066c0d25de9706 tdf#110988 Middle click does not paste primary selection It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
please also backport :) thanks!
yes, please. see also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871588
Just checked the daily builds. The problem is fixed in master~2017-08-14_23.23.22_LibreOfficeDev_6.0.0.0.alpha0_Linux_x86-64 It is not fixed in libreoffice-5-4~2017-08-14_06.48.40_LibreOfficeDev_5.4.2.0.0_Linux_x86-64 Please consider backporting to 5.4.
Cherry-picked in gerrit: https://gerrit.libreoffice.org/#/c/41151/1 https://gerrit.libreoffice.org/#/c/41133/1
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a0636486e54bf9c8cf35657368e2779792da8b6d&h=libreoffice-5-4 tdf#110988 Middle click does not paste primary selection It will be available in 5.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-5-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=28ed0ea234a80474065592726e05967540e8db2e&h=libreoffice-5-4-1 tdf#110988 Middle click does not paste primary selection It will be available in 5.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 112072 has been marked as a duplicate of this bug. ***