Bug 111201 - Typed file extension should overwrite filetype set in dialog
Summary: Typed file extension should overwrite filetype set in dialog
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: File-Dialog Unify-Across-Apps
  Show dependency treegraph
 
Reported: 2017-08-02 22:39 UTC by Yousuf Philips (jay) (retired)
Modified: 2020-07-01 01:13 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-08-02 22:39:24 UTC
Opening this bug as the user error behaviour mentioned in bug 99639 only happens in Windows and not Linux and they should be the same.

Steps
1. Open Writer
2. Ctrl + S
3. Replace the file extension .odt with .docx and dont change the 'save as type' drop down from its default 'ODF Text Document...' entry
4. File is saved in odf format
Comment 1 Aron Budea 2017-08-03 03:35:19 UTC
This is basically bug 93199, right?
Comment 2 Heiko Tietze 2017-08-03 07:49:37 UTC
That's how Linux works. You can label a file foo.doc.odt and the user is supposed to be smart enough to work without automatic adjustments. WF in my opinion.
Comment 3 Xisco Faulí 2017-08-03 09:00:10 UTC
I've seen this inconsistency in the past...
on Linux the export change to .odt if I change the name. However, on Windows, the output name will be foo.odt.xxx.
From my point of view, it's a bug as the behaviour is inconsistent across platforms.
Comment 4 Heiko Tietze 2017-08-03 09:06:28 UTC
(In reply to Xisco Faulí from comment #3)
> From my point of view, it's a bug as the behaviour is inconsistent across
> platforms.

It's how the platforms work, inconsistently. Windows hides the file extension and you see foo.doc while the actual extension is .odt. On the other hand, in case of raster graphics no one cares if a bmp file is called png because the application detects the format not trusting on the filename. And LibreOffice is capable of that too.
Comment 5 Yousuf Philips (jay) (retired) 2017-08-03 12:55:22 UTC
(In reply to Aron Budea from comment #1)
> This is basically bug 93199, right?

Guess it is.

(In reply to Heiko Tietze from comment #4)
> It's how the platforms work, inconsistently.

Doesnt mean that we cant fix this issue specifically to Windows for the save dialog, as we have users who are using LO cross-platform and falling over this issue.

On Windows, i can change the filetype of the open dialog to only show .docx files, but if i type the name of a .odt file in the filename field, it will pick it, though it still tries to load it as a .docx file. ;D

> Windows hides the file
> extension and you see foo.doc while the actual extension is .odt. On the
> other hand, in case of raster graphics no one cares if a bmp file is called
> png because the application detects the format not trusting on the filename.
> And LibreOffice is capable of that too.

Hiding of file extensions isnt relevant, as you can easily enable the showing of file extensions.
Comment 6 Buovjaga 2018-03-03 19:02:46 UTC
*** Bug 115229 has been marked as a duplicate of this bug. ***
Comment 7 Buovjaga 2018-03-03 19:04:29 UTC
(In reply to Buovjaga from comment #6)
> *** Bug 115229 has been marked as a duplicate of this bug. ***

Sorry, this was a mistake as Jay's report is against Windows.
Comment 8 Xisco Faulí 2018-10-24 11:12:14 UTC
Let's put this one to NEW
Comment 9 QA Administrators 2019-10-25 02:39:41 UTC Comment hidden (obsolete)
Comment 10 ffs 2019-10-28 10:43:03 UTC
Still there in Version: 6.0.7.3 and still <really> irritating!
Comment 11 Mike Kaganski 2020-06-29 06:02:37 UTC
Second WF suggested in comment 2.
Comment 12 Heiko Tietze 2020-06-29 06:09:01 UTC
(In reply to Mike Kaganski from comment #11)
> Second WF suggested in comment 2.

Then let's do it.
Comment 13 Aron Budea 2020-06-30 13:35:55 UTC
(In reply to Heiko Tietze from comment #2)
> That's how Linux works. You can label a file foo.doc.odt and the user is
> supposed to be smart enough to work without automatic adjustments. WF in my
> opinion.
I'd say this is more of a convenience feature than being "smart enough." You're entering a file name already, and you could just type a few more characters instead of opening the dropdown, finding the entry you're looking for and clicking on it.

Then again, surely there'd be things to keep in mind, like prominently notifying the user in what format the file is actually saved in.
Comment 14 Mike Kaganski 2020-06-30 14:04:54 UTC
(In reply to Aron Budea from comment #13)

I suppose that we must try hard to follow OS/environment conventions as much as we can. And unless we use our own file dialogs, the dialogs provided by shell must behave just as in other applications (or rather as shell designers intended them to behave). On Windows, that is according to how MS intends it; KDE or Gnome have own vision... I suppose that any change in the behaviour of such things to be custom to LO is bad.
Comment 15 Aron Budea 2020-07-01 01:13:05 UTC
(In reply to Mike Kaganski from comment #14)

I'd doubt any OS convention exists on adding two extensions to a file (which isn't something a user would normally do), thus I don't think being lenient about this would be unreasonable.