Bug 112541 - Default color for shapes
Summary: Default color for shapes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 116759 123191 133127 (view as bug list)
Depends on:
Blocks: Shapes
  Show dependency treegraph
 
Reported: 2017-09-21 08:21 UTC by Heiko Tietze
Modified: 2024-03-10 15:17 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2017-09-21 08:21:27 UTC
The default color for drawing objects is #729fcf (pale blue), not easy to set back after changed into something else. The suggestion is to use a named color from the standard palette - and ideally to make it configurable via Tools > Options > Colors.
Comment 1 andreas_k 2017-09-21 08:24:07 UTC
+1 in addition link the color with the color plate.
Comment 2 Heiko Tietze 2017-09-26 14:47:24 UTC
Seems there are a lot of places for this color (n=257). 
https://opengrok.libreoffice.org/search?project=core&q=729fcf&defs=&refs=&path=&hist=&type=

Closest color from the new standard is Light Blue 3, #7da7d8 but why not go with the LibreOffice typical green and use Light Lime 3?
Comment 3 Heiko Tietze 2018-01-03 08:15:41 UTC
Suggestion on the mailing list to switch from blue to green received positive resonance (it should be a color from the standard palette rather than a branding color to not always switch back and forth)
http://nabble.documentfoundation.org/Default-color-for-shapes-tt4229331.html

Shape color is defined in include/svx/xdef.hxx as #define COL_DEFAULT_SHAPE_FILLING 0x729fcf. Unfortunately, the hard-coded color value is spread over the source code in particular at the unit tests. Decision in ESC was to to separate default on filter from default in UI. 
http://nabble.documentfoundation.org/minutes-of-ESC-call-tt4229532.html
Comment 4 Heiko Tietze 2018-04-10 09:33:00 UTC
*** Bug 116759 has been marked as a duplicate of this bug. ***
Comment 5 QA Administrators 2019-04-11 02:57:42 UTC Comment hidden (obsolete)
Comment 6 Heiko Tietze 2019-05-03 09:10:35 UTC
*** Bug 123191 has been marked as a duplicate of this bug. ***
Comment 7 Heiko Tietze 2020-05-18 09:43:58 UTC
*** Bug 133127 has been marked as a duplicate of this bug. ***
Comment 8 andreas_k 2020-05-18 10:23:42 UTC
If we can have drawing style support (BUG 89369) in writer and calc like we have in draw and impress. We can also solve this bug and are even more flexible by use different colors for different templates.
Comment 9 Heiko Tietze 2022-09-13 09:32:10 UTC
Changing either the default of COL_DEFAULT_SHAPE_FILLING in include/svx/xdef.hxx or using something else but this constant in sd/source/core/drawdoc4.cxx and svx/source/xoutdev/xpool.cxx doesn't pass QA tests. We generate new content, save it, and compare the result with previously created documents, for example in Chart2XShapeTest::testFdo75075.

One possible solution is to load default templates on start. This makes it possible to run the QA tests with the hard-coded defaults but change the parameters per default template. 

Tried this but failed in https://gerrit.libreoffice.org/c/core/+/115491 because librelogo wasn't cooperative.