Bug 112720 - "find all" again throws you back to the first page with a find hit
Summary: "find all" again throws you back to the first page with a find hit
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.1.6.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 156659 (view as bug list)
Depends on:
Blocks: Find-Search Find-Toolbar
  Show dependency treegraph
 
Reported: 2017-09-28 12:19 UTC by marc
Modified: 2024-08-07 07:00 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description marc 2017-09-28 12:19:28 UTC
libre office writer

after editing near an item that was highlighted with "find all"

if one does "find all" again one is thrown back to the first page with a find hit, instead of near the page where one had just edited something.

this can be very annoying and is useless as it is.
Comment 1 V Stuart Foote 2017-09-28 14:11:24 UTC
Confirming. _Re-running_ a Find All search (from Find toolbar or Find & Replace dialog) repositions the document canvas to the first match. 

After a Find All, the Find Next or Find Previous do not loose positioning after edits vicinity of the match.

But not sure this is incorrect UX. Another run of Find All does the correct thing and should reposition canvas to the initial find.

Seems what is needed is some ability to hold a visual highlight of the Find All while moving through matches with Next/Previous. Now advancing clears the highlight.

User should not need to run another Find All, but we should offer to hold original highlight until a new search is entered--or search is cleared (which can't be done now).

NEW RFE

On Windows 10 Home 64-bit en-US with
Version: 5.4.2.1 (x64)
Build ID: dfa67a98bede79c671438308dc9036d50465d2cb
CPU threads: 4; OS: Windows 6.19; UI render: default; 
Locale: en-US (en_US); Calc: group
Comment 2 Heiko Tietze 2017-10-01 08:44:51 UTC
MSO has the same behavior, and when you edit after Find All you have to start the search again, IIRC from top. However, simple Find searches from the cursor position (also in LibO) and I think that could also work for FA. Meaning you never start from top, with the advantage that editing is not a problem.
Comment 3 Heiko Tietze 2019-08-02 10:57:45 UTC
Reconsiderung my comment. What we should do is to start from the next appearance of the search term, let's say with occurrence 6/10, and go to #1 after the last item. Unfortunately we do have neither the number of results (bug 106383) nor the position yet.
Comment 4 Heiko Tietze 2023-08-14 14:56:22 UTC
*** Bug 156659 has been marked as a duplicate of this bug. ***
Comment 5 Heiko Tietze 2023-08-14 14:58:09 UTC
Bug 84460 requests to just highlight with Find All, and bug 95405 to introduce a sidebar that lists all occurrences. This would allow to remove Find All from the quickfind bar completely.
Comment 6 Jim Raykowski 2024-08-07 07:00:21 UTC
Proposed patch that provides behavior of Heiko's comment 3 recommendations:
https://gerrit.libreoffice.org/c/core/+/171581