Bug Hunting Session
Bug 95405 (Sidebar-Find-and-Replace) - Sidebar deck for find/search and replace
Summary: Sidebar deck for find/search and replace
Status: NEW
Alias: Sidebar-Find-and-Replace
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyInteresting, easyHack, skillCpp, topicUI
: 45095 87998 96394 124634 (view as bug list)
Depends on:
Blocks: Find-Search Sidebar-New-Decks
  Show dependency treegraph
 
Reported: 2015-10-28 23:53 UTC by Björn Michaelsen
Modified: 2019-04-10 08:21 UTC (History)
16 users (show)

See Also:
Crash report or crash signature:


Attachments
search results in evince 3.16.1 (135.27 KB, image/png)
2015-10-28 23:53 UTC, Björn Michaelsen
Details
Find panel in MS Office (252.10 KB, image/png)
2016-03-09 19:24 UTC, Yousuf Philips (jay) (retired)
Details
Screenshot of string search window in OSX productivity apps (457.82 KB, image/png)
2016-03-11 09:39 UTC, Alex Thurgood
Details
Cog dropdown menu (search options) (59.01 KB, image/png)
2016-03-11 09:41 UTC, Alex Thurgood
Details
Find and replaec dialog (84.19 KB, image/png)
2016-03-18 15:22 UTC, Alex Thurgood
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Michaelsen 2015-10-28 23:53:21 UTC
Created attachment 120066 [details]
search results in evince 3.16.1

Steps to reproduce:
1/ open writer, type dt<F3> to get some text
2/ Open menu Edit->Find and Replace

Expected result:
A workflow that allow interacting with the content (the text document) without a stolen focus and window popping up in from of the content.

Actual result:
A dialog pops up directly over the document that we want to edit/search/work on and steal the focus. As a bonus, this dialog has to be moved out of the way almost every time as it blocks the view to the document it operates on.

Suggested solution:
Make the whole search and replace dialog a deck in the sidebar, for a start just containing the controls of the current dialog. This would open by clicking the menu entry, but ensure the find and replace UI would not block the view on the document it operates on, neither needing to steal focus.

Optional further extensions:
Make the sidebar contain matches of the search below the controls as e.g. the PDF-viewer "evince" does. An example screenshot is attached.
Comment 1 Heiko Tietze 2015-10-29 00:04:36 UTC
Find (ctrl+F) is non-modal via toolbar. Find & Replace should work similar, maybe like the stacked/expanded input in Kate (https://docs.kde.org/trunk4/en/kde-runtime/fundamentals/find.html). Of course we could also move the search functionality completely into the sidebar, which would affect all components.
Comment 2 Cor Nouws 2015-10-29 07:37:07 UTC
Hi Björn,

I like this one with only one condition: that short cuts keep working as we know now.
Thanks!
Cot
Comment 3 Berk Gureken 2015-10-30 10:09:05 UTC
Are there any code pointers for this bug?
Comment 4 Björn Michaelsen 2015-10-31 03:10:31 UTC
Code Pointers:
The current Find and Replace Dialog is SvxSeachDialog in svx/source/dialog/srchdlg.cxx:
 http://docs.libreoffice.org/svx/html/classSvxSearchDialog.html

As for making an existing dialog into a sidebar panel, the navigator panel might give some orientation:
 http://opengrok.libreoffice.org/search?q=NavigatorPanel&project=core&defs=&refs=&path=&hist=
Comment 5 Robinson Tryon (qubit) 2015-12-14 05:00:13 UTC Comment hidden (obsolete)
Comment 6 Samuel Mehrbrodt (CIB) 2016-02-02 16:00:07 UTC
*** Bug 96394 has been marked as a duplicate of this bug. ***
Comment 7 Robinson Tryon (qubit) 2016-02-18 14:51:21 UTC Comment hidden (obsolete)
Comment 8 Yousuf Philips (jay) (retired) 2016-02-24 01:30:22 UTC
So i do agree that we should have find & replace as a section in the sidebar, i dont think killing off the existing dialog is a good thing, especially for users who cant use the sidebar due to screen size limitations.
Comment 9 Steven Guo 2016-03-09 08:15:40 UTC
Just wondering if the following is a correct interpretation of the task:

1) Create find/replace section in sidebar.
2) Leave current find/replace dialogue in place.

Thanks!
Comment 10 Yousuf Philips (jay) (retired) 2016-03-09 08:33:45 UTC
Hi Steven,

Yes having the functionality in both places are ideal at the moment, so they both should be running off the same code, just like we have now for Navigator. The design team would need to work on a mockup for it.
Comment 11 Cor Nouws 2016-03-09 10:01:11 UTC
(this already was filed in issue 45095)
Comment 12 Cor Nouws 2016-03-09 10:01:58 UTC
*** Bug 45095 has been marked as a duplicate of this bug. ***
Comment 13 Yousuf Philips (jay) (retired) 2016-03-09 15:03:18 UTC
(In reply to Cor Nouws from comment #11)
> (this already was filed in issue 45095)

Wouldnt say docking the find and replace is equivalent to having a deck in the sidebar, but whatever. :D
Comment 14 V Stuart Foote 2016-03-09 15:26:51 UTC
(In reply to Yousuf (Jay) Philips from comment #10)
> Yes having the functionality in both places are ideal at the moment, so they
> both should be running off the same code, just like we have now for
> Navigator. The design team would need to work on a mockup for it.

Yes and the "at the moment" means that like the Navigator dialog (<F5>), the Find & Replace dialog (<Ctr>+H) will need to continue to be available independent of the Sidebar instance.  Unlike the old Styles & Formatting dialog (<F11>) that was bound into the Sidebar.

But this resolves with implementation of bug 85905 -- Allow undocking of Sidebar Decks. With that any of the Content panels could be detached to function as floating dialogs or be attached to additional docking points (as is done for independent Navigator dialog now).  An implementation issue, but functionally there would only be one of each Content panel set (as controlled from the Button bar) with multiple Deck containers to hold each as detached.

So for now, the task is implementing the Find & Replace .ui dialog into a Sidebar Content panel context. And providing it with the same handling as the independent Navigator Content panel.
Comment 15 Yousuf Philips (jay) (retired) 2016-03-09 19:24:59 UTC
Created attachment 123443 [details]
Find panel in MS Office

So here is a screenshot of the Find/Navigate panel in MS Word 2013, it is what you get when you click the find button in the ribbon, as the panel has limited find functionality, so they still retain the find/replace/goto dialog.

http://2.bp.blogspot.com/-I-3zFgVtWXU/UXkhWWCfZ9I/AAAAAAAABJ8/4savFViARIs/s1600/01-Find+&+Replace+Dialog+Box+with+Find+tab+selected.png
Comment 16 Alex Thurgood 2016-03-11 09:38:19 UTC
In Keynote, Pages and Numbers, the Search window appears floating over the document being edited, it never appears in the sidebar. See enclosed screenshot.
Comment 17 Alex Thurgood 2016-03-11 09:39:16 UTC
Created attachment 123488 [details]
Screenshot of string search window in OSX productivity apps
Comment 18 Alex Thurgood 2016-03-11 09:41:55 UTC
Created attachment 123489 [details]
Cog dropdown menu (search options)

As one can see from the screenshot, the search options are hidden in a dropdown menu to the left of the window
Comment 19 Alex Thurgood 2016-03-11 09:44:55 UTC
The OSX search dialog remembers the option last chosen when it is next opened. In other words, if the dialog was displayed as search and replace, it will do so again after dismissal and re-opening.
Comment 20 Alex Thurgood 2016-03-18 15:22:32 UTC
Created attachment 123694 [details]
Find and replaec dialog
Comment 21 Yousuf Philips (jay) (retired) 2016-03-22 13:36:24 UTC
*** Bug 87998 has been marked as a duplicate of this bug. ***
Comment 22 Heiko Tietze 2019-04-10 08:21:50 UTC
*** Bug 124634 has been marked as a duplicate of this bug. ***