Follow-up to bug 95405: The quickfind sidebar (QFS) has no means to change the search and always takes the options from the F&R dialog. We should at least add "[ ] Whole words only" and "[ ] Similarity" and make the QFS independent from the F&R search.
QFS should have *no* dependency on the Find & Replace dialog, rather should come from config for the Findbar. Also, note there is a results "Search key found xx times" showing in the Find bar--that detail really belongs in the SB QFS content panel, not requiring the Find bar to be shown.
=-testing-= TB78 - 20240405 Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 30c6e51fc9cb0fa864e1755271343d847fcced25 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded
Created attachment 194742 [details] options and number of matches label (In reply to Heiko Tietze from comment #0) > Follow-up to bug 95405: The quickfind sidebar (QFS) has no means to change > the search and always takes the options from the F&R dialog. We should at > least add "[ ] Whole words only" and "[ ] Similarity" and make the QFS > independent from the F&R search. Ah! I didn't remember your comment about the Similarity option when doing this. Should Match Case be replaced by it? (In reply to V Stuart Foote from comment #1) > Also, note there is a results "Search key found xx times" showing in the > Find bar--that detail really belongs in the SB QFS content panel, not > requiring the Find bar to be shown. The number of finds is also indicated in the status bar selected word and character count although for unknown reason the status bar selected word count is different.
Created attachment 194743 [details] with similarity option
Not a fan of too many options everywhere. Perhaps we can hide it with an expander. Or provide these options in a popup menu. Small toolbar buttons could work too (thinking of VSCode), though add space to the minimum width (btw. the two checkboxes can become much larger when translated). Similarity is kind of orthogonal to the other options- if fully exclusive consider to disable checkboxes.
I think the QFS needs to be its own SB content panel, while 'Find & Replace' dialog gets its own work-up as a new fully populated content panel. Quick Find should *continue to track* against the Find Bar behavior. Meaning cutting back scope of some of the panel formatting of the results. E.g. 'Whole Words' is not available to the Find bar, nor in the Navigator's 'Repeat search' mode. Find Bar options are currently limited to "find in values" and "match case", with choice to show the "Search results message". Doing more complex find/replace actions on the SB framework needs a new *dedicated* panel with its own design and integration with the F&R dialog config(s). And when there is additional F&R SB content-- the 'Find' Deck title could change if needed to hold both content panels.
Created attachment 194785 [details] with find bar 'Match Case' and F&R icon button and additional icon button for more search options Maybe like what is shown in the attached?
(In reply to Jim Raykowski from comment #7) > Created attachment 194785 [details] > with find bar 'Match Case' and F&R icon button and additional icon button > for more search options > > Maybe like what is shown in the attached? Sure, meaning no SB deck or content panel for the F&R dialog actions. Just the theme'd F&R icon for opening the full dialog. Of course that would mean there is still no GUI representation of a "Find All" result (other than Calc's) with just the "Search results message" showing feedback in the dialog. And other than Calc, wouldn't a SB content panel for graphical F&R search results be of some utility? Use the same framework as QFS is fine, just don't mix the search modes/configurations.
Created attachment 194913 [details] Demo of search options dialog approach Here's a demo of using a dialog for search options. Also shown in the demo is a change to make the QFS use the F&R attributes options settings. For unknown reason 'Match case' and 'Whole words only' settings from the QFS search options dialog are detected by the F&R dialog but not the Similarity settings.
(In reply to Jim Raykowski from comment #9) > Created attachment 194913 [details] > Demo of search options dialog approach > > Here's a demo of using a dialog for search options. Also shown in the demo > is a change to make the QFS use the F&R attributes options settings. For > unknown reason 'Match case' and 'Whole words only' settings from the QFS > search options dialog are detected by the F&R dialog but not the Similarity > settings. Thanks Jim. It is looking promising. Have we decided then that the Find results deck is going to be common to the QFS *AND* the F&R dialog? The Results panel is shaping up nicely to handle both, question is if the F&R settings should impact the FindBar/QFS--or not. Seems a cleaner break can be made if not, with the FindBar/QFS offering limited options and the F&R dialog standing alone (even if its results end up delivered via the Find deck).
(In reply to Jim Raykowski from comment #9) > ... Also shown in the demo > is a change to make the QFS use the F&R attributes options settings. This should have been: ... Also shown in the demo is a change to make the QFS *NOT* use the F&R attributes and format settings.
PS9 makes F&R dialog search settings not affect QFS searches and QFS search settings not affect searches made using the F&R dialog.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/601cf05456073c082ac6bbe43b501eb81256711b tdf#160543 Quickfind sidebar enhancements It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Should this be closed as fixed?