Bug 112737 - PPTX Presentation freezes upon opening
Summary: PPTX Presentation freezes upon opening
Status: RESOLVED DUPLICATE of bug 112012
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: PPTX
  Show dependency tree / graph
 
Reported: 2017-09-29 01:46 UTC by Aron Budea
Modified: 2017-10-03 14:46 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2017-09-29 01:46:04 UTC 
Open the PowerPoint template from here:
https://templates.office.com/en-us/Smart-Graphics-Sampler-TM16401424

=> LibreOffice freezes.

Observed using LO 6.0 daily build (2017-09-28_03:27:43, 0fa21336428b286d69684cfbb7b845f123657041) / Windows 7.
No freeze with LO 5.4.1.2.
=> regression

Bibisected to the following commit using repo bibisect-linux-64-6.0. Adding Cc: to Patrick Jaap, please take a look sometimes.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=588c5b0cff9bbdb2efbdfb259268154b0074e7e6
author		Patrick Jaap <patrick.jaap@tu-dresden.de>	2017-08-25 12:08:29 (GMT)
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2017-09-15 00:33:48 (GMT)

"tdf#112012 EMF+ add dashed line support"
Comment 1 Patrick Jaap 2017-09-29 07:28:31 UTC 
Hi, this is interesting. Of course, I'll take a look :)
Comment 2 Patrick Jaap 2017-09-29 08:44:11 UTC 
This bug is fixed in current master. My earlier patch 588c5b0cff9bbdb2efbdfb259268154b0074e7e6 was buggy, and the follow-up patch 3b1db9b7a9afe147ed7f841c875bc3b91b03ace9 from yesterday solved this bug, too.

Problem was, there are dashed lines in the presentaion (EMF+ data) and my old patch generated about 57000 times more dashes than it should. This broke the renderer down, sorry.

*** This bug has been marked as a duplicate of bug 112012 ***
Comment 3 Aron Budea 2017-09-29 11:16:29 UTC 
Thanks for checking, and for the fix, Patrick!