Bug 112897 - [UI] Help button should be on the left of dialog (ii)
Summary: [UI] Help button should be on the left of dialog (ii)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Furkan Ahmet KARA
URL:
Whiteboard: target:6.3.0
Keywords: difficultyBeginner, easyHack, skillUI
Depends on:
Blocks: Dialog-Buttons-Unification
  Show dependency treegraph
 
Reported: 2017-10-05 15:29 UTC by Olivier Hallot
Modified: 2019-03-11 11:54 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Image shows current situation (40.75 KB, image/png)
2017-10-05 15:29 UTC, Olivier Hallot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2017-10-05 15:29:44 UTC
Created attachment 136784 [details]
Image shows current situation

As with bug#112677, the Calc Solver dialog has its 'Help' button and 'Options' button misplaced.

Calc: Menu Tools->Solver

See image showing current situation. 

The 'Options' button should be above the Solve/Close button row
The 'Help' button on the far left.

Remarks and comments of bug#112677 applies.
Comment 1 Furkan Tokac 2017-11-01 00:49:11 UTC
Working on the bug.
Comment 2 Heiko Tietze 2017-11-01 12:03:17 UTC
Button sequence depend on OS, see also bug 104897. Under Windows it has to be Help, <Space>, Ok (was/is: Solve), Cancel (was: Close). Options... is not one of the confirmative functions and should be placed within the dialog. Alternatively, I could imagine it left of Ok.
Comment 3 Yousuf Philips (jay) (retired) 2017-11-01 12:23:08 UTC
In the printer settings dialog, we put options to the left of the okay button.
In the spell check dialog we have help, <space>, options, undo, close.

From looking in the various dialogs, we seem to only put apply or remove buttons between okay and close, so i'd stick with putting options to the left of okay.

Adolfo, Stuart: thoughts?
Comment 4 Furkan Tokac 2017-11-01 14:35:57 UTC
Need final decision before the bug fix.
Comment 5 Heiko Tietze 2018-02-11 10:36:37 UTC
(In reply to Furkan Tokac from comment #4)
> Need final decision before the bug fix.

Still working on this topic? If so please go with 

Help, <Space>, Options..., Ok (was/is: Solve), Cancel (was: Close).
Comment 6 Furkan Tokac 2018-02-11 15:22:06 UTC
(In reply to Heiko Tietze from comment #5)
> (In reply to Furkan Tokac from comment #4)
> > Need final decision before the bug fix.
> 
> Still working on this topic? If so please go with 
> 
> Help, <Space>, Options..., Ok (was/is: Solve), Cancel (was: Close).

I was waiting for the replay. Now, I'm working on it.
Comment 7 Heiko Tietze 2018-02-27 15:51:53 UTC
(In reply to Furkan Tokac from comment #6)
> I was waiting for the replay. Now, I'm working on it.

Here is an example https://gerrit.libreoffice.org/#/c/50438/
Comment 8 Furkan Tokac 2018-03-02 00:55:13 UTC
(In reply to Heiko Tietze from comment #7)
> (In reply to Furkan Tokac from comment #6)
> > I was waiting for the replay. Now, I'm working on it.
> 
> Here is an example https://gerrit.libreoffice.org/#/c/50438/

So you're taking care of this bug, right? I'm working on another bug. You can assign this on you. Thanks for the support :)
Comment 9 Furkan Tokac 2018-03-02 00:56:57 UTC
(In reply to Heiko Tietze from comment #7)
> (In reply to Furkan Tokac from comment #6)
> > I was waiting for the replay. Now, I'm working on it.
> 
> Here is an example https://gerrit.libreoffice.org/#/c/50438/

Oh sorry. Just realized that it is same thing but another bug report. I'll fix this issue soon. Thanks for the example :)
Comment 10 Xisco Faulí 2018-04-02 02:26:08 UTC
A polite ping, still working on this bug?
Comment 11 Furkan Tokac 2018-04-02 07:53:24 UTC
(In reply to Xisco Faulí from comment #10)
> A polite ping, still working on this bug?

Actually the patch is ready : https://gerrit.libreoffice.org/#/c/52219/
Comment 12 Xisco Faulí 2018-05-03 02:38:44 UTC Comment hidden (obsolete)
Comment 13 Furkan Tokac 2018-05-06 16:25:07 UTC
(In reply to Xisco Faulí from comment #12)
> A polite ping, still working on this bug?

There was a small problem so I was working on the investigation. The patch that I have done is compiled fine in QT based system but it throws error in GTK based system.

Anyway, there is a new developer. He'll handle this patch. I'll help to him. Thanks for your interest.
Comment 14 Furkan Ahmet KARA 2018-05-06 17:12:44 UTC
I am working on it.
Comment 15 Xisco Faulí 2018-06-06 02:44:12 UTC Comment hidden (obsolete)
Comment 16 Xisco Faulí 2018-07-07 02:37:20 UTC Comment hidden (obsolete)
Comment 17 Xisco Faulí 2018-08-07 02:31:17 UTC Comment hidden (obsolete)
Comment 18 Xisco Faulí 2018-09-07 02:41:39 UTC Comment hidden (obsolete)
Comment 19 Xisco Faulí 2018-10-08 02:45:57 UTC Comment hidden (obsolete)
Comment 20 Xisco Faulí 2018-11-08 04:04:57 UTC Comment hidden (obsolete)
Comment 21 Xisco Faulí 2018-12-09 03:39:10 UTC Comment hidden (obsolete)
Comment 22 Xisco Faulí 2019-01-09 03:43:07 UTC Comment hidden (obsolete)
Comment 23 Xisco Faulí 2019-02-09 03:43:02 UTC Comment hidden (obsolete)
Comment 24 Commit Notification 2019-03-11 11:32:59 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/a7bdd3eeb875350059b684df91e4900ba0886660%5E%21

tdf#112897 Put Help button on the left of dialog

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.