Bug 113025 - MAR updater uses unlocalized strings
Summary: MAR updater uses unlocalized strings
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Automatic-Updater Not-Localizable
  Show dependency treegraph
 
Reported: 2017-10-09 20:37 UTC by Adolfo Jayme
Modified: 2018-03-20 11:50 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adolfo Jayme 2017-10-09 20:37:07 UTC
The MAR UI, apart from hardcoding user-facing English strings, is duplicating them four times. The strings also contain “LibreOffice” when it should use a placeholder like “%PRODUCTNAME”.

https://opengrok.libreoffice.org/search?project=core&q="This+program+is+updating+your"&defs=&refs=&path=&hist=&type=
Comment 1 Xisco Faulí 2017-10-10 08:53:31 UTC
Moving to NEW.
I guess we can convert this into an easyhack
Comment 2 Markus Mohrhard 2017-10-10 09:24:57 UTC
Actually this is not fixable at all as the updater does not (and more importantly must not) depend on any LibreOffice code that is not inside of the updater executable. This includes the support for translations and %PRODUCTNAME.

Actually handling %PRODUCTNAME is not even necessary as the updater will be a TDF-only feature. I have not yet an idea how to solve the general translation problem.

The duplication is currently necessary as the code is heavily split between Windows and Linux and the whole updater UI does not (and currently can not) share any code.

This is clearly not an easy hack and possibly a WONTFIX.