Download it now!
Bug 113171 - Insert Text Box must not toggle at the menu
Summary: Insert Text Box must not toggle at the menu
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Unify-Across-Apps Textbox
  Show dependency treegraph
 
Reported: 2017-10-17 07:41 UTC by OfficeUser
Modified: 2019-06-13 14:43 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (107.69 KB, image/png)
2017-10-17 07:42 UTC, OfficeUser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description OfficeUser 2017-10-17 07:41:41 UTC
Please have a look at the the attached screenshot.

In Calc and Impress the insert text field menu item always stay visually selected after inserting one text field. This does not make sense because the function is not sticky.

I Calc the check marks is displayed as long as the new inserted text field is focused. Than it vanishes.

I vote for a common solution for Calc, Draw and Impress that NEVER shows this checkmark on the menu item. (Other functions like Insert/Comment also do NEVER display such a check mark.)
Comment 1 OfficeUser 2017-10-17 07:42:34 UTC
Created attachment 137035 [details]
Screenshot
Comment 2 OfficeUser 2017-10-17 09:30:37 UTC
I can still reproduce the bug with:

Version: 6.0.0.0.alpha0+
Build ID: c5a93cad149618bbd43632f1660a558c34bdbf7e
CPU threads: 8; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-10-07_01:12:25
Locale: de-DE (de_DE.UTF-8); Calc: group
Comment 3 OfficeUser 2017-10-17 09:38:18 UTC
Bug was already present in:

Version: 5.0.0.5
Build ID: 437e4abdf9e72fd0a6e6f8697a0e659bc77f9b10
Locale: de-DE (de_DE.UTF-8)
Comment 4 OfficeUser 2017-10-17 09:39:08 UTC
Note: The correct English name is "Text Box" not "Text field". Sorry.
Comment 5 Yousuf Philips (jay) (retired) 2017-10-17 13:41:20 UTC
So i notice in Draw, Impress, Calc is that if you press F2 on an existing textbox or have just inserted a textbox, the textbox button in the toolbar is toggle, which doesnt happen in Writer. As its not toggled in Writer, you can click it in the toolbar to create another textbox.

Heiko, Stuart, Maxim: What are your thoughts?
Comment 6 Heiko Tietze 2017-10-17 14:14:47 UTC
This behavior is similar to shapes where we 'toggle' on Draw but not Writer. Argument was that the workflow differs. (IIRC, I voted back then for double-click to make the function sticky.)

If we talk about harmonization of whether or not to toggle during the interaction of textbox creation I would prefer to not do that. But no hard feelings when the opposite decision will be taken.
Comment 7 Yousuf Philips (jay) (retired) 2017-10-17 20:34:26 UTC
The insert behaviour of shapes is in bug 90748 (writer/calc one way, impress/draw another way), but inserting a textbox in all apps is the same - you can only insert one, then type some text, and then have to click the button again to insert the next textbox. In impress/draw, after clicking it the second time after typing in the first textbox, it keeps it in insert textbox mode, so you dont have to press it again for the 3rd, 4th, etc textboxes.

The textbox button is getting toggle when editing a textbox outside of the insert process. see steps below.

1. draw a textbox
2. type some text
3. deselect textbox
4. select textbox
5. press F2
6. textbox button is toggled (this is what doesnt happen in writer)
Comment 8 Heiko Tietze 2018-06-08 08:14:25 UTC
(In reply to Yousuf Philips (jay) (retired) from comment #7)
> The textbox button is getting toggle when editing a textbox outside of the
> insert process. see steps below.

True, so the checkbox/toggle thing makes no sense and we should remove it. Very simple easy hack.
Comment 9 shubhamgoyal 2019-03-11 08:54:08 UTC
Can I get some Code pointers?
Comment 10 Heiko Tietze 2019-03-11 10:59:09 UTC
(In reply to shubh from comment #9)
> Can I get some Code pointers?

Menus list UNO commands, so it is https://opengrok.libreoffice.org/xref/core/sw/uiconfig/swriter/menubar/menubar.xml?r=16bd9c99#293 pointing to https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu?r=732d630c#3730. However, I expected the TOGGLE flag to be true and the easyhack would have been to switch it to FALSE. But that's not the fact here. Therefore we need input from experienced developers.
Comment 11 keyikedalubendang 2019-04-09 12:25:30 UTC
Saw this toggle behavior while preparing my slides by inserting custom text boxes.

It's true Insert TextBox must not toggle. Had me confused at first.