Bug 113512 - 1.15 Line spacing is missing in Format Spacing menu
Summary: 1.15 Line spacing is missing in Format Spacing menu
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords:
Depends on:
Blocks: Main-Menu UNO-Command-New Paragraph-Line-Spacing 145670
  Show dependency treegraph
 
Reported: 2017-10-29 17:37 UTC by Jim Raykowski
Modified: 2021-11-14 11:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2017-10-29 17:37:24 UTC
Format > Spacing menu is missing 1.15 line spacing entry
Comment 1 Dieter 2017-10-29 18:15:47 UTC
I confirm it.

Version: 6.0.0.0.alpha1 (x64)
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: group
Comment 2 Yousuf Philips (jay) (retired) 2017-10-29 20:37:58 UTC
Jim: Can you take this one on and create .uno:SpacePara115. Would be great if you can also create .uno:SpacePara25 and .uno:SpacePara3 as they will be useful as well.
Comment 3 Jim Raykowski 2017-10-29 20:58:00 UTC
Yes I have .uno:SpacePara115 implemented but ran into make check failing a unit test. Lot of different modules use .uno:SpaceParaXX. I will focus on Writer first. 

I will do 25 and 3 also.
Comment 4 Jim Raykowski 2017-11-04 20:18:57 UTC
Line spacing 1.15, 2.5 and 3 are added with this patch -

https://gerrit.libreoffice.org/#/c/44318/

Need someone to create lc_spacepara115.png, lc_spacepara25.png, and lc_spacepara3.png
Comment 5 Yousuf Philips (jay) (retired) 2017-11-21 14:05:10 UTC
Patch for the icons
https://gerrit.libreoffice.org/45038
Comment 6 QA Administrators 2018-11-22 03:47:49 UTC Comment hidden (obsolete)
Comment 7 Dieter 2018-11-22 18:41:06 UTC
Still repro in 

Version: 6.2.0.0.beta1 (x64)
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (de_DE); UI-Language: en-GB
Calc: threaded
Comment 8 QA Administrators 2019-11-23 03:44:09 UTC Comment hidden (obsolete)
Comment 9 Dieter 2021-10-10 05:30:19 UTC
Still present in

Version: 7.2.1.2 (x64) / LibreOffice Community
Build ID: 87b77fad49947c1441b67c559c339af8f3517e22
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Jim, can you have a look at it again?
Comment 10 Jim Raykowski 2021-10-13 22:05:51 UTC
Here is a patch that adds 1.15 line spacing UNO for use in Writer text, comments, and drawing shells: 

https://gerrit.libreoffice.org/c/core/+/123569

It needs an image.

I think patches for a 1.15 line spacing UNO for Draw/Impress and Calc and 2.5, 3 line spacing UNO commands can be a good way for a beginning LO hacker to learn how UNO commands are implemented.
Comment 11 Commit Notification 2021-10-19 06:23:54 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/40458226fda358bd90c25ddfe6a9b2cf25b2fcad

tdf#113512 Writer: 1.15 line spacing UNO command

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Heiko Tietze 2021-10-19 06:24:53 UTC
I might have been too fast with resolving fixed. Rizal, there is an image missing for this entry. Should be *_SpacePara115, but please double check.
Comment 13 Dieter 2021-10-30 07:13:53 UTC
(In reply to Heiko Tietze from comment #12)
> I might have been too fast with resolving fixed. Rizal, there is an image
> missing for this entry. Should be *_SpacePara115, but please double check.

Yes, image is missing => Back to NEW
Comment 14 Dieter 2021-10-30 07:15:13 UTC
Sorry, status should be reopen, but I can't set reopen any more
Comment 15 Rizal Muttaqin 2021-11-14 07:00:43 UTC
(In reply to Heiko Tietze from comment #12)
> I might have been too fast with resolving fixed. Rizal, there is an image
> missing for this entry. Should be *_SpacePara115, but please double check.

The bug for icon is tdf#145670
Comment 16 Dieter 2021-11-14 11:15:24 UTC
(In reply to Rizal Muttaqin from comment #15)
> The bug for icon is tdf#145670

Thnak you, Rizal. I think we can close this bug then
=> VERIFIED FIXED