Bug 113670 - UI Undocking the main toolbars and clicking insert textbox crashes the app
Summary: UI Undocking the main toolbars and clicking insert textbox crashes the app
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All Windows (All)
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: haveBacktrace
Depends on:
Blocks: Crash-Assert
  Show dependency treegraph
 
Reported: 2017-11-06 06:29 UTC by Emil Tanev
Modified: 2019-01-16 19:03 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
backtrace (4.62 KB, text/plain)
2018-01-15 00:19 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emil Tanev 2017-11-06 06:29:25 UTC
Start Writer
Undock both of the main toolbars
Click the Insert textbox icon
Issue: Crash

https://www.screencast.com/t/NoW9RnfRz

Version: 6.0.0.0.alpha1+ (x64)
Build ID: d30522e46ca884e9bc74af21711d9537e8118859
CPU threads: 8; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-10-30_00:25:37
Locale: ja-JP (ja_JP); Calc: CL
Comment 1 Telesto 2017-11-06 09:20:51 UTC
Repro with:
Version: 6.0.0.0.alpha1+
Build ID: b3f1d199a72ce87cb65ddaeac922564f57da6a4d
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-11-06_00:10:53
Locale: nl-NL (nl_NL); Calc: CL

and not with:
Version: 5.4.1.0.0+
Build ID: f200d5700782ae179fd96b6ad4b0fe8e7edd1616
CPU threads: 4; OS: Windows 6.29; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL
Comment 2 Julien Nabet 2017-11-06 09:33:36 UTC
I'll try to reproduce this but if someone may provide a bt it could be useful.

Let's increase importance too since it's a crash + regression.
Comment 3 Julien Nabet 2017-11-06 19:54:40 UTC
On pc Debian x86-64 with master sources updated today (0d50804e1c0c0ea2a5cd73fa3fa2a9ff0a0e7048), with gen rendering (so the nearest one of Windows), I don't reproduce this.
Comment 4 Emil Tanev 2017-11-07 14:54:02 UTC
This happens with other icons as well, for example Insert Basic Shapes. 
Additionally, even if you do not undock BOTH toolbars, but only the one where the icon/button is, if you click the icon/button twice, the app crashes.
Comment 5 raal 2017-11-07 16:16:26 UTC
This seems to have begun at the below commit.
Adding Cc: to Justin Luth ; Could you possibly take a look at this one?
Thanks
 364381eb6bf7bdd6d01edf4ac9f68a9ff7c2efb5 is the first bad commit
commit 364381eb6bf7bdd6d01edf4ac9f68a9ff7c2efb5
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Sat Sep 30 13:48:45 2017 -0700

    source 892c719fffa06de4c7aeab497326cad7bae9e5c6
author    Justin Luth <justin_luth@sil.org>    2017-09-21 00:44:01 (GMT)
committer    Justin Luth <justin_luth@sil.org>    2017-09-27 01:59:33 (GMT)
commit    892c719fffa06de4c7aeab497326cad7bae9e5c6 (patch)
tree    4c7107df4428492ddb1a4a2edfc3aafa5ea30a6f
parent    465092047d5fa6ec6dd369372e712d76554570ff (diff)
Revert "tdf#108932 - prevent textbox shrink from actually growing"
Comment 6 Justin L 2017-11-07 17:34:23 UTC
(In reply to raal from comment #5)
Highly unlikely that a unrelated, revert of a recent commit would cause this. Better retest and start before 2017-08-31.
Comment 7 Xisco Faulí 2017-11-28 23:53:33 UTC
After the changes done by Caolán, is this issue still reproducible in master?
Comment 8 Xisco Faulí 2017-12-04 14:11:53 UTC
@Emil, @raal, is this issue still reproducible in master?
Comment 9 Emil Tanev 2017-12-04 17:53:05 UTC
I can reproduce it in 

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 04982dc8f56e3a960b4d42b0ec57fc5cb8a01aa3
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-04_01:29:50
Locale: ja-JP (ja_JP); Calc: group threaded
Comment 10 Xisco Faulí 2017-12-10 17:00:51 UTC
(In reply to Emil Tanev from comment #9)
> I can reproduce it in 
> 
> Version: 6.1.0.0.alpha0+ (x64)
> Build ID: 04982dc8f56e3a960b4d42b0ec57fc5cb8a01aa3
> CPU threads: 1; OS: Windows 6.1; UI render: default; 
> TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-04_01:29:50
> Locale: ja-JP (ja_JP); Calc: group threaded

Could you please get a backtrace as explained here: https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg ?
Comment 11 Xisco Faulí 2018-01-09 16:19:53 UTC
I guess the bisection is incorrect
Comment 12 Telesto 2018-01-13 09:32:44 UTC
Repro with
Version: 6.1.0.0.alpha0+
Build ID: ef22c4a0a99be5d2903fb9e9d09fc852cd791173
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-01-12_09:16:04
Locale: nl-NL (nl_NL); Calc: CL
Comment 13 Telesto 2018-01-13 09:38:34 UTC
Assertion failed!

Program: C:\LibO1novDebug\program\vcllo.dll
File: C:/cygwin/home/tinderbox/master/vcl/win/app/salinst.cxx
Line: 625

Expression: !pInst->mbNoYieldLock
Comment 14 Aron Budea 2018-01-15 00:19:32 UTC
Created attachment 139095 [details]
backtrace

Yes, this is an assert, which means even if it's a regression it's not bibisectable in Windows (removing keywords for now, Telesto if your 5.4.1.0.0+ build is debug one, feel free to readd keywords regression and notBibisectable). Attaching backtrace.
Comment 15 QA Administrators 2019-01-16 03:54:56 UTC Comment hidden (obsolete)
Comment 16 Xisco Faulí 2019-01-16 19:03:15 UTC
No longer reproduced in

Versión: 6.2.0.2
Id. de compilación: 2ce5217b30a543f7666022df50f0562f82be0cff
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded

@Emil Tanev, please double-check

Closing as RESOLVED WORKSFORME